From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E639BC43381 for ; Fri, 22 Mar 2019 12:01:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B522E2192D for ; Fri, 22 Mar 2019 12:01:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1553256113; bh=3PNrxkLL2htSQGcHQ/UPY81FLDl/DTjS6jrcNCzmUxg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=a1H+SNLUxmLT+djrZDCNt7mbI/WzUtem28miNxovPIBdkgurp8Q65B/LHp2DtWjFo Q8iOFABEokco3U7u997HO8C5KffIW1gVtyDHJOjUAS4JCbcNO4sLhkaTHKb+uMrfNn fwydfsm+yX6LQKJo4/R44Z0wUmLRzY1h6FuI2boY= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387939AbfCVMBw (ORCPT ); Fri, 22 Mar 2019 08:01:52 -0400 Received: from mail.kernel.org ([198.145.29.99]:39636 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388255AbfCVMBt (ORCPT ); Fri, 22 Mar 2019 08:01:49 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 840AA204FD; Fri, 22 Mar 2019 12:01:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1553256109; bh=3PNrxkLL2htSQGcHQ/UPY81FLDl/DTjS6jrcNCzmUxg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=lcOvPMUk1YTUIU1WVX7Zx3uzCO5B56qYbXxnUwRamno7UPH8oj5ftbJGXWZ/14xhh tLW0GocDrkhzSWyQFdFw1TadVkjLFZPsGebJQbW2HxSgmwTGDZjbMPvvtc2XWB0fHU L/2N9nZbhiRL8zzKBc6/TPqIwI6cS3GQrfk60Q9Q= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Dan Carpenter , "Darrick J. Wong" , Hugh Dickins , Matej Kupljen , Al Viro , Andrew Morton , Linus Torvalds , Sasha Levin Subject: [PATCH 4.19 111/280] tmpfs: fix uninitialized return value in shmem_link Date: Fri, 22 Mar 2019 12:14:24 +0100 Message-Id: <20190322111313.534799120@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190322111306.356185024@linuxfoundation.org> References: <20190322111306.356185024@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.19-stable review patch. If anyone has any objections, please let me know. ------------------ [ Upstream commit 29b00e609960ae0fcff382f4c7079dd0874a5311 ] When we made the shmem_reserve_inode call in shmem_link conditional, we forgot to update the declaration for ret so that it always has a known value. Dan Carpenter pointed out this deficiency in the original patch. Fixes: 1062af920c07 ("tmpfs: fix link accounting when a tmpfile is linked in") Reported-by: Dan Carpenter Signed-off-by: Darrick J. Wong Signed-off-by: Hugh Dickins Cc: Matej Kupljen Cc: Al Viro Cc: Andrew Morton Signed-off-by: Linus Torvalds Signed-off-by: Sasha Levin --- mm/shmem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/shmem.c b/mm/shmem.c index bf13966b009c..3c8742655756 100644 --- a/mm/shmem.c +++ b/mm/shmem.c @@ -2895,7 +2895,7 @@ static int shmem_create(struct inode *dir, struct dentry *dentry, umode_t mode, static int shmem_link(struct dentry *old_dentry, struct inode *dir, struct dentry *dentry) { struct inode *inode = d_inode(old_dentry); - int ret; + int ret = 0; /* * No ordinary (disk based) filesystem counts links as inodes; -- 2.19.1