From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BFBCEC43381 for ; Fri, 22 Mar 2019 12:07:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8AED021916 for ; Fri, 22 Mar 2019 12:07:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1553256420; bh=sHvXRqc2XQ/23EYlH3W13invO/Lk4Ee4ep1CRQj43gc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=GvRnDTTlkR/ZIKW6vVHqj02anZCey4iJhdZg6QRcdo1fv/tOpvDJKCdGdiZUaNkkR WBdFLo/KVpuLiibS1UqDtwj8QXK5YGyqCKAh0e3BVzhqKFYWXZE5CnfeilrXF0UKT6 t6iVn63x0tYCLA0en9w0y5HjjYg/MB3PLenQTYs8= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388980AbfCVMG7 (ORCPT ); Fri, 22 Mar 2019 08:06:59 -0400 Received: from mail.kernel.org ([198.145.29.99]:45388 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730757AbfCVMG4 (ORCPT ); Fri, 22 Mar 2019 08:06:56 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 24E6221916; Fri, 22 Mar 2019 12:06:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1553256415; bh=sHvXRqc2XQ/23EYlH3W13invO/Lk4Ee4ep1CRQj43gc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=O3BuxOBDWD5KMu5GqYL7Ed0ADCfd7CVPLlfFVgr+ngJuSAF0/VwHre3HnQ5HmKAiI zeDChs4eOB4ASusotdppSn7HdPXy26fAhm6j1fGze/+L6TQrhHVLE0YdhjyMum+2Sh ESF8inGcJ61Q0OktE38CWGBZOToVUmV9l9+c01io= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Heikki Krogerus , Andy Shevchenko , "Rafael J. Wysocki" Subject: [PATCH 4.19 204/280] device property: Fix the length used in PROPERTY_ENTRY_STRING() Date: Fri, 22 Mar 2019 12:15:57 +0100 Message-Id: <20190322111331.380539594@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190322111306.356185024@linuxfoundation.org> References: <20190322111306.356185024@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.19-stable review patch. If anyone has any objections, please let me know. ------------------ From: Heikki Krogerus commit 2b6e492467c78183bb629bb0a100ea3509b615a5 upstream. With string type property entries we need to use sizeof(const char *) instead of the number of characters as the length of the entry. If the string was shorter then sizeof(const char *), attempts to read it would have failed with -EOVERFLOW. The problem has been hidden because all build-in string properties have had a string longer then 8 characters until now. Fixes: a85f42047533 ("device property: helper macros for property entry creation") Cc: 4.5+ # 4.5+ Signed-off-by: Heikki Krogerus Reviewed-by: Andy Shevchenko Signed-off-by: Rafael J. Wysocki Signed-off-by: Greg Kroah-Hartman --- include/linux/property.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/include/linux/property.h +++ b/include/linux/property.h @@ -258,7 +258,7 @@ struct property_entry { #define PROPERTY_ENTRY_STRING(_name_, _val_) \ (struct property_entry) { \ .name = _name_, \ - .length = sizeof(_val_), \ + .length = sizeof(const char *), \ .type = DEV_PROP_STRING, \ { .value = { .str = _val_ } }, \ }