From: Borislav Petkov <bp@alien8.de>
To: "Ghannam, Yazen" <Yazen.Ghannam@amd.com>
Cc: "linux-edac@vger.kernel.org" <linux-edac@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"tony.luck@intel.com" <tony.luck@intel.com>,
"x86@kernel.org" <x86@kernel.org>,
"rafal@milecki.pl" <rafal@milecki.pl>,
"clemej@gmail.com" <clemej@gmail.com>
Subject: Re: [PATCH v2 2/2] x86/MCE/AMD: Don't report L1 BTB MCA errors on some Family 17h models
Date: Fri, 22 Mar 2019 20:32:28 +0100 [thread overview]
Message-ID: <20190322193228.GN12472@zn.tnic> (raw)
In-Reply-To: <feea1978-04ef-82f9-933e-4ae280391aea@amd.com>
On Fri, Mar 22, 2019 at 07:24:01PM +0000, Ghannam, Yazen wrote:
> Generally, the model groups share the same hardware design and so the
> same quirks. So I'm thinking that it'd be more efficient to have a
> filter function that targets a specific group of models rather than
> one that checks all known quirks on all models.
Or simply start with a amd_filter_mce() function and when it grows big
and unwieldy, only *then* start thinking about splitting it into models
and families. For now, you're fine with a single AMD-specific function.
> Most of the quirks are dealt with at init time, but this needs be to
> done during run time for each MCE that is logged. So I didn't want to
> add unnecessary checks to the MCE handlers. We have quirk_no_way_out()
> that does something similar.
I don't think a couple of instructions checking vendor and family would
be at all noticeable so let's start simple.
--
Regards/Gruss,
Boris.
Good mailing practices for 400: avoid top-posting and trim the reply.
next prev parent reply other threads:[~2019-03-22 19:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-21 20:25 [PATCH v2 1/2] x86/MCE: Add function to allow filtering of MCA errors Ghannam, Yazen
2019-03-21 20:25 ` [PATCH v2 2/2] x86/MCE/AMD: Don't report L1 BTB MCA errors on some Family 17h models Ghannam, Yazen
2019-03-22 17:34 ` Borislav Petkov
2019-03-22 19:24 ` Ghannam, Yazen
2019-03-22 19:32 ` Borislav Petkov [this message]
2019-03-22 19:33 ` Ghannam, Yazen
2019-03-22 17:24 ` [PATCH v2 1/2] x86/MCE: Add function to allow filtering of MCA errors Borislav Petkov
2019-03-22 19:05 ` Ghannam, Yazen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190322193228.GN12472@zn.tnic \
--to=bp@alien8.de \
--cc=Yazen.Ghannam@amd.com \
--cc=clemej@gmail.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafal@milecki.pl \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).