From: Borislav Petkov <bp@alien8.de>
To: "Ghannam, Yazen" <Yazen.Ghannam@amd.com>
Cc: "linux-edac@vger.kernel.org" <linux-edac@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 3/6] EDAC/amd64: Support more than two Unified Memory Controllers
Date: Sat, 23 Mar 2019 13:15:47 +0100 [thread overview]
Message-ID: <20190323121546.GA17541@zn.tnic> (raw)
In-Reply-To: <20190228153558.127292-3-Yazen.Ghannam@amd.com>
On Thu, Feb 28, 2019 at 03:36:10PM +0000, Ghannam, Yazen wrote:
> diff --git a/drivers/edac/amd64_edac.h b/drivers/edac/amd64_edac.h
> index de8dbb0b42b5..40e63cea2d81 100644
> --- a/drivers/edac/amd64_edac.h
> +++ b/drivers/edac/amd64_edac.h
> @@ -274,7 +274,11 @@
>
> #define UMC_SDP_INIT BIT(31)
>
> -#define NUM_UMCS 2
> +/*
> + * Number of Unified Memory Controllers
> + * Set during driver init based on family/model.
> + */
> +static u8 num_umcs;
Please don't do silly things like that:
In file included from drivers/edac/amd64_edac_inj.c:2:0:
drivers/edac/amd64_edac.h:279:11: warning: ‘num_umcs’ defined but not used [-Wunused-variable]
static u8 num_umcs;
^~~~~~~~
I fixed it up now.
--
Regards/Gruss,
Boris.
Good mailing practices for 400: avoid top-posting and trim the reply.
next prev parent reply other threads:[~2019-03-23 12:15 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-28 15:36 [PATCH v3 1/6] EDAC/amd64: Add Family 17h Model 30h PCI IDs Ghannam, Yazen
2019-02-28 15:36 ` [PATCH v3 3/6] EDAC/amd64: Support more than two Unified Memory Controllers Ghannam, Yazen
2019-03-23 12:15 ` Borislav Petkov [this message]
2019-03-23 17:22 ` Ghannam, Yazen
2019-02-28 15:36 ` [PATCH v3 2/6] EDAC/amd64: Use a macro for iterating over " Ghannam, Yazen
2019-02-28 15:36 ` [PATCH v3 5/6] EDAC/amd64: Support more than two Controllers for Chip Select handling Ghannam, Yazen
2019-02-28 15:36 ` [PATCH v3 4/6] EDAC/amd64: Recognize x16 Symbol Size Ghannam, Yazen
2019-02-28 15:36 ` [PATCH v3 6/6] EDAC/amd64: Adjust printed Chip Select sizes when interleaved Ghannam, Yazen
2019-03-21 20:30 ` [PATCH v3 1/6] EDAC/amd64: Add Family 17h Model 30h PCI IDs Ghannam, Yazen
2019-03-22 16:33 ` Kim Phillips
2019-03-22 16:46 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190323121546.GA17541@zn.tnic \
--to=bp@alien8.de \
--cc=Yazen.Ghannam@amd.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).