From: Andi Kleen <ak@linux.intel.com>
To: Masami Hiramatsu <mhiramat@kernel.org>
Cc: Andi Kleen <andi@firstfloor.org>,
x86@kernel.org, akpm@linux-foundation.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 11/17] x86/kprobes: Make trampoline_handler global and visible
Date: Sat, 23 Mar 2019 07:35:18 -0700 [thread overview]
Message-ID: <20190323143518.GB18020@tassilo.jf.intel.com> (raw)
In-Reply-To: <20190323184521.a443cc741997cb0d3ed26395@kernel.org>
On Sat, Mar 23, 2019 at 06:45:21PM +0900, Masami Hiramatsu wrote:
> On Thu, 21 Mar 2019 15:00:03 -0700
> Andi Kleen <andi@firstfloor.org> wrote:
>
> > From: Andi Kleen <ak@linux.intel.com>
> >
> > This function is referenced from assembler, so in LTO
> > it needs to be global and visible to not be optimized away.
> >
>
> I got it.
>
> Acked-by: Masami Hiramatsu <mhiramat@kernel.org>
>
> Andi, out of curiousity, that is not only for x86, but
> does all arch have to care it?
Yes all architectures need it for LTO, but I currently
only test x86. There are some other people who made it work
on ARM / MIPS / PowerPC before.
-Andi
next prev parent reply other threads:[~2019-03-23 14:35 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-21 21:59 Fixes and cleanup from LTO tree Andi Kleen
2019-03-21 21:59 ` [PATCH 01/17] kbuild: Disable -Waddress-of-packed-member for gcc 9 Andi Kleen
2019-03-22 13:58 ` Arnd Bergmann
2019-03-22 16:31 ` Andi Kleen
2019-03-22 16:39 ` Peter Zijlstra
2019-03-22 16:57 ` Arnd Bergmann
2019-03-22 16:58 ` Andi Kleen
2019-03-25 16:27 ` David Laight
2019-04-01 1:04 ` Masahiro Yamada
2019-03-21 21:59 ` [PATCH 02/17] x86, lto: Mark all top level asm statements as .text Andi Kleen
2019-03-26 17:03 ` Thomas Gleixner
2019-03-26 21:38 ` Andi Kleen
2019-03-26 22:25 ` Thomas Gleixner
2019-03-27 0:55 ` Andi Kleen
2019-03-27 1:08 ` Andi Kleen
2019-03-27 14:20 ` Thomas Gleixner
2019-03-27 14:39 ` Ingo Molnar
2019-03-27 14:59 ` Andi Kleen
2019-03-27 15:08 ` Thomas Gleixner
2019-03-27 15:45 ` Andi Kleen
2019-03-27 19:08 ` Thomas Gleixner
2019-03-27 20:40 ` Andi Kleen
2019-03-27 21:55 ` Thomas Gleixner
2019-03-27 22:29 ` Andi Kleen
2019-03-27 22:50 ` Thomas Gleixner
2019-04-02 8:54 ` Thomas Gleixner
2019-03-21 21:59 ` [PATCH 03/17] x86: Don't inline __const_udelay Andi Kleen
2019-03-21 21:59 ` [PATCH 04/17] init: Add __noreorder and mark initcalls __noreorder Andi Kleen
2019-03-21 21:59 ` [PATCH 05/17] Use C version for SYSCALL_ALIAS Andi Kleen
2019-03-21 21:59 ` [PATCH 06/17] locking/core: Mark spinlocks noinline when inline spinlocks are disabled Andi Kleen
2019-03-21 21:59 ` [PATCH 07/17] amdkfd: Fix extern declaration Andi Kleen
2019-03-21 22:00 ` [PATCH 08/17] x86/speculation: Fix __initconst in bugs.c Andi Kleen
2019-03-26 17:24 ` Thomas Gleixner
2019-03-21 22:00 ` [PATCH 09/17] x86/kvm: Make steal_time visible Andi Kleen
2019-03-21 22:00 ` [PATCH 10/17] delta: Fix buffer overrun in delta_ipc_open Andi Kleen
2019-04-01 13:37 ` Hugues FRUCHET
2019-04-01 16:54 ` Andi Kleen
2019-04-02 9:56 ` Hugues FRUCHET
2019-03-21 22:00 ` [PATCH 11/17] x86/kprobes: Make trampoline_handler global and visible Andi Kleen
2019-03-23 9:45 ` Masami Hiramatsu
2019-03-23 14:35 ` Andi Kleen [this message]
2019-03-25 1:53 ` Masami Hiramatsu
2019-03-21 22:00 ` [PATCH 12/17] afs: Avoid section confusion in CM_NAME Andi Kleen
2019-03-21 22:00 ` [PATCH 13/17] ASoC: AMD: Fix incorrect extern Andi Kleen
2019-03-21 22:00 ` [PATCH 14/17] crypto: Don't mark AES tables const and cacheline_aligned Andi Kleen
2019-03-26 8:42 ` Rasmus Villemoes
2019-03-26 18:30 ` Andi Kleen
2019-03-21 22:00 ` [PATCH 15/17] x86/hyperv: Make hv_vcpu_is_preempted visible Andi Kleen
2019-03-26 8:15 ` Yi Sun
2019-03-21 22:00 ` [PATCH 16/17] x86/xen: Mark xen_vcpu_stolen as __visible Andi Kleen
2019-03-21 22:00 ` [PATCH 17/17] dm: Fix const confusion in dm Andi Kleen
2019-03-22 8:34 ` [PATCH 12/17] afs: Avoid section confusion in CM_NAME David Howells
2019-03-26 17:00 ` Fixes and cleanup from LTO tree Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190323143518.GB18020@tassilo.jf.intel.com \
--to=ak@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).