archive mirror
 help / color / mirror / Atom feed
From: Borislav Petkov <>
To: Alexey Dobriyan <>
Subject: Re: [PATCH 2/4] x86, putuser: copy pasta into 32 and 64-bit versions
Date: Sun, 24 Mar 2019 22:51:01 +0100	[thread overview]
Message-ID: <20190324215101.GL23289@zn.tnic> (raw)
In-Reply-To: <20190316210239.GB21830@avx2>

On Sun, Mar 17, 2019 at 12:02:39AM +0300, Alexey Dobriyan wrote:
> I'm going to rewrite 64-bit version to use normal x86_64 calling convention.

This commit message is too laconic and it needs to be in passive voice
and impartial. Also, here or in your 4/4 I'm missing the justification
for why you're doing all this.


Good mailing practices for 400: avoid top-posting and trim the reply.

      reply	other threads:[~2019-03-24 21:51 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-16 21:02 Alexey Dobriyan
2019-03-24 21:51 ` Borislav Petkov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190324215101.GL23289@zn.tnic \ \ \ \ \ \ \ \
    --subject='Re: [PATCH 2/4] x86, putuser: copy pasta into 32 and 64-bit versions' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).