From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 842B5C43381 for ; Mon, 25 Mar 2019 08:21:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 465DC20879 for ; Mon, 25 Mar 2019 08:21:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730019AbfCYIV2 (ORCPT ); Mon, 25 Mar 2019 04:21:28 -0400 Received: from mx1.redhat.com ([209.132.183.28]:34226 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729914AbfCYIV1 (ORCPT ); Mon, 25 Mar 2019 04:21:27 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id A6A0981F1B; Mon, 25 Mar 2019 08:21:27 +0000 (UTC) Received: from localhost (ovpn-12-56.pek2.redhat.com [10.72.12.56]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 122835DA27; Mon, 25 Mar 2019 08:21:26 +0000 (UTC) Date: Mon, 25 Mar 2019 16:21:24 +0800 From: Baoquan He To: Borislav Petkov Cc: Junichi Nomura , "fanc.fnst@cn.fujitsu.com" , "linux-kernel@vger.kernel.org" , "x86@kernel.org" Subject: Re: [PATCH] x86/boot: Use EFI setup data if provided Message-ID: <20190325082124.GD3659@MiWiFi-R3L-srv> References: <20190322110342.GA16202@jeru.linux.bs1.fc.nec.co.jp> <20190322152328.GD12472@zn.tnic> <20190325072710.GA31828@MiWiFi-R3L-srv> <20190325075342.GE12016@zn.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190325075342.GE12016@zn.tnic> User-Agent: Mutt/1.10.1 (2018-07-13) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Mon, 25 Mar 2019 08:21:27 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/25/19 at 08:53am, Borislav Petkov wrote: > On Mon, Mar 25, 2019 at 03:27:10PM +0800, Baoquan He wrote: > > Kexec kernel also need to get rsdp to get SRAT tables so that KASLR can > > avoid those hotpluggable regions in boot compression stage. > > > > The kexec_file_load has filled in acpi_rsdp_addr of kexec kernel in > > below code. It will return direclty in get_rsdp_addr() since > > acpi_rsdp_addr is got from boot_params->acpi_rsdp_addr. > > > > arch/x86/kernel/kexec-bzimage64.c <> > > params->acpi_rsdp_addr = boot_params.acpi_rsdp_addr; > > > > The other interface, kexec_load, its boot_params filling is done in user > > space kexec_tools. And we haven't made the acpi_rsdp_addr filling yet. > > And the old kexec_tools utility can also cause the new kexec kernel to > > search efi rspd pointer even thought it's fixed. > > Yes, kexec is a pile of ugly and fragile hackery. Well, yes, we have to admit that, since kexec is based on hacking. It never miss chance to give us bumps all over the head. If it hasn't been changed to cater the kernel iamge verification, the kexec_load is enough to serve, and maintaining most of codes in user space won't impact other component. Thanks Baoquan