From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Cc: thierry.reding@gmail.com, narmstrong@baylibre.com,
jbrunet@baylibre.com, linux-pwm@vger.kernel.org,
linux-amlogic@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/1] pwm: meson: fix scheduling while atomic issue
Date: Mon, 25 Mar 2019 09:50:37 +0100 [thread overview]
Message-ID: <20190325085037.f4weycbhaa7yyurt@pengutronix.de> (raw)
In-Reply-To: <20190325084153.l44pzfewcqlkoaoe@pengutronix.de>
Hello,
On Mon, Mar 25, 2019 at 09:41:53AM +0100, Uwe Kleine-König wrote:
> If you want to implement further cleanups, my questions and propositions
> are:
>
> - Is there a publicly available manual for this hardware? If yes, you
> can add a link to it in the header of the driver.
>
> - Why do you handle reparenting of the PWM's clk in .request? Wouldn't
> this be more suitable in .apply?
>
> - Does stopping the PWM (i.e. clearing MISC_{A,B}_EN in the MISC_AB
> register) freeze the output, or is the currently running period
> completed first? (The latter is the right behaviour.)
>
> - Please point out in the header that for changing period/duty
> cycle/polarity the hardware must be stopped. (I suggest to apply the
> style used in https://www.spinics.net/lists/linux-pwm/msg09262.html
> for some consistency.)
Another thing I just noted: The .get_state callback only sets .enabled
but nothing of the remaining information is provided.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
next prev parent reply other threads:[~2019-03-25 8:50 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-24 22:02 [PATCH 0/1] pwm: meson: fix scheduling while atomic issue Martin Blumenstingl
2019-03-24 22:02 ` [PATCH 1/1] pwm: meson: use the spin-lock only to protect register modifications Martin Blumenstingl
2019-03-25 8:48 ` Uwe Kleine-König
2019-03-25 8:41 ` [PATCH 0/1] pwm: meson: fix scheduling while atomic issue Uwe Kleine-König
2019-03-25 8:50 ` Uwe Kleine-König [this message]
2019-03-25 17:41 ` Martin Blumenstingl
2019-03-25 20:07 ` Uwe Kleine-König
2019-03-26 20:05 ` Martin Blumenstingl
2019-03-30 19:29 ` Martin Blumenstingl
2019-03-31 18:47 ` Uwe Kleine-König
2019-04-01 7:25 ` Neil Armstrong
2019-03-26 9:06 ` Neil Armstrong
2019-03-26 10:54 ` Uwe Kleine-König
2019-03-25 9:35 ` Jerome Brunet
2019-03-25 18:04 ` Martin Blumenstingl
2019-03-26 8:37 ` Jerome Brunet
2019-03-26 8:57 ` Neil Armstrong
2019-03-26 20:16 ` Martin Blumenstingl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190325085037.f4weycbhaa7yyurt@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=jbrunet@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=narmstrong@baylibre.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).