From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6EB6CC43381 for ; Mon, 25 Mar 2019 17:32:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 32031205C9 for ; Mon, 25 Mar 2019 17:32:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729825AbfCYRcd (ORCPT ); Mon, 25 Mar 2019 13:32:33 -0400 Received: from 12.mo4.mail-out.ovh.net ([178.33.104.253]:35824 "EHLO 12.mo4.mail-out.ovh.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725788AbfCYRcc (ORCPT ); Mon, 25 Mar 2019 13:32:32 -0400 X-Greylist: delayed 2224 seconds by postgrey-1.27 at vger.kernel.org; Mon, 25 Mar 2019 13:32:27 EDT Received: from player778.ha.ovh.net (unknown [10.109.160.232]) by mo4.mail-out.ovh.net (Postfix) with ESMTP id AAB511E011B for ; Mon, 25 Mar 2019 17:55:21 +0100 (CET) Received: from kaod.org (lns-bzn-46-82-253-208-248.adsl.proxad.net [82.253.208.248]) (Authenticated sender: groug@kaod.org) by player778.ha.ovh.net (Postfix) with ESMTPSA id 26F163F9C8DF; Mon, 25 Mar 2019 16:55:14 +0000 (UTC) Date: Mon, 25 Mar 2019 17:55:13 +0100 From: Greg Kurz To: "Alastair D'Silva" Cc: alastair@d-silva.org, Arnd Bergmann , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, Andrew Donnellan , Frederic Barrat , linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH v4 3/4] ocxl: Remove superfluous 'extern' from headers Message-ID: <20190325175513.72fb3173@bahia.lab.toulouse-stg.fr.ibm.com> In-Reply-To: <20190325053456.14599-4-alastair@au1.ibm.com> References: <20190320053448.2098-1-alastair@au1.ibm.com> <20190325053456.14599-1-alastair@au1.ibm.com> <20190325053456.14599-4-alastair@au1.ibm.com> X-Mailer: Claws Mail 3.16.0 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Ovh-Tracer-Id: 574490427766577483 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedutddrjeekgdeljecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfqggfjpdevjffgvefmvefgnecuuegrihhlohhuthemucehtddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 25 Mar 2019 16:34:54 +1100 "Alastair D'Silva" wrote: > From: Alastair D'Silva > > The 'extern' keyword adds no value here. > > Signed-off-by: Alastair D'Silva > --- Reviewed-by: Greg Kurz > drivers/misc/ocxl/ocxl_internal.h | 54 +++++++++++++++---------------- > include/misc/ocxl.h | 36 ++++++++++----------- > 2 files changed, 44 insertions(+), 46 deletions(-) > > diff --git a/drivers/misc/ocxl/ocxl_internal.h b/drivers/misc/ocxl/ocxl_internal.h > index a32f2151029f..321b29e77f45 100644 > --- a/drivers/misc/ocxl/ocxl_internal.h > +++ b/drivers/misc/ocxl/ocxl_internal.h > @@ -16,7 +16,6 @@ > > extern struct pci_driver ocxl_pci_driver; > > - > struct ocxl_fn { > struct device dev; > int bar_used[3]; > @@ -92,41 +91,40 @@ struct ocxl_process_element { > __be32 software_state; > }; > > +struct ocxl_afu *ocxl_afu_get(struct ocxl_afu *afu); > +void ocxl_afu_put(struct ocxl_afu *afu); > > -extern struct ocxl_afu *ocxl_afu_get(struct ocxl_afu *afu); > -extern void ocxl_afu_put(struct ocxl_afu *afu); > - > -extern int ocxl_create_cdev(struct ocxl_afu *afu); > -extern void ocxl_destroy_cdev(struct ocxl_afu *afu); > -extern int ocxl_register_afu(struct ocxl_afu *afu); > -extern void ocxl_unregister_afu(struct ocxl_afu *afu); > +int ocxl_create_cdev(struct ocxl_afu *afu); > +void ocxl_destroy_cdev(struct ocxl_afu *afu); > +int ocxl_register_afu(struct ocxl_afu *afu); > +void ocxl_unregister_afu(struct ocxl_afu *afu); > > -extern int ocxl_file_init(void); > -extern void ocxl_file_exit(void); > +int ocxl_file_init(void); > +void ocxl_file_exit(void); > > -extern int ocxl_pasid_afu_alloc(struct ocxl_fn *fn, u32 size); > -extern void ocxl_pasid_afu_free(struct ocxl_fn *fn, u32 start, u32 size); > -extern int ocxl_actag_afu_alloc(struct ocxl_fn *fn, u32 size); > -extern void ocxl_actag_afu_free(struct ocxl_fn *fn, u32 start, u32 size); > +int ocxl_pasid_afu_alloc(struct ocxl_fn *fn, u32 size); > +void ocxl_pasid_afu_free(struct ocxl_fn *fn, u32 start, u32 size); > +int ocxl_actag_afu_alloc(struct ocxl_fn *fn, u32 size); > +void ocxl_actag_afu_free(struct ocxl_fn *fn, u32 start, u32 size); > > -extern struct ocxl_context *ocxl_context_alloc(void); > -extern int ocxl_context_init(struct ocxl_context *ctx, struct ocxl_afu *afu, > +struct ocxl_context *ocxl_context_alloc(void); > +int ocxl_context_init(struct ocxl_context *ctx, struct ocxl_afu *afu, > struct address_space *mapping); > -extern int ocxl_context_attach(struct ocxl_context *ctx, u64 amr); > -extern int ocxl_context_mmap(struct ocxl_context *ctx, > +int ocxl_context_attach(struct ocxl_context *ctx, u64 amr); > +int ocxl_context_mmap(struct ocxl_context *ctx, > struct vm_area_struct *vma); > -extern int ocxl_context_detach(struct ocxl_context *ctx); > -extern void ocxl_context_detach_all(struct ocxl_afu *afu); > -extern void ocxl_context_free(struct ocxl_context *ctx); > +int ocxl_context_detach(struct ocxl_context *ctx); > +void ocxl_context_detach_all(struct ocxl_afu *afu); > +void ocxl_context_free(struct ocxl_context *ctx); > > -extern int ocxl_sysfs_add_afu(struct ocxl_afu *afu); > -extern void ocxl_sysfs_remove_afu(struct ocxl_afu *afu); > +int ocxl_sysfs_add_afu(struct ocxl_afu *afu); > +void ocxl_sysfs_remove_afu(struct ocxl_afu *afu); > > -extern int ocxl_afu_irq_alloc(struct ocxl_context *ctx, u64 *irq_offset); > -extern int ocxl_afu_irq_free(struct ocxl_context *ctx, u64 irq_offset); > -extern void ocxl_afu_irq_free_all(struct ocxl_context *ctx); > -extern int ocxl_afu_irq_set_fd(struct ocxl_context *ctx, u64 irq_offset, > +int ocxl_afu_irq_alloc(struct ocxl_context *ctx, u64 *irq_offset); > +int ocxl_afu_irq_free(struct ocxl_context *ctx, u64 irq_offset); > +void ocxl_afu_irq_free_all(struct ocxl_context *ctx); > +int ocxl_afu_irq_set_fd(struct ocxl_context *ctx, u64 irq_offset, > int eventfd); > -extern u64 ocxl_afu_irq_get_addr(struct ocxl_context *ctx, u64 irq_offset); > +u64 ocxl_afu_irq_get_addr(struct ocxl_context *ctx, u64 irq_offset); > > #endif /* _OCXL_INTERNAL_H_ */ > diff --git a/include/misc/ocxl.h b/include/misc/ocxl.h > index 9ff6ddc28e22..4544573cc93c 100644 > --- a/include/misc/ocxl.h > +++ b/include/misc/ocxl.h > @@ -53,7 +53,7 @@ struct ocxl_fn_config { > * Read the configuration space of a function and fill in a > * ocxl_fn_config structure with all the function details > */ > -extern int ocxl_config_read_function(struct pci_dev *dev, > +int ocxl_config_read_function(struct pci_dev *dev, > struct ocxl_fn_config *fn); > > /* > @@ -62,14 +62,14 @@ extern int ocxl_config_read_function(struct pci_dev *dev, > * AFU indexes can be sparse, so a driver should check all indexes up > * to the maximum found in the function description > */ > -extern int ocxl_config_check_afu_index(struct pci_dev *dev, > +int ocxl_config_check_afu_index(struct pci_dev *dev, > struct ocxl_fn_config *fn, int afu_idx); > > /* > * Read the configuration space of a function for the AFU specified by > * the index 'afu_idx'. Fills in a ocxl_afu_config structure > */ > -extern int ocxl_config_read_afu(struct pci_dev *dev, > +int ocxl_config_read_afu(struct pci_dev *dev, > struct ocxl_fn_config *fn, > struct ocxl_afu_config *afu, > u8 afu_idx); > @@ -77,7 +77,7 @@ extern int ocxl_config_read_afu(struct pci_dev *dev, > /* > * Get the max PASID value that can be used by the function > */ > -extern int ocxl_config_get_pasid_info(struct pci_dev *dev, int *count); > +int ocxl_config_get_pasid_info(struct pci_dev *dev, int *count); > > /* > * Tell an AFU, by writing in the configuration space, the PASIDs that > @@ -87,7 +87,7 @@ extern int ocxl_config_get_pasid_info(struct pci_dev *dev, int *count); > * 'afu_control_offset' is the offset of the AFU control DVSEC which > * can be found in the function configuration > */ > -extern void ocxl_config_set_afu_pasid(struct pci_dev *dev, > +void ocxl_config_set_afu_pasid(struct pci_dev *dev, > int afu_control_offset, > int pasid_base, u32 pasid_count_log); > > @@ -98,7 +98,7 @@ extern void ocxl_config_set_afu_pasid(struct pci_dev *dev, > * 'supported' is the total number of actags desired by all the AFUs > * of the function. > */ > -extern int ocxl_config_get_actag_info(struct pci_dev *dev, > +int ocxl_config_get_actag_info(struct pci_dev *dev, > u16 *base, u16 *enabled, u16 *supported); > > /* > @@ -108,7 +108,7 @@ extern int ocxl_config_get_actag_info(struct pci_dev *dev, > * 'func_offset' is the offset of the Function DVSEC that can found in > * the function configuration > */ > -extern void ocxl_config_set_actag(struct pci_dev *dev, int func_offset, > +void ocxl_config_set_actag(struct pci_dev *dev, int func_offset, > u32 actag_base, u32 actag_count); > > /* > @@ -118,7 +118,7 @@ extern void ocxl_config_set_actag(struct pci_dev *dev, int func_offset, > * 'afu_control_offset' is the offset of the AFU control DVSEC for the > * desired AFU. It can be found in the AFU configuration > */ > -extern void ocxl_config_set_afu_actag(struct pci_dev *dev, > +void ocxl_config_set_afu_actag(struct pci_dev *dev, > int afu_control_offset, > int actag_base, int actag_count); > > @@ -128,7 +128,7 @@ extern void ocxl_config_set_afu_actag(struct pci_dev *dev, > * 'afu_control_offset' is the offset of the AFU control DVSEC for the > * desired AFU. It can be found in the AFU configuration > */ > -extern void ocxl_config_set_afu_state(struct pci_dev *dev, > +void ocxl_config_set_afu_state(struct pci_dev *dev, > int afu_control_offset, int enable); > > /* > @@ -139,7 +139,7 @@ extern void ocxl_config_set_afu_state(struct pci_dev *dev, > * between the host and device, and set the Transaction Layer on both > * accordingly. > */ > -extern int ocxl_config_set_TL(struct pci_dev *dev, int tl_dvsec); > +int ocxl_config_set_TL(struct pci_dev *dev, int tl_dvsec); > > /* > * Request an AFU to terminate a PASID. > @@ -152,7 +152,7 @@ extern int ocxl_config_set_TL(struct pci_dev *dev, int tl_dvsec); > * 'afu_control_offset' is the offset of the AFU control DVSEC for the > * desired AFU. It can be found in the AFU configuration > */ > -extern int ocxl_config_terminate_pasid(struct pci_dev *dev, > +int ocxl_config_terminate_pasid(struct pci_dev *dev, > int afu_control_offset, int pasid); > > /* > @@ -165,13 +165,13 @@ extern int ocxl_config_terminate_pasid(struct pci_dev *dev, > * Returns a 'link handle' that should be used for further calls for > * the link > */ > -extern int ocxl_link_setup(struct pci_dev *dev, int PE_mask, > +int ocxl_link_setup(struct pci_dev *dev, int PE_mask, > void **link_handle); > > /* > * Remove the association between the function and its link. > */ > -extern void ocxl_link_release(struct pci_dev *dev, void *link_handle); > +void ocxl_link_release(struct pci_dev *dev, void *link_handle); > > /* > * Add a Process Element to the Shared Process Area for a link. > @@ -183,7 +183,7 @@ extern void ocxl_link_release(struct pci_dev *dev, void *link_handle); > * 'xsl_err_data' is an argument passed to the above callback, if > * defined > */ > -extern int ocxl_link_add_pe(void *link_handle, int pasid, u32 pidr, u32 tidr, > +int ocxl_link_add_pe(void *link_handle, int pasid, u32 pidr, u32 tidr, > u64 amr, struct mm_struct *mm, > void (*xsl_err_cb)(void *data, u64 addr, u64 dsisr), > void *xsl_err_data); > @@ -195,12 +195,12 @@ extern int ocxl_link_add_pe(void *link_handle, int pasid, u32 pidr, u32 tidr, > * pasid: the PASID for the AFU context > * tid: the new thread id for the process element > */ > -extern int ocxl_link_update_pe(void *link_handle, int pasid, __u16 tid); > +int ocxl_link_update_pe(void *link_handle, int pasid, __u16 tid); > > /* > * Remove a Process Element from the Shared Process Area for a link > */ > -extern int ocxl_link_remove_pe(void *link_handle, int pasid); > +int ocxl_link_remove_pe(void *link_handle, int pasid); > > /* > * Allocate an AFU interrupt associated to the link. > @@ -212,12 +212,12 @@ extern int ocxl_link_remove_pe(void *link_handle, int pasid); > * interrupt. It is an MMIO address which needs to be remapped (one > * page). > */ > -extern int ocxl_link_irq_alloc(void *link_handle, int *hw_irq, > +int ocxl_link_irq_alloc(void *link_handle, int *hw_irq, > u64 *obj_handle); > > /* > * Free a previously allocated AFU interrupt > */ > -extern void ocxl_link_free_irq(void *link_handle, int hw_irq); > +void ocxl_link_free_irq(void *link_handle, int hw_irq); > > #endif /* _MISC_OCXL_H_ */