From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4996DC43381 for ; Mon, 25 Mar 2019 17:07:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1299920896 for ; Mon, 25 Mar 2019 17:07:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729863AbfCYRH2 (ORCPT ); Mon, 25 Mar 2019 13:07:28 -0400 Received: from 4.mo4.mail-out.ovh.net ([178.32.98.131]:54532 "EHLO 4.mo4.mail-out.ovh.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725788AbfCYRH1 (ORCPT ); Mon, 25 Mar 2019 13:07:27 -0400 Received: from player758.ha.ovh.net (unknown [10.109.159.152]) by mo4.mail-out.ovh.net (Postfix) with ESMTP id A900F1D755B for ; Mon, 25 Mar 2019 17:57:26 +0100 (CET) Received: from kaod.org (lns-bzn-46-82-253-208-248.adsl.proxad.net [82.253.208.248]) (Authenticated sender: groug@kaod.org) by player758.ha.ovh.net (Postfix) with ESMTPSA id 57382412597D; Mon, 25 Mar 2019 16:57:19 +0000 (UTC) Date: Mon, 25 Mar 2019 17:57:18 +0100 From: Greg Kurz To: "Alastair D'Silva" Cc: alastair@d-silva.org, Arnd Bergmann , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, Andrew Donnellan , Frederic Barrat , linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH v4 4/4] ocxl: Remove some unused exported symbols Message-ID: <20190325175718.5e3e3253@bahia.lab.toulouse-stg.fr.ibm.com> In-Reply-To: <20190325053456.14599-5-alastair@au1.ibm.com> References: <20190320053448.2098-1-alastair@au1.ibm.com> <20190325053456.14599-1-alastair@au1.ibm.com> <20190325053456.14599-5-alastair@au1.ibm.com> X-Mailer: Claws Mail 3.16.0 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Ovh-Tracer-Id: 609674802812197195 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedutddrjeekgdeljecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfqggfjpdevjffgvefmvefgnecuuegrihhlohhuthemucehtddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 25 Mar 2019 16:34:55 +1100 "Alastair D'Silva" wrote: > From: Alastair D'Silva > > Remove some unused exported symbols. > > Signed-off-by: Alastair D'Silva > --- Reviewed-by: Greg Kurz > drivers/misc/ocxl/config.c | 4 +--- > drivers/misc/ocxl/ocxl_internal.h | 23 +++++++++++++++++++++++ > include/misc/ocxl.h | 23 ----------------------- > 3 files changed, 24 insertions(+), 26 deletions(-) > > diff --git a/drivers/misc/ocxl/config.c b/drivers/misc/ocxl/config.c > index 4dc11897237d..5e65acb8e134 100644 > --- a/drivers/misc/ocxl/config.c > +++ b/drivers/misc/ocxl/config.c > @@ -2,8 +2,8 @@ > // Copyright 2017 IBM Corp. > #include > #include > -#include > #include > +#include "ocxl_internal.h" > > #define EXTRACT_BIT(val, bit) (!!(val & BIT(bit))) > #define EXTRACT_BITS(val, s, e) ((val & GENMASK(e, s)) >> s) > @@ -299,7 +299,6 @@ int ocxl_config_check_afu_index(struct pci_dev *dev, > } > return 1; > } > -EXPORT_SYMBOL_GPL(ocxl_config_check_afu_index); > > static int read_afu_name(struct pci_dev *dev, struct ocxl_fn_config *fn, > struct ocxl_afu_config *afu) > @@ -535,7 +534,6 @@ int ocxl_config_get_pasid_info(struct pci_dev *dev, int *count) > { > return pnv_ocxl_get_pasid_count(dev, count); > } > -EXPORT_SYMBOL_GPL(ocxl_config_get_pasid_info); > > void ocxl_config_set_afu_pasid(struct pci_dev *dev, int pos, int pasid_base, > u32 pasid_count_log) > diff --git a/drivers/misc/ocxl/ocxl_internal.h b/drivers/misc/ocxl/ocxl_internal.h > index 321b29e77f45..06fd98c989c8 100644 > --- a/drivers/misc/ocxl/ocxl_internal.h > +++ b/drivers/misc/ocxl/ocxl_internal.h > @@ -107,6 +107,29 @@ void ocxl_pasid_afu_free(struct ocxl_fn *fn, u32 start, u32 size); > int ocxl_actag_afu_alloc(struct ocxl_fn *fn, u32 size); > void ocxl_actag_afu_free(struct ocxl_fn *fn, u32 start, u32 size); > > +/* > + * Get the max PASID value that can be used by the function > + */ > +int ocxl_config_get_pasid_info(struct pci_dev *dev, int *count); > + > +/* > + * Check if an AFU index is valid for the given function. > + * > + * AFU indexes can be sparse, so a driver should check all indexes up > + * to the maximum found in the function description > + */ > +int ocxl_config_check_afu_index(struct pci_dev *dev, > + struct ocxl_fn_config *fn, int afu_idx); > + > +/** > + * Update values within a Process Element > + * > + * link_handle: the link handle associated with the process element > + * pasid: the PASID for the AFU context > + * tid: the new thread id for the process element > + */ > +int ocxl_link_update_pe(void *link_handle, int pasid, __u16 tid); > + > struct ocxl_context *ocxl_context_alloc(void); > int ocxl_context_init(struct ocxl_context *ctx, struct ocxl_afu *afu, > struct address_space *mapping); > diff --git a/include/misc/ocxl.h b/include/misc/ocxl.h > index 4544573cc93c..9530d3be1b30 100644 > --- a/include/misc/ocxl.h > +++ b/include/misc/ocxl.h > @@ -56,15 +56,6 @@ struct ocxl_fn_config { > int ocxl_config_read_function(struct pci_dev *dev, > struct ocxl_fn_config *fn); > > -/* > - * Check if an AFU index is valid for the given function. > - * > - * AFU indexes can be sparse, so a driver should check all indexes up > - * to the maximum found in the function description > - */ > -int ocxl_config_check_afu_index(struct pci_dev *dev, > - struct ocxl_fn_config *fn, int afu_idx); > - > /* > * Read the configuration space of a function for the AFU specified by > * the index 'afu_idx'. Fills in a ocxl_afu_config structure > @@ -74,11 +65,6 @@ int ocxl_config_read_afu(struct pci_dev *dev, > struct ocxl_afu_config *afu, > u8 afu_idx); > > -/* > - * Get the max PASID value that can be used by the function > - */ > -int ocxl_config_get_pasid_info(struct pci_dev *dev, int *count); > - > /* > * Tell an AFU, by writing in the configuration space, the PASIDs that > * it can use. Range starts at 'pasid_base' and its size is a multiple > @@ -188,15 +174,6 @@ int ocxl_link_add_pe(void *link_handle, int pasid, u32 pidr, u32 tidr, > void (*xsl_err_cb)(void *data, u64 addr, u64 dsisr), > void *xsl_err_data); > > -/** > - * Update values within a Process Element > - * > - * link_handle: the link handle associated with the process element > - * pasid: the PASID for the AFU context > - * tid: the new thread id for the process element > - */ > -int ocxl_link_update_pe(void *link_handle, int pasid, __u16 tid); > - > /* > * Remove a Process Element from the Shared Process Area for a link > */