> > - if (pdata) { > > - da9063->flags = pdata->flags; > > - da9063->irq_base = pdata->irq_base; > > - } else { > > - da9063->flags = 0; > > - da9063->irq_base = -1; > > - } > > + da9063->flags = 0; > > + da9063->irq_base = -1; > > If the flag and irq_base fields have fixed values can > they be removed? As a follow-up? There is likely more simplification possible. But yes, it should be a follow up patch, I think.