From: Aaro Koskinen <aaro.koskinen@iki.fi>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
devel@driverdev.osuosl.org, Vinod Koul <vkoul@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: octeon-ethernet: fix incorrect PHY mode
Date: Tue, 26 Mar 2019 11:36:52 +0200 [thread overview]
Message-ID: <20190326093652.GB16484@darkstar.musicnaut.iki.fi> (raw)
In-Reply-To: <20190326090150.GE31524@lunn.ch>
Hi,
On Tue, Mar 26, 2019 at 10:01:50AM +0100, Andrew Lunn wrote:
> Humm, that is unique, as far as i know. Every other MAC driver uses
> of_get_phy_mode() to get the value out of device tree. The proprietary
> delay values can then be used to fine tune the basic delay setting
> read from DT.
Problem is that OCTEON DTBs do not have phy-mode at the moment.
With the patch, I got the mode right also for board with SGMII
and non-upgradable firmware passed DTB.
A.
prev parent reply other threads:[~2019-03-26 9:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-25 20:48 [PATCH] staging: octeon-ethernet: fix incorrect PHY mode Aaro Koskinen
2019-03-26 9:01 ` Andrew Lunn
2019-03-26 9:36 ` Aaro Koskinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190326093652.GB16484@darkstar.musicnaut.iki.fi \
--to=aaro.koskinen@iki.fi \
--cc=andrew@lunn.ch \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).