From: Steven Rostedt <rostedt@goodmis.org>
To: "Paul E. McKenney" <paulmck@linux.ibm.com>
Cc: Yafang Shao <laoar.shao@gmail.com>,
mingo@redhat.com, peterz@infradead.org, josh@joshtriplett.org,
mathieu.desnoyers@efficios.com, jiangshanlai@gmail.com,
joel@joelfernandes.org, linux-kernel@vger.kernel.org,
shaoyafang@didiglobal.com
Subject: Re: [PATCH v2 3/3] rcu: validate arguments for rcu tracepoints
Date: Tue, 26 Mar 2019 11:29:58 -0400 [thread overview]
Message-ID: <20190326112958.2668a4a1@gandalf.local.home> (raw)
In-Reply-To: <20190326151815.GI4102@linux.ibm.com>
On Tue, 26 Mar 2019 08:18:15 -0700
"Paul E. McKenney" <paulmck@linux.ibm.com> wrote:
> On Tue, Mar 26, 2019 at 08:13:11PM +0800, Yafang Shao wrote:
> > When CONFIG_RCU_TRACE is not set, all these tracepoints are defined as
> > do-nothing macro.
> > We'd better make those inline functions that take proper arguments.
> >
> > As RCU_TRACE() is defined as do-nothing marco as well when
> > CONFIG_RCU_TRACE is not set, so we can clean it up.
>
> How about this for the commit log?
>
> Unless the CONFIG_RCU_TRACE kconfig option is set, almost all
> of RCU's tracepoints are defined as empty macros. It would
> be better if these tracepoints could instead be empty inline
> functions with proper arguments and type checking. It would
> also be good to get rid of the RCU_TRACE() macro, which
> compiles its argument in CONFIG_RCU_TRACE=y kernels and
> omits them otherwise.
>
> This commit therefore creates a TRACE_EVENT_RCU macro that
> is defined as TRACE_EVENT in CONFIG_RCU_TRACE=y kernels and
> as the new TRACE_EVENT_NOP otherwise, which allows the
> empty macros and the RCU_TRACE() macro to be eliminated.
>
> With that:
>
> Reviewed-by: Paul E. McKenney <paulmck@linux.ibm.com>
Yafang,
If you are OK with the above changes, I'll take this patch with the
updated change log.
-- Steve
next prev parent reply other threads:[~2019-03-26 15:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-26 12:13 [PATCH v2 0/3] tracing: introduce TRACE_EVENT_NOP and use it Yafang Shao
2019-03-26 12:13 ` [PATCH v2 1/3] tracing: introduce TRACE_EVENT_NOP() Yafang Shao
2019-03-26 12:13 ` [PATCH v2 2/3] sched/fair: do not expose some tracepoints to user if CONFIG_SCHEDSTATS is not set Yafang Shao
2019-03-26 12:21 ` Steven Rostedt
2019-04-01 10:31 ` Peter Zijlstra
2019-03-26 12:13 ` [PATCH v2 3/3] rcu: validate arguments for rcu tracepoints Yafang Shao
2019-03-26 12:22 ` Steven Rostedt
2019-03-26 15:18 ` Paul E. McKenney
2019-03-26 15:29 ` Steven Rostedt [this message]
2019-03-27 1:17 ` Yafang Shao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190326112958.2668a4a1@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=jiangshanlai@gmail.com \
--cc=joel@joelfernandes.org \
--cc=josh@joshtriplett.org \
--cc=laoar.shao@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mingo@redhat.com \
--cc=paulmck@linux.ibm.com \
--cc=peterz@infradead.org \
--cc=shaoyafang@didiglobal.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).