LKML Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH 0/8] Cleanup traceevent API and make it more consistent
@ 2019-03-26 15:43 Tzvetomir Stoyanov
  2019-03-26 15:43 ` [PATCH 1/8] tools/perf,tools/lib/traceevent: Make traceevent APIs " Tzvetomir Stoyanov
                   ` (7 more replies)
  0 siblings, 8 replies; 55+ messages in thread
From: Tzvetomir Stoyanov @ 2019-03-26 15:43 UTC (permalink / raw)
  To: rostedt; +Cc: linux-trace-devel, linux-kernel

This patch series does a cleanup of traceevent implementation and APIs:
 - All "pevent" function parameters and local variables are renamed to "tep". 
   This makes the implementation consistent with the chosen naming convention, 
   tep (trace event parser), and avoids any confusion with the old "pevent" name 
 - Removed deprecated tep filter trivial APIs.
 - Removed call to exit() from one of traceevent APIs, a library function should 
   not force the application to exit.
 - Added counter to track parsing failures.

Changes depend on "Few patches, related to libtracevent APIs" patchset and 
should be applied on top of it.

Tzvetomir Stoyanov (8):
  tools/perf,tools/lib/traceevent: Make traceevent APIs more consistent
  tools/lib/traceevent: Add counter to track parsing failures
  tools/lib/traceevent: Remove tep filter trivial APIs
  tools/lib/traceevent: rename input arguments of libtraceevent APIs
    from pevent to tep
  tools/perf,tools/lib/traceevent: rename "pevent" member of struct
    tep_event to "tep"
  tools/perf,tools/lib/traceevent: rename "pevent" member of struct
    tep_event_filter to "tep"
  tools/lib/traceevent: rename input arguments and local variables of
    libtraceevent from pevent to tep
  tools/lib/traceevent: remove call to exit() from
    tep_filter_add_filter_str()

 tools/lib/traceevent/event-parse-api.c        | 181 ++--
 tools/lib/traceevent/event-parse-local.h      |   8 +-
 tools/lib/traceevent/event-parse.c            | 817 +++++++++---------
 tools/lib/traceevent/event-parse.h            | 148 ++--
 tools/lib/traceevent/event-plugin.c           |  32 +-
 tools/lib/traceevent/parse-filter.c           | 216 +----
 tools/lib/traceevent/plugin_cfg80211.c        |   8 +-
 tools/lib/traceevent/plugin_function.c        |  14 +-
 tools/lib/traceevent/plugin_hrtimer.c         |  12 +-
 tools/lib/traceevent/plugin_jbd2.c            |  12 +-
 tools/lib/traceevent/plugin_kmem.c            |  32 +-
 tools/lib/traceevent/plugin_kvm.c             |  48 +-
 tools/lib/traceevent/plugin_mac80211.c        |   8 +-
 tools/lib/traceevent/plugin_sched_switch.c    |  18 +-
 tools/lib/traceevent/plugin_scsi.c            |   8 +-
 tools/lib/traceevent/plugin_xen.c             |   8 +-
 tools/perf/builtin-kmem.c                     |   2 +-
 tools/perf/util/data-convert-bt.c             |   4 +-
 tools/perf/util/python.c                      |   2 +-
 .../util/scripting-engines/trace-event-perl.c |   2 +-
 .../scripting-engines/trace-event-python.c    |   2 +-
 tools/perf/util/trace-event-parse.c           |   2 +-
 tools/perf/util/trace-event-read.c            |   2 +-
 tools/perf/util/trace-event.c                 |   4 +-
 24 files changed, 719 insertions(+), 871 deletions(-)

-- 
2.20.1


^ permalink raw reply	[flat|nested] 55+ messages in thread
* [PATCH v2 0/5] Cleanup traceevent API and make it more consistent
@ 2019-03-27 14:19 Tzvetomir Stoyanov
  2019-03-27 14:19 ` [PATCH v2 1/5] tools/perf,tools/lib/traceevent: Make traceevent APIs " Tzvetomir Stoyanov
                   ` (4 more replies)
  0 siblings, 5 replies; 55+ messages in thread
From: Tzvetomir Stoyanov @ 2019-03-27 14:19 UTC (permalink / raw)
  To: rostedt; +Cc: linux-trace-devel, linux-kernel

[
 v2 changes:
  - Excluded patches:
     "tools/lib/traceevent: Remove tep filter trivial APIs"
     "tools/lib/traceevent: remove call to exit() from tep_filter_add_filter_str()"
    from the series, as they are already merged.
  - Dropped patch "tools/lib/traceevent: Add counter to track parsing failures",
    this functionality will not be part of the traceevent library. Applications
    should track parsing failures themselves.
  - Few minor changes, to address Steven Rostedt comments 
]

This patch series does a cleanup of traceevent implementation and APIs:
 - All "pevent" function parameters and local variables are renamed to "tep". 
   This makes the implementation consistent with the chosen naming convention, 
   tep (trace event parser), and avoids any confusion with the old "pevent" name. 
 - Renamed a bunch of tracevent APIs, to make names consistent and descriptive.
 - Unified all tep_is_... APIs to return bool value, instead of int.

Changes depend on "Few patches, related to libtracevent APIs" patchset and 
should be applied on top of it.

Tzvetomir Stoyanov (5):
  tools/perf,tools/lib/traceevent: Make traceevent APIs more consistent
  tools/lib/traceevent: Rename input arguments of libtraceevent APIs
    from pevent to tep
  tools/perf,tools/lib/traceevent: Rename "pevent" member of struct
    tep_event to "tep"
  tools/perf,tools/lib/traceevent: Rename "pevent" member of struct
    tep_event_filter to "tep"
  tools/lib/traceevent: Rename input arguments and local variables of
    libtraceevent from pevent to tep

 tools/lib/traceevent/event-parse-api.c        | 152 ++--
 tools/lib/traceevent/event-parse-local.h      |   6 +-
 tools/lib/traceevent/event-parse.c            | 811 +++++++++---------
 tools/lib/traceevent/event-parse.h            | 130 +--
 tools/lib/traceevent/event-plugin.c           |  32 +-
 tools/lib/traceevent/parse-filter.c           |  46 +-
 tools/lib/traceevent/plugin_cfg80211.c        |   8 +-
 tools/lib/traceevent/plugin_function.c        |  14 +-
 tools/lib/traceevent/plugin_hrtimer.c         |  12 +-
 tools/lib/traceevent/plugin_jbd2.c            |  12 +-
 tools/lib/traceevent/plugin_kmem.c            |  32 +-
 tools/lib/traceevent/plugin_kvm.c             |  48 +-
 tools/lib/traceevent/plugin_mac80211.c        |   8 +-
 tools/lib/traceevent/plugin_sched_switch.c    |  18 +-
 tools/lib/traceevent/plugin_scsi.c            |   8 +-
 tools/lib/traceevent/plugin_xen.c             |   8 +-
 tools/perf/builtin-kmem.c                     |   2 +-
 tools/perf/util/data-convert-bt.c             |   4 +-
 tools/perf/util/python.c                      |   2 +-
 .../util/scripting-engines/trace-event-perl.c |   2 +-
 .../scripting-engines/trace-event-python.c    |   2 +-
 tools/perf/util/trace-event-parse.c           |   2 +-
 tools/perf/util/trace-event-read.c            |   2 +-
 tools/perf/util/trace-event.c                 |   4 +-
 24 files changed, 682 insertions(+), 683 deletions(-)

-- 
2.20.1


^ permalink raw reply	[flat|nested] 55+ messages in thread
* [PATCH 00/15] tools/lib/traceevent: Continuing on the path to a stand alone library
@ 2019-04-01 16:43 Steven Rostedt
  2019-04-01 16:43 ` [PATCH 01/15] tools lib traceevent: Handle trace_printk() "%px" Steven Rostedt
                   ` (15 more replies)
  0 siblings, 16 replies; 55+ messages in thread
From: Steven Rostedt @ 2019-04-01 16:43 UTC (permalink / raw)
  To: linux-kernel
  Cc: Arnaldo Carvalho de Melo, Ingo Molnar, Jiri Olsa, Namhyung Kim,
	Andrew Morton, Tzvetomir Stoyanov


Arnaldo,

These contain more patches to make libtraceevent a stand alone library.
It also brings in some changes that are in the trace-cmd library.

There's a few name changes to the API function names to be more
descriptive as well as closer to what they actually do.

The "pevent" has been renamed to "tep" as we no longer use "pevent"
to represent the handle to the libtraceevent library descriptor.
"tep" now stands for "Trace Event Parser".

The reason for the "(Red Hat)" in one of my patches is that the code
was written when I was working for Red Hat, but added when working
for VMware (which is in the Signed-off-by).

Steven Rostedt (Red Hat) (1):
      tools/lib/traceevent: Add more debugging to see various internal ring buffer entries

Steven Rostedt (VMware) (3):
      tools lib traceevent: Handle trace_printk() "%px"
      tools/lib/traceevent: Add mono clocks to be parsed in seconds
      tools/lib/traceevent: Removed unneeded !! and return parenthesis

Tzvetomir Stoyanov (11):
      tools lib traceevent: Implement a new API, tep_list_events_copy()
      tools/lib/traceevent: Change description of few APIs
      tools/lib/traceevent: Coding style fixes
      tools/lib/traceevent: Implement new traceevent APIs for accessing struct tep_handler fields
      tools/lib/traceevent: Remove tep filter trivial APIs
      tools/lib/traceevent: Remove call to exit() from tep_filter_add_filter_str()
      tools/perf,tools/lib/traceevent: Make traceevent APIs more consistent
      tools/lib/traceevent: Rename input arguments of libtraceevent APIs from pevent to tep
      tools/perf,tools/lib/traceevent: Rename "pevent" member of struct tep_event to "tep"
      tools/perf,tools/lib/traceevent: Rename "pevent" member of struct tep_event_filter to "tep"
      tools/lib/traceevent: Rename input arguments and local variables of libtraceevent from pevent to tep

----
 tools/lib/traceevent/event-parse-api.c             | 278 +++++--
 tools/lib/traceevent/event-parse-local.h           |   6 +-
 tools/lib/traceevent/event-parse.c                 | 909 +++++++++++----------
 tools/lib/traceevent/event-parse.h                 | 154 ++--
 tools/lib/traceevent/event-plugin.c                |  32 +-
 tools/lib/traceevent/kbuffer-parse.c               |  49 ++
 tools/lib/traceevent/kbuffer.h                     |  13 +
 tools/lib/traceevent/parse-filter.c                | 216 +----
 tools/lib/traceevent/plugin_cfg80211.c             |   8 +-
 tools/lib/traceevent/plugin_function.c             |  14 +-
 tools/lib/traceevent/plugin_hrtimer.c              |  12 +-
 tools/lib/traceevent/plugin_jbd2.c                 |  12 +-
 tools/lib/traceevent/plugin_kmem.c                 |  32 +-
 tools/lib/traceevent/plugin_kvm.c                  |  48 +-
 tools/lib/traceevent/plugin_mac80211.c             |   8 +-
 tools/lib/traceevent/plugin_sched_switch.c         |  18 +-
 tools/lib/traceevent/plugin_scsi.c                 |   8 +-
 tools/lib/traceevent/plugin_xen.c                  |   8 +-
 tools/perf/builtin-kmem.c                          |   2 +-
 tools/perf/util/data-convert-bt.c                  |   4 +-
 tools/perf/util/python.c                           |   2 +-
 .../perf/util/scripting-engines/trace-event-perl.c |   2 +-
 .../util/scripting-engines/trace-event-python.c    |   2 +-
 tools/perf/util/trace-event-parse.c                |   2 +-
 tools/perf/util/trace-event-read.c                 |   2 +-
 tools/perf/util/trace-event.c                      |   4 +-
 26 files changed, 946 insertions(+), 899 deletions(-)

^ permalink raw reply	[flat|nested] 55+ messages in thread