From: "Jonathan Neuschäfer" <j.neuschaefer@gmx.net>
To: Shawn Guo <shawnguo@kernel.org>
Cc: "Jonathan Neuschäfer" <j.neuschaefer@gmx.net>,
linux-arm-kernel@lists.infradead.org,
"Rob Herring" <robh+dt@kernel.org>,
"Mark Rutland" <mark.rutland@arm.com>,
"Sascha Hauer" <s.hauer@pengutronix.de>,
"Pengutronix Kernel Team" <kernel@pengutronix.de>,
"Fabio Estevam" <festevam@gmail.com>,
"NXP Linux Team" <linux-imx@nxp.com>,
"Thierry Reding" <treding@nvidia.com>,
"Manivannan Sadhasivam" <manivannan.sadhasivam@linaro.org>,
"Kevin Hilman" <khilman@baylibre.com>,
"Heiko Stuebner" <heiko@sntech.de>,
"Jagan Teki" <jagan@amarulasolutions.com>,
"Martin Blumenstingl" <martin.blumenstingl@googlemail.com>,
"Johan Hovold" <johan@kernel.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/5] ARM: dts: imx50: Add Kobo Aura DTS
Date: Tue, 26 Mar 2019 17:26:53 +0100 [thread overview]
Message-ID: <20190326162653.GD2095@latitude> (raw)
In-Reply-To: <20190322013151.GR12513@dragon>
[-- Attachment #1: Type: text/plain, Size: 1004 bytes --]
Hi, thanks for your comments. I'll address them in v2.
On Fri, Mar 22, 2019 at 09:31:53AM +0800, Shawn Guo wrote:
> On Tue, Mar 19, 2019 at 04:24:17PM +0100, Jonathan Neuschäfer wrote:
> > The Kobo Aura is an e-book reader released in 2013.
[...]
> > + sd2_pwrseq: pwrseq {
> > + compatible = "mmc-pwrseq-simple";
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&pinctrl_sd2_reset>;
> > +
>
> Please do not have random newlines.
Does that apply to all empty lines between properties?
>
> > + reset-gpios = <&gpio4 17 GPIO_ACTIVE_LOW>;
> > + };
> > +
[...]
> > +&iomuxc {
> > + pinctrl_uart2: uart2 {
> > + fsl,pins = <
> > + MX50_PAD_UART2_TXD__UART2_TXD_MUX 0x1e4
> > + MX50_PAD_UART2_RXD__UART2_RXD_MUX 0x1e4
> > + >;
> > + };
> > +
> > + pinctrl_i2c1: i2c1 {
>
> Please sort these pinctrl nodes alphabetically.
It doesn't make a difference here, but should I generally sort by name
or by label in cases like this one?
Jonathan Neuschäfer
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2019-03-26 16:27 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-19 15:24 [PATCH 0/5] ARM: Initial devicetree for Kobo Aura Jonathan Neuschäfer
2019-03-19 15:24 ` [PATCH 1/5] dt-bindings: Add vendor prefix for Rakuten Kobo, Inc Jonathan Neuschäfer
2019-03-19 15:24 ` [PATCH 2/5] ARM: dts: imx50: Add Kobo Aura DTS Jonathan Neuschäfer
2019-03-22 1:31 ` Shawn Guo
2019-03-26 16:26 ` Jonathan Neuschäfer [this message]
2019-03-29 2:44 ` Shawn Guo
2019-03-19 15:24 ` [PATCH 3/5] ARM: dts: imx50: Add PHY node for usbotg and adjust clocks Jonathan Neuschäfer
2019-03-22 1:41 ` Shawn Guo
2019-03-19 15:24 ` [PATCH 4/5] ARM: dts: imx50-kobo-aura: Enable USB support Jonathan Neuschäfer
2019-03-19 15:24 ` [PATCH 5/5] ARM: dts: imx50: Fix the numbering of the I2C controllers Jonathan Neuschäfer
2019-03-22 1:46 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190326162653.GD2095@latitude \
--to=j.neuschaefer@gmx.net \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=heiko@sntech.de \
--cc=jagan@amarulasolutions.com \
--cc=johan@kernel.org \
--cc=kernel@pengutronix.de \
--cc=khilman@baylibre.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=mark.rutland@arm.com \
--cc=martin.blumenstingl@googlemail.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=treding@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).