linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v3] x86/realmode: don't leak kernel addresses
@ 2019-03-26 20:30 Matteo Croce
  2019-03-27 13:28 ` [tip:x86/urgent] x86/realmode: Don't leak the trampoline kernel address tip-bot for Matteo Croce
  0 siblings, 1 reply; 2+ messages in thread
From: Matteo Croce @ 2019-03-26 20:30 UTC (permalink / raw)
  To: x86; +Cc: H . Peter Anvin, Thomas Gleixner, Ingo Molnar, Borislav Petkov, LKML

Since commit ad67b74d2469d9b8 ("printk: hash addresses printed with %p"),
at boot "____ptrval____" is printed instead of the trampoline addresses:

    Base memory trampoline at [(____ptrval____)] 99000 size 24576

Remove the print as we don't want to leak kernel addresses.

Fixes: ad67b74d2469d9b8 ("printk: hash addresses printed with %p")
Signed-off-by: Matteo Croce <mcroce@redhat.com>
---
 arch/x86/realmode/init.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/arch/x86/realmode/init.c b/arch/x86/realmode/init.c
index d10105825d57..47d097946872 100644
--- a/arch/x86/realmode/init.c
+++ b/arch/x86/realmode/init.c
@@ -20,8 +20,6 @@ void __init set_real_mode_mem(phys_addr_t mem, size_t size)
 	void *base = __va(mem);
 
 	real_mode_header = (struct real_mode_header *) base;
-	printk(KERN_DEBUG "Base memory trampoline at [%p] %llx size %zu\n",
-	       base, (unsigned long long)mem, size);
 }
 
 void __init reserve_real_mode(void)
-- 
2.20.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [tip:x86/urgent] x86/realmode: Don't leak the trampoline kernel address
  2019-03-26 20:30 [PATCH v3] x86/realmode: don't leak kernel addresses Matteo Croce
@ 2019-03-27 13:28 ` tip-bot for Matteo Croce
  0 siblings, 0 replies; 2+ messages in thread
From: tip-bot for Matteo Croce @ 2019-03-27 13:28 UTC (permalink / raw)
  To: linux-tip-commits; +Cc: hpa, bp, x86, linux-kernel, tglx, mingo, mingo, mcroce

Commit-ID:  b929a500d68479163c48739d809cbf4c1335db6f
Gitweb:     https://git.kernel.org/tip/b929a500d68479163c48739d809cbf4c1335db6f
Author:     Matteo Croce <mcroce@redhat.com>
AuthorDate: Tue, 26 Mar 2019 21:30:46 +0100
Committer:  Borislav Petkov <bp@suse.de>
CommitDate: Wed, 27 Mar 2019 14:22:08 +0100

x86/realmode: Don't leak the trampoline kernel address

Since commit

  ad67b74d2469 ("printk: hash addresses printed with %p")

at boot "____ptrval____" is printed instead of the trampoline addresses:

  Base memory trampoline at [(____ptrval____)] 99000 size 24576

Remove the print as we don't want to leak kernel addresses and this
statement is not needed anymore.

Fixes: ad67b74d2469d9b8 ("printk: hash addresses printed with %p")
Signed-off-by: Matteo Croce <mcroce@redhat.com>
Signed-off-by: Borislav Petkov <bp@suse.de>
Cc: "H. Peter Anvin" <hpa@zytor.com>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: x86-ml <x86@kernel.org>
Link: https://lkml.kernel.org/r/20190326203046.20787-1-mcroce@redhat.com
---
 arch/x86/realmode/init.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/arch/x86/realmode/init.c b/arch/x86/realmode/init.c
index d10105825d57..47d097946872 100644
--- a/arch/x86/realmode/init.c
+++ b/arch/x86/realmode/init.c
@@ -20,8 +20,6 @@ void __init set_real_mode_mem(phys_addr_t mem, size_t size)
 	void *base = __va(mem);
 
 	real_mode_header = (struct real_mode_header *) base;
-	printk(KERN_DEBUG "Base memory trampoline at [%p] %llx size %zu\n",
-	       base, (unsigned long long)mem, size);
 }
 
 void __init reserve_real_mode(void)

^ permalink raw reply related	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-03-27 13:28 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-26 20:30 [PATCH v3] x86/realmode: don't leak kernel addresses Matteo Croce
2019-03-27 13:28 ` [tip:x86/urgent] x86/realmode: Don't leak the trampoline kernel address tip-bot for Matteo Croce

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).