linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: luferry <luferry@163.com>
Cc: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>,
	Dongli Zhang <dongli.zhang@oracle.com>,
	Ming Lei <ming.lei@redhat.com>,
	linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] make blk_mq_map_queues more friendly for cpu topology
Date: Wed, 27 Mar 2019 09:16:19 +0100	[thread overview]
Message-ID: <20190327081619.GG20525@lst.de> (raw)
In-Reply-To: <48ca2186.fc76.169b8fef63a.Coremail.luferry@163.com>

On Tue, Mar 26, 2019 at 03:55:10PM +0800, luferry wrote:
> 
> 
> 
> At 2019-03-26 15:39:54, "Christoph Hellwig" <hch@lst.de> wrote:
> >Why isn't this using the automatic PCI-level affinity assignment to
> >start with?
> 
> When enable virtio-blk with multi queues but with only 2 msix-vector.
> vp_dev->per_vq_vectors will be false, vp_get_vq_affintity will return NULL directly
> so blk_mq_virtio_map_queues will fallback to blk_mq_map_queues.

What is the point of the multiqueue mode if you don't have enough
(virtual) MSI-X vectors?

  reply	other threads:[~2019-03-27  8:16 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-25 15:26 [PATCH] make blk_mq_map_queues more friendly for cpu topology luferry
2019-03-26  7:39 ` Christoph Hellwig
2019-03-26  7:55   ` luferry
2019-03-27  8:16     ` Christoph Hellwig [this message]
2019-03-27  9:17       ` luferry
2019-03-27  9:39         ` Dongli Zhang
2019-03-27  9:53           ` luferry

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190327081619.GG20525@lst.de \
    --to=hch@lst.de \
    --cc=axboe@kernel.dk \
    --cc=dongli.zhang@oracle.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luferry@163.com \
    --cc=ming.lei@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).