From: Michal Hocko <mhocko@kernel.org>
To: Qian Cai <cai@lca.pw>
Cc: akpm@linux-foundation.org, catalin.marinas@arm.com, cl@linux.com,
willy@infradead.org, penberg@kernel.org, rientjes@google.com,
iamjoonsoo.kim@lge.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4] kmemleak: survive in a low-memory situation
Date: Wed, 27 Mar 2019 09:44:32 +0100 [thread overview]
Message-ID: <20190327084432.GA11927@dhcp22.suse.cz> (raw)
In-Reply-To: <20190327005948.24263-1-cai@lca.pw>
On Tue 26-03-19 20:59:48, Qian Cai wrote:
[...]
> Unless there is a brave soul to reimplement the kmemleak to embed it's
> metadata into the tracked memory itself in a foreseeable future, this
> provides a good balance between enabling kmemleak in a low-memory
> situation and not introducing too much hackiness into the existing
> code for now. Another approach is to fail back the original allocation
> once kmemleak_alloc() failed, but there are too many call sites to
> deal with which makes it error-prone.
As long as there is an implicit __GFP_NOFAIL then kmemleak is simply
broken no matter what other gfp flags you play with. Has anybody looked
at some sort of preallocation where gfpflags_allow_blocking context
allocate objects into a pool that non-sleeping allocations can eat from?
> kmemleak: Cannot allocate a kmemleak_object structure
> kmemleak: Kernel memory leak detector disabled
> kmemleak: Automatic memory scanning thread ended
> RIP: 0010:__alloc_pages_nodemask+0x242a/0x2ab0
> Call Trace:
> allocate_slab+0x4d9/0x930
> new_slab+0x46/0x70
> ___slab_alloc+0x5d3/0x9c0
> __slab_alloc+0x12/0x20
> kmem_cache_alloc+0x30a/0x360
> create_object+0x96/0x9a0
> kmemleak_alloc+0x71/0xa0
> kmem_cache_alloc+0x254/0x360
> mempool_alloc_slab+0x3f/0x60
> mempool_alloc+0x120/0x329
> bio_alloc_bioset+0x1a8/0x510
> get_swap_bio+0x107/0x470
> __swap_writepage+0xab4/0x1650
> swap_writepage+0x86/0xe0
>
> Signed-off-by: Qian Cai <cai@lca.pw>
> ---
>
> v4: Update the commit log.
> Fix a typo in comments per Christ.
> Consolidate the allocation.
> v3: Update the commit log.
> Simplify the code inspired by graph_trace_open() from ftrace.
> v2: Remove the needless checking for NULL objects in slab_post_alloc_hook()
> per Catalin.
>
> mm/kmemleak.c | 11 ++++++++++-
> 1 file changed, 10 insertions(+), 1 deletion(-)
>
> diff --git a/mm/kmemleak.c b/mm/kmemleak.c
> index a2d894d3de07..7f4545ab1f84 100644
> --- a/mm/kmemleak.c
> +++ b/mm/kmemleak.c
> @@ -580,7 +580,16 @@ static struct kmemleak_object *create_object(unsigned long ptr, size_t size,
> struct rb_node **link, *rb_parent;
> unsigned long untagged_ptr;
>
> - object = kmem_cache_alloc(object_cache, gfp_kmemleak_mask(gfp));
> + /*
> + * The tracked memory was allocated successful, if the kmemleak object
> + * failed to allocate for some reasons, it ends up with the whole
> + * kmemleak disabled, so try it harder.
> + */
> + gfp = (in_atomic() || irqs_disabled()) ?
> + gfp_kmemleak_mask(gfp) | GFP_ATOMIC :
> + gfp_kmemleak_mask(gfp) | __GFP_DIRECT_RECLAIM;
The comment for in_atomic says:
* Are we running in atomic context? WARNING: this macro cannot
* always detect atomic context; in particular, it cannot know about
* held spinlocks in non-preemptible kernels. Thus it should not be
* used in the general case to determine whether sleeping is possible.
* Do not use in_atomic() in driver code.
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2019-03-27 8:44 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-27 0:59 [PATCH v4] kmemleak: survive in a low-memory situation Qian Cai
2019-03-27 8:44 ` Michal Hocko [this message]
2019-03-27 11:34 ` Qian Cai
2019-03-27 11:44 ` Michal Hocko
2019-03-27 13:05 ` Qian Cai
2019-03-27 13:17 ` Michal Hocko
2019-03-27 17:29 ` Catalin Marinas
2019-03-27 18:02 ` Qian Cai
2019-03-28 15:05 ` Catalin Marinas
2019-03-28 15:41 ` Qian Cai
2019-03-27 18:17 ` Michal Hocko
2019-03-27 18:21 ` Matthew Wilcox
2019-03-28 14:59 ` Catalin Marinas
2019-03-28 15:24 ` Qian Cai
2019-03-29 12:02 ` Michal Hocko
2019-03-29 16:16 ` Catalin Marinas
2019-04-01 20:12 ` Michal Hocko
2019-04-05 16:43 ` Catalin Marinas
2019-03-28 6:05 ` Pekka Enberg
2019-03-28 10:30 ` Catalin Marinas
2019-03-28 11:50 ` Pekka Enberg
2019-03-28 15:28 ` Catalin Marinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190327084432.GA11927@dhcp22.suse.cz \
--to=mhocko@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=cai@lca.pw \
--cc=catalin.marinas@arm.com \
--cc=cl@linux.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).