From: Rob Herring <robh@kernel.org>
To: Fabien Dessenne <fabien.dessenne@st.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Alexandre Torgue <alexandre.torgue@st.com>,
Ohad Ben-Cohen <ohad@wizery.com>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
devicetree@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-remoteproc@vger.kernel.org,
Loic Pallardy <loic.pallardy@st.com>,
Arnaud Pouliquen <arnaud.pouliquen@st.com>,
Ludovic Barre <ludovic.barre@st.com>,
Benjamin Gaignard <benjamin.gaignard@st.com>
Subject: Re: [PATCH 2/8] dt-bindings: remoteproc: add bindings for stm32 remote processor driver
Date: Wed, 27 Mar 2019 18:23:01 -0500 [thread overview]
Message-ID: <20190327232301.GA2172@bogus> (raw)
In-Reply-To: <1551795849-13672-3-git-send-email-fabien.dessenne@st.com>
On Tue, Mar 05, 2019 at 03:24:03PM +0100, Fabien Dessenne wrote:
> Add the device tree bindings document for the stm32 remoteproc devices.
>
> Signed-off-by: Fabien Dessenne <fabien.dessenne@st.com>
> ---
> .../devicetree/bindings/remoteproc/stm32-rproc.txt | 67 ++++++++++++++++++++++
> 1 file changed, 67 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/remoteproc/stm32-rproc.txt
>
> diff --git a/Documentation/devicetree/bindings/remoteproc/stm32-rproc.txt b/Documentation/devicetree/bindings/remoteproc/stm32-rproc.txt
> new file mode 100644
> index 0000000..cc90c88
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/remoteproc/stm32-rproc.txt
> @@ -0,0 +1,67 @@
> +STMicroelectronics STM32 Remoteproc
> +-----------------------------------
> +This document defines the binding for the remoteproc component that loads and
> +boots firmwares on the ST32MP family chipset.
> +
> +Required properties:
> +- compatible: Must be "st,stm32mp1-rproc"
'rproc' is what this is called in the h/w manual?
> +- reg: Address ranges of the remote processor dedicated memories.
> + The parent node should provide an appropriate ranges property
> + for properly translating these into bus addresses.
> +- resets: Reference to a reset controller asserting the remote processor.
> +- reset-names: Must be "mcu_rst"
-names is kind of pointless when there is only 1 entry.
> +- st,syscfg-holdboot: Reference to the system configuration which holds the
> + remote processor reset hold boot
> + 1st cell: phandle of syscon block
> + 2nd cell: register offset containing the hold boot setting
> + 3rd cell: register bitmask for the hold boot field
> +- st,syscfg-tz: Reference to the system configuration which holds the RCC trust
> + zone mode
> + 1st cell: phandle to syscon block
> + 2nd cell: register offset containing the RCC trust zone mode setting
> + 3rd cell: register bitmask for the RCC trust zone mode bit
> +
> +Optional properties:
> +- interrupt-parent: phandle to the interrupt controller node.
This is implied.
> +- interrupts: Should contain the watchdog interrupt
> +- interrupt-names: Must be "wdg"
-names is kind of pointless when there is only 1 entry.
> +- mboxes: List of phandle and mailbox channel specifiers:
How would one talk to the processor if this is optional?
> + - a channel (a) used to communicate through virtqueues with the
> + remote proc.
> + Bi-directional channel:
> + - from local to remote = send message
> + - from remote to local = send message ack
> + - a channel (b) working the opposite direction of channel (a)
> + - a channel (c) used by the local proc to notify the remote proc
> + that it is about to be shut down.
> + Mono-directional channel:
Unidirectional
> + - from local to remote, where ACK from the remote means
> + that it is ready for shutdown
> +- mbox-names: This property is required if the mboxes property is used.
> + - must be "vq0" for channel (a)
> + - must be "vq1" for channel (b)
> + - must be "shutdown" for channel (c)
> +- memory-region: list of phandles to the reserved memory regions associated with
> + the remoteproc device
> + (see ../reserved-memory/reserved-memory.txt)
How many?
> +- st,syscfg-pdds: Reference to the system configuration which holds the remote
> + processor deep sleep setting
> + 1st cell: phandle to syscon block
> + 2nd cell: register offset containing the deep sleep setting
> + 3rd cell: register bitmask for the deep sleep bit
> +- auto_boot: If defined, when remoteproc is probed, it looks for a default
> + firmware and if it finds some, it loads the firmware and starts
> + the remote processor.
How do you know what is and isn't default firmware? Seems like this
could be accomplished using the standard 'firmware-name' to specify what
firmware to load and boot.
> +- recovery: If defined, remoteproc enables the crash recovery process.
Doesn't seem like a static DT property. This is a feature to enable or
something you set on boot to recover?
> +
> +Example:
> + m4_rproc: m4@0 {
> + compatible = "st,stm32mp1-rproc";
> + reg = <0x00000000 0x10000>,
> + <0x10000000 0x40000>,
> + <0x30000000 0x40000>;
> + resets = <&rcc MCU_R>;
> + reset-names = "mcu_rst";
> + st,syscfg-holdboot = <&rcc 0x10C 0x1>;
> + st,syscfg-tz = <&rcc 0x000 0x1>;
> + };
> --
> 2.7.4
>
next prev parent reply other threads:[~2019-03-27 23:23 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-05 14:24 [PATCH 0/8] stm32 m4 remoteproc on STM32MP157c Fabien Dessenne
2019-03-05 14:24 ` [PATCH 1/8] dt-bindings: stm32: add bindings for ML-AHB interconnect Fabien Dessenne
2019-03-27 23:07 ` Rob Herring
2019-03-29 15:59 ` Fabien DESSENNE
2019-04-04 1:29 ` Rob Herring
2019-03-05 14:24 ` [PATCH 2/8] dt-bindings: remoteproc: add bindings for stm32 remote processor driver Fabien Dessenne
2019-03-27 23:23 ` Rob Herring [this message]
2019-03-05 14:24 ` [PATCH 3/8] remoteproc: stm32: add an ST stm32_rproc driver Fabien Dessenne
2019-03-05 14:24 ` [PATCH 4/8] ARM: dts: stm32: add m4 remoteproc support on STM32MP157c Fabien Dessenne
2019-03-05 14:24 ` [PATCH 5/8] ARM: dts: stm32: declare copro reserved memories on STM32MP157c-ed1 Fabien Dessenne
2019-03-05 14:24 ` [PATCH 6/8] ARM: dts: stm32: enable m4 coprocessor support " Fabien Dessenne
2019-03-05 14:24 ` [PATCH 7/8] ARM: dts: stm32: declare copro reserved memories on STM32MP157a-dk1 Fabien Dessenne
2019-03-05 14:24 ` [PATCH 8/8] ARM: dts: stm32: enable m4 coprocessor support " Fabien Dessenne
2019-03-26 10:37 ` [PATCH 0/8] stm32 m4 remoteproc on STM32MP157c Alexandre Torgue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190327232301.GA2172@bogus \
--to=robh@kernel.org \
--cc=alexandre.torgue@st.com \
--cc=arnaud.pouliquen@st.com \
--cc=benjamin.gaignard@st.com \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=fabien.dessenne@st.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=loic.pallardy@st.com \
--cc=ludovic.barre@st.com \
--cc=mark.rutland@arm.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=ohad@wizery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).