From: Vitaly Chikunov <vt@altlinux.org>
To: Mimi Zohar <zohar@linux.ibm.com>
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
David Howells <dhowells@redhat.com>,
Dmitry Kasatkin <dmitry.kasatkin@gmail.com>,
linux-integrity@vger.kernel.org, keyrings@vger.kernel.org,
linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v8 10/10] integrity: support EC-RDSA signatures for asymmetric_verify
Date: Thu, 28 Mar 2019 09:16:48 +0300 [thread overview]
Message-ID: <20190328061648.knexdusdcadubeu6@altlinux.org> (raw)
In-Reply-To: <1553718067.4608.43.camel@linux.ibm.com>
On Wed, Mar 27, 2019 at 04:21:07PM -0400, Mimi Zohar wrote:
> > > diff --git a/security/integrity/digsig_asymmetric.c
> b/security/integrity/digsig_asymmetric.c
> > > > index d775e03fbbcc..99080871eb9f 100644
> > > > --- a/security/integrity/digsig_asymmetric.c
> > > > +++ b/security/integrity/digsig_asymmetric.c
> > > > @@ -104,9 +104,16 @@ int asymmetric_verify(struct key *keyring, const char *sig,
> > > >
> > > > memset(&pks, 0, sizeof(pks));
> > > >
> > > > - pks.pkey_algo = "rsa";
> > > > pks.hash_algo = hash_algo_name[hdr->hash_algo];
> > > > - pks.encoding = "pkcs1";
> > > > + if (hdr->hash_algo == HASH_ALGO_STREEBOG_256 ||
> > > > + hdr->hash_algo == HASH_ALGO_STREEBOG_512) {
> > > > + /* EC-RDSA and Streebog should go together. */
> > > > + pks.pkey_algo = "ecrdsa";
> > > > + pks.encoding = "raw";
> > >
> > > IMA signatures are stored as xattrs, making them persistent. Support
> > > for streebog was upstreamed in linux-5.0. This change would break
> > > existing systems using streebog. As long as this is not yet a concern
> >
> > In what sense it would break systems?
>
> For example, if executable files are currently labeled with
> rsa/streebog signatures, then enforcing file data integrity I assume
> would break if the kernel uses ecrdsa/streebog.
Ah. No, I did not implement RSA(Streebog) intentionally, since Streebog is
not in the list of permitted hashes for PKCS1. You may notice this by the
lack of appropriate rsa_asn1_template[] entry.
Thanks,
>
> Mimi
>
> >
> > Unless kernel crashes or signature is recognized as valid, I think, it should
> > not be called a break.
> >
> > > Reviewed-by: Mimi Zohar <zohar@linux.ibm.com>
> >
> > Thanks!
> >
> > >
> > > > + } else {
> > > > + pks.pkey_algo = "rsa";
> > > > + pks.encoding = "pkcs1";
> > > > + }
> > > > pks.digest = (u8 *)data;
> > > > pks.digest_size = datalen;
> > > > pks.s = hdr->sig;
> >
next prev parent reply other threads:[~2019-03-28 6:16 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-26 12:58 [PATCH v8 00/10] crypto: add EC-RDSA (GOST 34.10) algorithm Vitaly Chikunov
2019-03-26 12:58 ` [PATCH v8 01/10] crypto: akcipher - default implementations for request callbacks Vitaly Chikunov
2019-03-26 12:58 ` [PATCH v8 02/10] crypto: rsa - unimplement sign/verify for raw RSA backends Vitaly Chikunov
2019-03-26 12:58 ` [PATCH v8 03/10] crypto: akcipher - new verify API for public key algorithms Vitaly Chikunov
2019-03-26 16:00 ` Denis Kenzior
2019-03-26 12:58 ` [PATCH v8 04/10] KEYS: do not kmemdup digest in {public,tpm}_key_verify_signature Vitaly Chikunov
2019-03-26 12:58 ` [PATCH v8 05/10] X.509: parse public key parameters from x509 for akcipher Vitaly Chikunov
2019-03-26 16:14 ` Denis Kenzior
2019-03-26 12:58 ` [PATCH v8 06/10] crypto: Kconfig - create Public-key cryptography section Vitaly Chikunov
2019-03-26 12:58 ` [PATCH v8 07/10] crypto: ecc - make ecc into separate module Vitaly Chikunov
2019-03-26 12:58 ` [PATCH v8 08/10] crypto: ecrdsa - add EC-RDSA (GOST 34.10) algorithm Vitaly Chikunov
2019-03-26 12:58 ` [PATCH v8 09/10] crypto: ecrdsa - add EC-RDSA test vectors to testmgr Vitaly Chikunov
2019-03-26 12:58 ` [PATCH v8 10/10] integrity: support EC-RDSA signatures for asymmetric_verify Vitaly Chikunov
2019-03-27 18:10 ` Mimi Zohar
2019-03-27 20:14 ` Vitaly Chikunov
2019-03-27 20:21 ` Mimi Zohar
2019-03-28 6:16 ` Vitaly Chikunov [this message]
2019-04-08 16:05 ` [PATCH v8 00/10] crypto: add EC-RDSA (GOST 34.10) algorithm Vitaly Chikunov
2019-04-09 6:17 ` Herbert Xu
2019-04-09 14:02 ` Vitaly Chikunov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190328061648.knexdusdcadubeu6@altlinux.org \
--to=vt@altlinux.org \
--cc=dhowells@redhat.com \
--cc=dmitry.kasatkin@gmail.com \
--cc=herbert@gondor.apana.org.au \
--cc=keyrings@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=zohar@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).