From: Geert Uytterhoeven <geert+renesas@glider.be>
To: Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>
Cc: Benoit Parrot <bparrot@ti.com>,
Laxman Dewangan <ldewangan@nvidia.com>,
Tomeu Vizoso <tomeu.vizoso@collabora.com>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
Geert Uytterhoeven <geert+renesas@glider.be>
Subject: [PATCH 0/3] gpio: Failure path fixes
Date: Thu, 28 Mar 2019 14:13:46 +0100 [thread overview]
Message-ID: <20190328131349.18838-1-geert+renesas@glider.be> (raw)
Hi Linus, Bartosz,
After making a silly mistake in a pin control driver, pinctrl driver
initialization failed, causing an avalanche of GPIO driver failures, and
I was greeted by the following scary messages:
OF: ERROR: Bad of_node_put() on /soc/gpio@e6050000
...
WARNING: CPU: 0 PID: 1 at lib/refcount.c:156 kobject_get+0x38/0x4c
...
WARNING: CPU: 0 PID: 1 at lib/refcount.c:190 refcount_sub_and_test_checked+0x3c/0xa8
The first two patches fix bugs in related error paths, after which the
messages are gone.
The third patch is a drive-by fix for function comment.
Thanks for your comments!
Geert Uytterhoeven (3):
gpio: of: Fix of_gpiochip_add() error path
gpio: Fix gpiochip_add_data_with_key() error path
gpio: Remove obsolete comment about gpiochip_free_hogs() usage
drivers/gpio/gpiolib-of.c | 8 +++++++-
drivers/gpio/gpiolib.c | 14 ++++++++------
2 files changed, 15 insertions(+), 7 deletions(-)
--
2.17.1
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next reply other threads:[~2019-03-28 13:13 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-28 13:13 Geert Uytterhoeven [this message]
2019-03-28 13:13 ` [PATCH 1/3] gpio: of: Fix of_gpiochip_add() error path Geert Uytterhoeven
2019-03-28 15:37 ` Mukesh Ojha
2019-03-28 16:58 ` Linus Walleij
2019-03-28 13:13 ` [PATCH 2/3] gpio: Fix gpiochip_add_data_with_key() " Geert Uytterhoeven
2019-03-28 15:31 ` Mukesh Ojha
2019-03-28 18:20 ` Geert Uytterhoeven
2019-03-28 17:03 ` Linus Walleij
2019-03-28 13:13 ` [PATCH 3/3] gpio: Remove obsolete comment about gpiochip_free_hogs() usage Geert Uytterhoeven
2019-03-28 15:01 ` Mukesh Ojha
2019-03-28 17:00 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190328131349.18838-1-geert+renesas@glider.be \
--to=geert+renesas@glider.be \
--cc=bgolaszewski@baylibre.com \
--cc=bparrot@ti.com \
--cc=ldewangan@nvidia.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tomeu.vizoso@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).