From: Douglas Anderson <dianders@chromium.org>
To: Thierry Reding <thierry.reding@gmail.com>,
Heiko Stuebner <heiko@sntech.de>,
Sean Paul <seanpaul@chromium.org>
Cc: linux-rockchip@lists.infradead.org,
"Laurent Pinchart" <laurent.pinchart@ideasonboard.com>,
dri-devel@lists.freedesktop.org,
"Boris Brezillon" <boris.brezillon@collabora.com>,
"Ezequiel Garcia" <ezequiel@collabora.com>,
"Enric Balletbò" <enric.balletbo@collabora.com>,
"Rob Herring" <robh+dt@kernel.org>,
mka@chromium.org, "Douglas Anderson" <dianders@chromium.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
"Mark Rutland" <mark.rutland@arm.com>,
linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 6/7] ARM: dts: rockchip: Specify rk3288-veyron-jerry's display timings
Date: Thu, 28 Mar 2019 10:17:09 -0700 [thread overview]
Message-ID: <20190328171710.31949-7-dianders@chromium.org> (raw)
In-Reply-To: <20190328171710.31949-1-dianders@chromium.org>
Let's document the display timings that jerry has been using out in
the field. This uses the standard blankings but a slightly slower
clock rate, thus getting a refresh rate 58.3 Hz.
NOTE: this won't really do anything except cause DRM to properly
report the refresh rate since vop_crtc_mode_fixup() was rounding the
pixel clock to 74.25 MHz anyway. Apparently the adjusted rate isn't
exposed to userspace so it's important that the rate we're trying to
achieve is mostly right.
For the downstream kernel change related to this see See
https://crrev.com/c/324558.
NOTE: minnie will be fixed up in a future patch, so for now we'll just
delete the panel timings there.
Signed-off-by: Douglas Anderson <dianders@chromium.org>
---
Changes in v4:
- rk3288-veyron-jerry patch new for v4.
Changes in v3: None
Changes in v2: None
arch/arm/boot/dts/rk3288-veyron-chromebook.dtsi | 14 ++++++++++++++
arch/arm/boot/dts/rk3288-veyron-minnie.dts | 2 ++
2 files changed, 16 insertions(+)
diff --git a/arch/arm/boot/dts/rk3288-veyron-chromebook.dtsi b/arch/arm/boot/dts/rk3288-veyron-chromebook.dtsi
index b54746df3661..0b1789b50c21 100644
--- a/arch/arm/boot/dts/rk3288-veyron-chromebook.dtsi
+++ b/arch/arm/boot/dts/rk3288-veyron-chromebook.dtsi
@@ -76,6 +76,20 @@
power-supply = <&vcc33_lcd>;
backlight = <&backlight>;
+ panel-timing {
+ clock-frequency = <74250000>;
+ hactive = <1366>;
+ hfront-porch = <136>;
+ hback-porch = <60>;
+ hsync-len = <30>;
+ hsync-active = <0>;
+ vactive = <768>;
+ vfront-porch = <8>;
+ vback-porch = <12>;
+ vsync-len = <12>;
+ vsync-active = <0>;
+ };
+
ports {
panel_in: port {
panel_in_edp: endpoint {
diff --git a/arch/arm/boot/dts/rk3288-veyron-minnie.dts b/arch/arm/boot/dts/rk3288-veyron-minnie.dts
index f95d0c5fcf71..ca7512ade222 100644
--- a/arch/arm/boot/dts/rk3288-veyron-minnie.dts
+++ b/arch/arm/boot/dts/rk3288-veyron-minnie.dts
@@ -142,6 +142,8 @@
&panel {
compatible = "auo,b101ean01", "simple-panel";
power-supply= <&panel_regulator>;
+
+ /delete-node/ panel-timing;
};
&rk808 {
--
2.21.0.392.gf8f6787159e-goog
next prev parent reply other threads:[~2019-03-28 17:18 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-28 17:17 [PATCH v4 0/7] drm/panel: simple: Add mode support to devicetree Douglas Anderson
2019-03-28 17:17 ` [PATCH v4 1/7] dt-bindings: Add panel-timing subnode to simple-panel Douglas Anderson
2019-03-28 20:26 ` Ezequiel Garcia
2019-03-28 23:50 ` Doug Anderson
2019-03-29 16:12 ` Rob Herring
2019-03-29 16:14 ` Doug Anderson
2019-03-28 17:17 ` [PATCH v4 2/7] drm/panel: simple: Add ability to override typical timing Douglas Anderson
2019-03-29 19:13 ` Heiko Stübner
2019-03-28 17:17 ` [PATCH v4 3/7] arm64: dts: rockchip: Specify override mode for kevin panel Douglas Anderson
2019-03-28 17:17 ` [PATCH v4 4/7] drm/panel: simple: Use display_timing for Innolux n116bge Douglas Anderson
2019-03-29 19:17 ` Heiko Stübner
2019-03-28 17:17 ` [PATCH v4 5/7] drm/panel: simple: Use display_timing for AUO b101ean01 Douglas Anderson
2019-03-28 17:17 ` Douglas Anderson [this message]
2019-03-29 19:20 ` [PATCH v4 6/7] ARM: dts: rockchip: Specify rk3288-veyron-jerry's display timings Heiko Stübner
2019-03-28 17:17 ` [PATCH v4 7/7] ARM: dts: rockchip: Specify rk3288-veyron-minnie's " Douglas Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190328171710.31949-7-dianders@chromium.org \
--to=dianders@chromium.org \
--cc=boris.brezillon@collabora.com \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=enric.balletbo@collabora.com \
--cc=ezequiel@collabora.com \
--cc=heiko@sntech.de \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=mka@chromium.org \
--cc=robh+dt@kernel.org \
--cc=seanpaul@chromium.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).