From: David Miller <davem@davemloft.net>
To: Markus.Amend@telekom.de
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
dccp@vger.kernel.org
Subject: Re: [PATCH v2] net: dccp: Checksum verification enhancement
Date: Fri, 29 Mar 2019 10:56:52 -0700 (PDT) [thread overview]
Message-ID: <20190329.105652.1950793642095951687.davem@davemloft.net> (raw)
In-Reply-To: <FRAPR01MB117083E6F526BDCB88742713FA5F0@FRAPR01MB1170.DEUPRD01.PROD.OUTLOOK.DE>
From: <Markus.Amend@telekom.de>
Date: Tue, 26 Mar 2019 08:54:41 +0000
> Modify checksum verification to allow the validation of skb->ip_summed, in case the checksum has already been verified in lower layers.
Please format your commit message to ~80 column lines.
> @@ -763,8 +763,9 @@ int dccp_invalid_packet(struct sk_buff *skb)
> }
>
> /* If header checksum is incorrect, drop packet and return.
> - * (This step is completed in the AF-dependent functions.) */
> - skb->csum = skb_checksum(skb, 0, cscov, 0);
> + * (This step is completed in the AF-dependent functions.)
> + * skb->csum = skb_checksum(skb, 0, cscov, 0);
> + */
Please do not just comment out code, explain what is operation can be expected
to be done already here and why.
prev parent reply other threads:[~2019-03-29 17:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-26 8:54 [PATCH v2] net: dccp: Checksum verification enhancement Markus.Amend
2019-03-29 17:56 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190329.105652.1950793642095951687.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Markus.Amend@telekom.de \
--cc=dccp@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).