From: Dan Carpenter <dan.carpenter@oracle.com>
To: Marc Zyngier <marc.zyngier@arm.com>,
Jiaxun Yang <jiaxun.yang@flygoat.com>
Cc: Jason Cooper <jason@lakedaemon.net>,
Thomas Gleixner <tglx@linutronix.de>,
Marc Zyngier <marc.zyngier@arm.com>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
Mukesh Ojha <mojha@codeaurora.org>
Subject: [PATCH v2] irqchip/irq-ls1x: Missing error code in ls1x_intc_of_init()
Date: Fri, 29 Mar 2019 09:21:37 +0300 [thread overview]
Message-ID: <20190329062136.GQ32613@kadam> (raw)
In-Reply-To: <a90ad2ff-acc1-0baf-d7e4-1292bb1c8464@codeaurora.org>
Currently, when irq_domain_add_linear() fails, the error code does not
get so it returns zero which is wrong. Fix it by setting appropriate
error code.
Fixes: 9e543e22e204 ("irqchip: Add driver for Loongson-1 interrupt controller")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Mukesh Ojha <mojha@codeaurora.org>
---
V2: Improve the commit message
drivers/irqchip/irq-ls1x.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/irqchip/irq-ls1x.c b/drivers/irqchip/irq-ls1x.c
index 86b72fbd3b45..353111a10413 100644
--- a/drivers/irqchip/irq-ls1x.c
+++ b/drivers/irqchip/irq-ls1x.c
@@ -130,6 +130,7 @@ static int __init ls1x_intc_of_init(struct device_node *node,
NULL);
if (!priv->domain) {
pr_err("ls1x-irq: cannot add IRQ domain\n");
+ err = -ENOMEM;
goto out_iounmap;
}
--
2.17.1
next prev parent reply other threads:[~2019-03-29 6:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-28 14:38 [PATCH] irqchip/irq-ls1x: Missing error code in ls1x_intc_of_init() Dan Carpenter
2019-03-28 19:14 ` Mukesh Ojha
2019-03-29 6:21 ` Dan Carpenter [this message]
2019-03-31 4:03 ` [PATCH v2] " Jiaxun Yang
2019-04-05 12:43 ` [tip:irq/urgent] " tip-bot for Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190329062136.GQ32613@kadam \
--to=dan.carpenter@oracle.com \
--cc=jason@lakedaemon.net \
--cc=jiaxun.yang@flygoat.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=mojha@codeaurora.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).