From: "Ondřej Jirman" <megous@megous.com>
To: Maxime Ripard <maxime.ripard@bootlin.com>
Cc: wens@csie.org, robh@kernel.org, johan@kernel.org,
mark.rutland@arm.com, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com
Subject: Re: [PATCH 2/7] ARM: dts: sun8i: tbs-a711: Add node for BMA250 accelerometer
Date: Mon, 1 Apr 2019 13:34:33 +0200 [thread overview]
Message-ID: <20190401113433.z2dps2s5vszt37n7@core.my.home> (raw)
In-Reply-To: <20190401063049.h2as3qllpelkxkbb@flea>
Hello Maxime,
On Mon, Apr 01, 2019 at 08:30:49AM +0200, Maxime Ripard wrote:
> Hi,
>
> On Wed, Mar 27, 2019 at 01:18:38AM +0100, megous@megous.com wrote:
> > From: Ondrej Jirman <megous@megous.com>
> >
> > A711 tablet has BMA250 accelerometer connected to I2C1 bus. Enable
> > both the I2C1 bus and add the accelerometer device to it.
> >
> > Signed-off-by: Ondrej Jirman <megous@megous.com>
> > ---
> > arch/arm/boot/dts/sun8i-a83t-tbs-a711.dts | 15 +++++++++++++++
> > 1 file changed, 15 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/sun8i-a83t-tbs-a711.dts b/arch/arm/boot/dts/sun8i-a83t-tbs-a711.dts
> > index 6aae70c89a1e..347fc0c31fa4 100644
> > --- a/arch/arm/boot/dts/sun8i-a83t-tbs-a711.dts
> > +++ b/arch/arm/boot/dts/sun8i-a83t-tbs-a711.dts
> > @@ -156,6 +156,21 @@
> > status = "okay";
> > };
> >
> > +&i2c1 {
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&i2c1_pins>;
>
> It's there already
I see, I'll drop it. Thanks.
> > + clock-frequency = <400000>;
> > + status = "okay";
> > +
> > + /* Accelerometer */
> > + bma250@18 {
>
> The node name should be the class of the device, not its model, so
> something like accelerometer.
I'll rename this.
thank you,
Ondrej
> Maxime
>
> --
> Maxime Ripard, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com
next prev parent reply other threads:[~2019-04-01 11:34 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-27 0:18 [PATCH 0/7] Add bluetooth, gps and accelerometer to TBS A711 megous
2019-03-27 0:18 ` [PATCH 1/7] ARM: dts: sun8i: tbs-a711: Enable bluetooth megous
2019-04-01 8:00 ` Maxime Ripard
2019-03-27 0:18 ` [PATCH 2/7] ARM: dts: sun8i: tbs-a711: Add node for BMA250 accelerometer megous
2019-04-01 6:30 ` Maxime Ripard
2019-04-01 11:34 ` Ondřej Jirman [this message]
2019-03-27 0:18 ` [PATCH 3/7] ARM: dts: sun8i: a83t: Add nodes for UART2-UART4 megous
2019-04-01 8:00 ` Maxime Ripard
2019-03-27 0:18 ` [PATCH 4/7] ARM: dts: sun8i: a83t: Add UART2 PB pins megous
2019-03-28 8:01 ` [linux-sunxi] " Chen-Yu Tsai
2019-03-27 0:18 ` [PATCH 5/7] gnss: Add u-blox,neo-6m compatible megous
2019-03-27 0:18 ` [PATCH 6/7] dt-bindings: " megous
2019-03-31 6:42 ` Rob Herring
2019-03-27 0:18 ` [PATCH 7/7] ARM: dts: sun8i: tbs-a711: Enable UART2 (for NEO-6M GPS module) megous
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190401113433.z2dps2s5vszt37n7@core.my.home \
--to=megous@megous.com \
--cc=devicetree@vger.kernel.org \
--cc=johan@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=mark.rutland@arm.com \
--cc=maxime.ripard@bootlin.com \
--cc=robh@kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).