From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7B8DC43381 for ; Mon, 1 Apr 2019 17:42:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 93E0120830 for ; Mon, 1 Apr 2019 17:42:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1554140558; bh=HOqUgGFvhjENmHrXWy3Ba3bdKyoFHxcshizRBxmpssM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=RLcGW8D+GPYVuT0da8NtJ38pKQ7ihAFC93vGkwxMvn6mH5wFlprue78P2Jx5uq4c0 EUqQ8msoGmssM9NDD7vQl3aPfxulJbFY0+81sXrstr4LgTqTYP+dvcdiXnIOy8xC5u IuylvfkaFfoPJQt+rBB4+kV6RT/JcDn+a5NGRMfA= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387929AbfDARgv (ORCPT ); Mon, 1 Apr 2019 13:36:51 -0400 Received: from mail.kernel.org ([198.145.29.99]:48758 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388072AbfDARgp (ORCPT ); Mon, 1 Apr 2019 13:36:45 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8D8AA20830; Mon, 1 Apr 2019 17:36:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1554140205; bh=HOqUgGFvhjENmHrXWy3Ba3bdKyoFHxcshizRBxmpssM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Wo0sAG1wX2OKQPJ4aLKsrqnqx4ezn2hRZKpsZ8bh8annb9dq17CKYIAhC0zIC3O3T XYsHpdjVNd2402MAMyP7klZ04QhMZ9t9lipXcl21mw0xGkxliLiik6kr3fdrq/nbJ9 qxggcQ0qdRrF27oyaQMTub64Akxek7zYfTic3NkA= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Andrey Konovalov , Nathan Chancellor , Arnd Bergmann Subject: [PATCH 4.4 128/131] Revert "USB: core: only clean up what we allocated" Date: Mon, 1 Apr 2019 19:03:18 +0200 Message-Id: <20190401170102.088883708@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190401170051.645954551@linuxfoundation.org> References: <20190401170051.645954551@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Greg Kroah-Hartman commit cf4df407e0d7cde60a45369c2a3414d18e2d4fdd upstream. This reverts commit 32fd87b3bbf5f7a045546401dfe2894dbbf4d8c3. Alan wrote a better fix for this... Cc: Andrey Konovalov Cc: stable Cc: Nathan Chancellor Cc: Arnd Bergmann Signed-off-by: Greg Kroah-Hartman --- drivers/usb/core/config.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) --- a/drivers/usb/core/config.c +++ b/drivers/usb/core/config.c @@ -734,21 +734,18 @@ void usb_destroy_configuration(struct us return; if (dev->rawdescriptors) { - for (i = 0; i < dev->descriptor.bNumConfigurations && - i < USB_MAXCONFIG; i++) + for (i = 0; i < dev->descriptor.bNumConfigurations; i++) kfree(dev->rawdescriptors[i]); kfree(dev->rawdescriptors); dev->rawdescriptors = NULL; } - for (c = 0; c < dev->descriptor.bNumConfigurations && - c < USB_MAXCONFIG; c++) { + for (c = 0; c < dev->descriptor.bNumConfigurations; c++) { struct usb_host_config *cf = &dev->config[c]; kfree(cf->string); - for (i = 0; i < cf->desc.bNumInterfaces && - i < USB_MAXINTERFACES; i++) { + for (i = 0; i < cf->desc.bNumInterfaces; i++) { if (cf->intf_cache[i]) kref_put(&cf->intf_cache[i]->ref, usb_release_interface_cache);