linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Mukesh Ojha <mojha@codeaurora.org>
Cc: Marcelo Schmitt <marcelo.schmitt1@gmail.com>,
	lars@metafoo.de, Michael.Hennerich@analog.com,
	stefan.popa@analog.com, jic23@kernel.org, knaack.h@gmx.de,
	pmeerw@pmeerw.net, linux-iio@vger.kernel.org,
	devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
	kernel-usp@googlegroups.com
Subject: Re: [PATCH 2/4] staging: iio: ad9832: add SPDX identifier
Date: Mon, 1 Apr 2019 19:13:55 +0200	[thread overview]
Message-ID: <20190401171355.GA19716@kroah.com> (raw)
In-Reply-To: <ac167cc8-4236-2e15-d5f2-fa222d95da49@codeaurora.org>

On Mon, Apr 01, 2019 at 08:36:50PM +0530, Mukesh Ojha wrote:
> 
> On 4/1/2019 8:07 PM, Marcelo Schmitt wrote:
> > Add SPDX identifier of GPL-2.0 for the ad9832 driver.
> > 
> > Signed-off-by: Marcelo Schmitt <marcelo.schmitt1@gmail.com>
> > ---
> >   drivers/staging/iio/frequency/ad9832.c | 3 +--
> >   1 file changed, 1 insertion(+), 2 deletions(-)
> > 
> > diff --git a/drivers/staging/iio/frequency/ad9832.c b/drivers/staging/iio/frequency/ad9832.c
> > index 50a583020072..d8d4a7936275 100644
> > --- a/drivers/staging/iio/frequency/ad9832.c
> > +++ b/drivers/staging/iio/frequency/ad9832.c
> > @@ -1,9 +1,8 @@
> > +// SPDX-License-Identifier: GPL-2.0
> 
> FYI
> 
> Use C notations here as per https://lkml.org/lkml/2019/2/13/570.
> 
> <https://lkml.org/lkml/2019/2/13/570>
> 
> Once you fix it then you can take mine
> Reviewed-by: Mukesh Ojha <mojha@codeaurora.org>

Did you read the documentation about how to put a proper SPDX line in
the kernel documentation?  For .c files, you have to use "//", not "/* */"

Please read:
	Documentation/process/license-rules.rst
and see the section "Style" for all of the details.

thanks,

greg k-h

  parent reply	other threads:[~2019-04-01 17:40 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-01 14:37 [PATCH 2/4] staging: iio: ad9832: add SPDX identifier Marcelo Schmitt
     [not found] ` <ac167cc8-4236-2e15-d5f2-fa222d95da49@codeaurora.org>
2019-04-01 17:13   ` Greg KH [this message]
2019-04-01 19:54     ` Mukesh Ojha
2019-04-02 14:40     ` Marcelo Schmitt
2019-04-07 11:26       ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190401171355.GA19716@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=Michael.Hennerich@analog.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=jic23@kernel.org \
    --cc=kernel-usp@googlegroups.com \
    --cc=knaack.h@gmx.de \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcelo.schmitt1@gmail.com \
    --cc=mojha@codeaurora.org \
    --cc=pmeerw@pmeerw.net \
    --cc=stefan.popa@analog.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).