From: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
To: thierry.reding@gmail.com, linux-pwm@vger.kernel.org,
linux-amlogic@lists.infradead.org
Cc: narmstrong@baylibre.com, jbrunet@baylibre.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, u.kleine-koenig@pengutronix.de,
bichao.zheng@amlogic.com,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Subject: [PATCH 2/2] pwm: meson: don't disable pwm when setting duty repeatedly
Date: Mon, 1 Apr 2019 20:18:17 +0200 [thread overview]
Message-ID: <20190401181817.11999-3-martin.blumenstingl@googlemail.com> (raw)
In-Reply-To: <20190401181817.11999-1-martin.blumenstingl@googlemail.com>
From: Bichao Zheng <bichao.zheng@amlogic.com>
There is an abnormally low about 20ms,when setting duty repeatedly.
Because setting the duty will disable pwm and then enable. Delete
this operation now.
Fixes: 211ed630753d2f ("pwm: Add support for Meson PWM Controller")
Signed-off-by: Bichao Zheng <bichao.zheng@amlogic.com>
[ Dropped code instead of hiding it behind a comment ]
Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
---
drivers/pwm/pwm-meson.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/drivers/pwm/pwm-meson.c b/drivers/pwm/pwm-meson.c
index 4b708c1fcb1d..e247ab632530 100644
--- a/drivers/pwm/pwm-meson.c
+++ b/drivers/pwm/pwm-meson.c
@@ -325,11 +325,6 @@ static int meson_pwm_apply(struct pwm_chip *chip, struct pwm_device *pwm,
if (state->period != channel->state.period ||
state->duty_cycle != channel->state.duty_cycle ||
state->polarity != channel->state.polarity) {
- if (channel->state.enabled) {
- meson_pwm_disable(meson, pwm->hwpwm);
- channel->state.enabled = false;
- }
-
if (state->polarity != channel->state.polarity) {
if (state->polarity == PWM_POLARITY_NORMAL)
meson->inverter_mask |= BIT(pwm->hwpwm);
--
2.21.0
next prev parent reply other threads:[~2019-04-01 18:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-01 18:18 [PATCH 0/2] pwm: meson: two small bug-fixes Martin Blumenstingl
2019-04-01 18:18 ` [PATCH 1/2] pwm: meson: consider 128 a valid pre-divider Martin Blumenstingl
2019-04-01 18:38 ` Uwe Kleine-König
2019-04-02 19:22 ` Martin Blumenstingl
2019-04-02 19:55 ` Uwe Kleine-König
2019-04-03 11:19 ` Neil Armstrong
2019-04-01 18:18 ` Martin Blumenstingl [this message]
2019-04-03 11:19 ` [PATCH 2/2] pwm: meson: don't disable pwm when setting duty repeatedly Neil Armstrong
2019-05-09 14:52 ` [PATCH 0/2] pwm: meson: two small bug-fixes Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190401181817.11999-3-martin.blumenstingl@googlemail.com \
--to=martin.blumenstingl@googlemail.com \
--cc=bichao.zheng@amlogic.com \
--cc=jbrunet@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=narmstrong@baylibre.com \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).