From: Han Nandor <nandor.han@vaisala.com>
To: "broonie@kernel.org" <broonie@kernel.org>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"rafael@kernel.org" <rafael@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: Han Nandor <nandor.han@vaisala.com>
Subject: [RFC PATCH 0/1] Verify if register is writeable before a write operation
Date: Tue, 2 Apr 2019 08:01:21 +0000 [thread overview]
Message-ID: <20190402080100.4875-1-nandor.han@vaisala.com> (raw)
Description
-----------
This is an RFC because I don't know if this is a bug or a normal use
case. It seems that the function `_regmap_raw_write_impl` from the regmap
framework verifies that a register is writable only using
the callback function, ignoring the other two (max allowed register,
register ranges)
Note: As a left right look I did check also `_regmap_raw_read` function,
and it seems that is missing this checks completely.
Is this a problem as well?
Device/Subsystems Impacted
-------------------------
This will impact drivers that end up using raw writes (firmware
download, ...)
Testing
-------
Test configuration:
- Kernel Version: 4.14.60 (just for clarification, the patch is rebased on master)
- The testing was done using a driver that has NVMEM support and is
using `regmap_bulk_write` method to write data to registers.
- The valid register range is 0x00->0xFF.
1. Configure a nvcell (4 bytes long) in DT which is outside the valid register range.
2. Write data to NVMEM using the nvcell
3. Verify the result:
3.1 Without the patch the data write in registers is successful with
no error displayed.
3.2 With the patch the data write is denied and an error is displayed.
Nandor Han (1):
regmap: verify if register is writeable before writing operations
drivers/base/regmap/regmap.c | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)
--
2.17.2
next reply other threads:[~2019-04-02 8:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-02 8:01 Han Nandor [this message]
2019-04-02 8:01 ` [RFC PATCH 1/1] regmap: verify if register is writeable before writing operations Han Nandor
2019-04-02 9:06 ` [RFC PATCH 0/1] Verify if register is writeable before a write operation Mark Brown
2019-04-02 9:49 ` Nandor Han
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190402080100.4875-1-nandor.han@vaisala.com \
--to=nandor.han@vaisala.com \
--cc=broonie@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).