From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Yury Norov <yury.norov@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Rasmus Villemoes <linux@rasmusvillemoes.dk>,
Arnd Bergmann <arnd@arndb.de>, Kees Cook <keescook@chromium.org>,
Matthew Wilcox <willy@infradead.org>,
Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>,
Mike Travis <travis@sgi.com>, Yury Norov <ynorov@marvell.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/5] lib: rework bitmap_parselist
Date: Wed, 3 Apr 2019 14:22:22 +0300 [thread overview]
Message-ID: <20190403112222.GR9224@smile.fi.intel.com> (raw)
In-Reply-To: <20190403044540.16322-3-ynorov@marvell.com>
On Wed, Apr 03, 2019 at 07:45:37AM +0300, Yury Norov wrote:
> Remove __bitmap_parselist helper and split the function to logical
> parts.
> /**
> - * __bitmap_parselist - convert list format ASCII string to bitmap
> - * @buf: read nul-terminated user string from this buffer
> - * @buflen: buffer size in bytes. If string is smaller than this
> - * then it must be terminated with a \0.
> - * @is_user: location of buffer, 0 indicates kernel space
> + * bitmap_parselist - convert list format ASCII string to bitmap
> + * @buf: read user string from this buffer; must be terminated
> + * with a \0 or \n.
It's still good idea to put line continuation with deeper level of
indentation.
> * @maskp: write resulting mask here
> * @nmaskbits: number of bits in mask to be written
> *
> @@ -498,127 +619,38 @@ EXPORT_SYMBOL(bitmap_print_to_pagebuf);
> *
> * Returns: 0 on success, -errno on invalid input strings. Error values:
> *
> - * - ``-EINVAL``: second number in range smaller than first
> + * - ``-EINVAL``: wrong region format
> * - ``-EINVAL``: invalid character in string
> * - ``-ERANGE``: bit number specified too large for mask
> + * - ``-EOVERFLOW``: integer overflow in the input parameters
> */
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2019-04-03 11:22 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-03 4:45 [PATCH v3 0/5] lib: rework bitmap_parselist and tests Yury Norov
2019-04-03 4:45 ` [PATCH 1/5] lib: make bitmap_parselist_user() a wrapper on bitmap_parselist() Yury Norov
2019-04-03 11:15 ` Andy Shevchenko
2019-04-03 11:17 ` Andy Shevchenko
2019-04-03 12:17 ` Rasmus Villemoes
2019-04-03 12:36 ` Andy Shevchenko
2019-04-03 4:45 ` [PATCH 2/5] lib: rework bitmap_parselist Yury Norov
2019-04-03 11:22 ` Andy Shevchenko [this message]
2019-04-03 4:45 ` [PATCH 3/5] lib/test_bitmap: switch test_bitmap_parselist to ktime_get() Yury Norov
2019-04-03 4:54 ` [PATCH v3 0/5] lib: rework bitmap_parselist and tests Yury Norov
2019-04-03 11:23 ` Andy Shevchenko
2019-04-03 11:24 ` Andy Shevchenko
2019-04-05 17:32 [PATCH v4 " Yury Norov
2019-04-05 17:32 ` [PATCH 2/5] lib: rework bitmap_parselist Yury Norov
2019-04-08 9:55 ` Andy Shevchenko
2019-04-16 6:37 [PATCH v5 0/5] lib: rework bitmap_parselist and tests Yury Norov
2019-04-16 6:37 ` [PATCH 2/5] lib: rework bitmap_parselist Yury Norov
2019-04-16 13:18 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190403112222.GR9224@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=penguin-kernel@I-love.SAKURA.ne.jp \
--cc=travis@sgi.com \
--cc=willy@infradead.org \
--cc=ynorov@marvell.com \
--cc=yury.norov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).