linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jiri Olsa <jolsa@redhat.com>
To: Song Liu <songliubraving@fb.com>
Cc: Adrian Hunter <adrian.hunter@intel.com>,
	Andi Kleen <andi@firstfloor.org>,
	"acme@kernel.org" <acme@kernel.org>,
	"jolsa@kernel.org" <jolsa@kernel.org>,
	"namhyung@kernel.org" <namhyung@kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-perf-users@vger.kernel.org"
	<linux-perf-users@vger.kernel.org>,
	Andi Kleen <ak@linux.intel.com>
Subject: Re: [BUG] perf: intel_pt won't display kernel function
Date: Wed, 3 Apr 2019 20:10:47 +0200	[thread overview]
Message-ID: <20190403181047.GC32001@krava> (raw)
In-Reply-To: <4EA3EF29-6D79-4F79-B1AD-0B6C12A5FF97@fb.com>

On Wed, Apr 03, 2019 at 05:05:02PM +0000, Song Liu wrote:
> 
> 
> > On Apr 3, 2019, at 7:37 AM, Jiri Olsa <jolsa@redhat.com> wrote:
> > 
> > hi,
> > perf script --call-trace stop working for me recently,
> > and displays only user space functions
> > 
> > I bisected that to:
> >  7b612e291a5a perf tools: Synthesize PERF_RECORD_* for loaded BPF programs
> > 
> > data from following comands will display user space functions only:
> >  # perf-with-kcore record pt -e intel_pt// -- ls
> >  # perf-with-kcore script pt --call-trace
> 
> Seems the following are ok (upstream as-is)?
> 
> ./perf record -e intel_pt// -- ls
> ./perf script --call-trace

yes, I think it's the --kallsyms otion which is added by
perf-with-kcore that's broken

jirka

> 
> Jiri, could you please verify this? (Sorry I am new to perf-with-kcore). 
> 
> Thanks,
> Song
> 
> > 
> > when I disable the bpf synthesizing (patch below), kernel functions are back
> > 
> > I guess the new events mess up with intel_pt decoder somehow
> > 
> > 
> > thanks,
> > jirka
> > 
> > 
> > ---
> > diff --git a/tools/perf/builtin-record.c b/tools/perf/builtin-record.c
> > index 4e2d953d4bc5..3daa78bc6549 100644
> > --- a/tools/perf/builtin-record.c
> > +++ b/tools/perf/builtin-record.c
> > @@ -1114,10 +1114,12 @@ static int record__synthesize(struct record *rec, bool tail)
> > 		return err;
> > 	}
> > 
> > +#if 0
> > 	err = perf_event__synthesize_bpf_events(session, process_synthesized_event,
> > 						machine, opts);
> > 	if (err < 0)
> > 		pr_warning("Couldn't synthesize bpf events.\n");
> > +#endif
> > 
> > 	err = __machine__synthesize_threads(machine, tool, &opts->target, rec->evlist->threads,
> > 					    process_synthesized_event, opts->sample_address,
> 

      reply	other threads:[~2019-04-03 18:10 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-03 14:37 [BUG] perf: intel_pt won't display kernel function Jiri Olsa
2019-04-03 14:53 ` Arnaldo Carvalho de Melo
2019-04-03 15:15   ` Arnaldo Carvalho de Melo
2019-04-03 16:27     ` Song Liu
2019-04-03 18:50       ` Arnaldo Carvalho de Melo
2019-04-03 18:55         ` Song Liu
2019-04-03 18:59           ` Song Liu
2019-04-03 21:48             ` Song Liu
2019-04-04  9:14               ` Jiri Olsa
2019-04-04 12:25                 ` Jiri Olsa
2019-04-04 17:08                   ` Song Liu
2019-04-04 17:38                     ` Jiri Olsa
2019-04-03 17:05 ` Song Liu
2019-04-03 18:10   ` Jiri Olsa [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190403181047.GC32001@krava \
    --to=jolsa@redhat.com \
    --cc=acme@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=ak@linux.intel.com \
    --cc=andi@firstfloor.org \
    --cc=jolsa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=namhyung@kernel.org \
    --cc=songliubraving@fb.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).