From: Gerd Hoffmann <kraxel@redhat.com>
To: "Noralf Trønnes" <noralf@tronnes.org>
Cc: Daniel Vetter <daniel@ffwll.ch>, David Airlie <airlied@linux.ie>,
David Airlie <airlied@redhat.com>,
open list <linux-kernel@vger.kernel.org>,
dri-devel <dri-devel@lists.freedesktop.org>,
"open list:DRM DRIVER FOR QEMU'S CIRRUS DEVICE"
<virtualization@lists.linux-foundation.org>
Subject: Re: [PATCH] drm/cirrus: rewrite and modernize driver.
Date: Thu, 4 Apr 2019 12:27:22 +0200 [thread overview]
Message-ID: <20190404102722.w6c7aoxzcrhn5xhi@sirius.home.kraxel.org> (raw)
In-Reply-To: <2866e37e-8563-1f1e-8f16-1119f70d52e1@tronnes.org>
Hi,
> > tinydrm_xrgb8888_to_*
> >
> > imo these could be put into some drm_format_helpers.c to be shared.
>
> I agree, my long term goal is to get rid of tinydrm.ko. Just haven't got
> there yet.
>
> Gerd, if you end up using some of those functions, feel free to move
> just those you need and I can do the rest later. But if you have time to
> spare I wouldn't mind getting all of them moved ;-)
For now I just promoted cirrus to be a tinydrm driver ;)
Noticed that those helpers (including tinydrm_memcpy for the
non-converting case) apply clipping on the source but not on
the destination. So, for fullscreen updates that works ok,
but for updating sub-rectangles it doesn't ...
So I guess I have to add a dest_clip bool parameter when moving them.
/me looks for a good place. drm_fb_helpers.c I think.
cheers,
Gerd
next prev parent reply other threads:[~2019-04-04 10:27 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-03 7:23 [PATCH] drm/cirrus: rewrite and modernize driver Gerd Hoffmann
2019-04-03 7:47 ` Daniel Vetter
2019-04-03 8:53 ` Gerd Hoffmann
2019-04-03 9:58 ` Noralf Trønnes
2019-04-03 10:27 ` Gerd Hoffmann
2019-04-03 15:12 ` Adam Jackson
2019-04-03 15:15 ` Daniel Stone
2019-04-03 15:52 ` Adam Jackson
2019-04-04 2:58 ` David Airlie
2019-04-04 5:50 ` Gerd Hoffmann
2019-04-04 6:31 ` Daniel Vetter
2019-04-04 7:09 ` Gerd Hoffmann
2019-04-04 8:30 ` Gerd Hoffmann
2019-04-04 8:52 ` Daniel Vetter
2019-04-04 10:06 ` Noralf Trønnes
2019-04-04 10:27 ` Gerd Hoffmann [this message]
2019-04-04 11:45 ` Noralf Trønnes
2019-04-04 11:45 ` Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190404102722.w6c7aoxzcrhn5xhi@sirius.home.kraxel.org \
--to=kraxel@redhat.com \
--cc=airlied@linux.ie \
--cc=airlied@redhat.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=noralf@tronnes.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).