From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13280C4360F for ; Thu, 4 Apr 2019 12:25:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DC5F9206C0 for ; Thu, 4 Apr 2019 12:25:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729902AbfDDMZe (ORCPT ); Thu, 4 Apr 2019 08:25:34 -0400 Received: from mx1.redhat.com ([209.132.183.28]:60748 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728479AbfDDMZe (ORCPT ); Thu, 4 Apr 2019 08:25:34 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 12677306D338; Thu, 4 Apr 2019 12:25:34 +0000 (UTC) Received: from krava (unknown [10.40.205.150]) by smtp.corp.redhat.com (Postfix) with SMTP id B11C41001E94; Thu, 4 Apr 2019 12:25:31 +0000 (UTC) Date: Thu, 4 Apr 2019 14:25:30 +0200 From: Jiri Olsa To: Song Liu Cc: Arnaldo Carvalho de Melo , Adrian Hunter , Andi Kleen , "jolsa@kernel.org" , "namhyung@kernel.org" , "linux-kernel@vger.kernel.org" , "linux-perf-users@vger.kernel.org" , Andi Kleen Subject: Re: [BUG] perf: intel_pt won't display kernel function Message-ID: <20190404122530.GC31233@krava> References: <20190403143738.GB32001@krava> <20190403145353.GE32553@kernel.org> <20190403151548.GF32553@kernel.org> <20190403185053.GH32553@kernel.org> <124332A9-146A-446F-A82A-910C8319170E@fb.com> <425141B8-8908-4D48-90FD-8806BA9E9E12@fb.com> <20190404091438.GB31233@krava> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190404091438.GB31233@krava> User-Agent: Mutt/1.11.3 (2019-02-01) X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.47]); Thu, 04 Apr 2019 12:25:34 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 04, 2019 at 11:14:38AM +0200, Jiri Olsa wrote: SNIP > Program received signal SIGABRT, Aborted. > 0x00007ffff75e60f5 in raise () from /lib64/libc.so.6 > Missing separate debuginfos, use: dnf debuginfo-install bzip2-libs-1.0.6-29.fc30.x86_64 elfutils-libelf-0.176-1.fc30.x86_64 elfutils-libs-0.176-1.fc30.x86_64 libgcc-9.0.1-0.10.fc30.x86_64 libunwind-1.3.1-2.fc30.x86_64 libxcrypt-4.4.4-2.fc30.x86_64 numactl-libs-2.0.12-2.fc30.x86_64 perl-libs-5.28.1-434.fc30.x86_64 python2-libs-2.7.16-1.fc30.x86_64 slang-2.3.2-5.fc30.x86_64 xz-libs-5.2.4-5.fc30.x86_64 zlib-1.2.11-15.fc30.x86_64 > (gdb) bt > #0 0x00007ffff75e60f5 in raise () from /lib64/libc.so.6 > #1 0x00007ffff75d0895 in abort () from /lib64/libc.so.6 > #2 0x00007ffff75d0769 in __assert_fail_base.cold () from /lib64/libc.so.6 > #3 0x00007ffff75de596 in __assert_fail () from /lib64/libc.so.6 > #4 0x00000000004fc006 in refcount_sub_and_test (i=1, r=0x1224e88) at /home/jolsa/linux/tools/include/linux/refcount.h:131 > #5 refcount_dec_and_test (r=0x1224e88) at /home/jolsa/linux/tools/include/linux/refcount.h:148 > #6 map__put (map=0x1224df0) at util/map.c:299 > #7 0x00000000004fdb95 in __maps__remove (map=0x1224df0, maps=0xb17d80) at util/map.c:953 > #8 maps__remove (maps=0xb17d80, map=0x1224df0) at util/map.c:959 > #9 0x00000000004f7d8a in map_groups__remove (map=, mg=) at util/map_groups.h:65 > #10 machine__process_ksymbol_unregister (sample=, event=0x7ffff7279670, machine=) at util/machine.c:728 > #11 machine__process_ksymbol (machine=, event=0x7ffff7279670, sample=) at util/machine.c:741 > #12 0x00000000004fffbb in perf_session__deliver_event (session=0xb11390, event=0x7ffff7279670, tool=0x7fffffffc7b0, file_offset=13936) at util/session.c:1362 > #13 0x00000000005039bb in do_flush (show_progress=false, oe=0xb17e80) at util/ordered-events.c:243 > #14 __ordered_events__flush (oe=0xb17e80, how=OE_FLUSH__ROUND, timestamp=) at util/ordered-events.c:322 > #15 0x00000000005005e4 in perf_session__process_user_event (session=session@entry=0xb11390, event=event@entry=0x7ffff72a4af8, > file_offset=file_offset@entry=191224) at util/session.c:1402 > #16 0x000000000050091e in perf_session__process_event (file_offset=191224, event=0x7ffff72a4af8, session=0xb11390) at util/session.c:1529 > #17 process_simple (session=session@entry=0xb11390, event=event@entry=0x7ffff72a4af8, file_offset=file_offset@entry=191224) at util/session.c:1962 > #18 0x0000000000501f44 in reader__process_events (prog=0x7fffffffc680, session=0xb11390, rd=) at util/session.c:1931 > #19 __perf_session__process_events (session=0xb11390) at util/session.c:1985 > #20 perf_session__process_events (session=0xb11390) at util/session.c:2018 > #21 0x000000000045bb42 in __cmd_script (script=0x7fffffffc7b0) at builtin-script.c:2429 > #22 cmd_script (argc=, argv=) at builtin-script.c:3770 > #23 0x00000000004a65cb in run_builtin (p=p@entry=0x994918 , argc=argc@entry=4, argv=argv@entry=0x7fffffffe160) at perf.c:303 > #24 0x000000000042da1e in handle_internal_command (argv=0x7fffffffe160, argc=4) at perf.c:355 > #25 run_argv (argcp=, argv=) at perf.c:399 > #26 main (argc=4, argv=0x7fffffffe160) at perf.c:521 we dont increase the map's reference for same name, which we need to.. I assume we we re able to hit this path with bpf maps/dso with same name jirka --- diff --git a/tools/perf/util/map.c b/tools/perf/util/map.c index 58ae5fc1f0e9..cdc49113ba38 100644 --- a/tools/perf/util/map.c +++ b/tools/perf/util/map.c @@ -929,10 +929,11 @@ static void __maps__insert_name(struct maps *maps, struct map *map) else if (rc > 0) p = &(*p)->rb_right; else - return; + goto out; } rb_link_node(&map->rb_node_name, parent, p); rb_insert_color(&map->rb_node_name, &maps->names); +out: map__get(map); }