From: Johannes Weiner <hannes@cmpxchg.org>
To: Zhaoyang Huang <huangzhaoyang@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Vlastimil Babka <vbabka@suse.cz>,
Pavel Tatashin <pasha.tatashin@oracle.com>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>,
David Rientjes <rientjes@google.com>,
Zhaoyang Huang <zhaoyang.huang@unisoc.com>,
Roman Gushchin <guro@fb.com>, Jeff Layton <jlayton@redhat.com>,
Matthew Wilcox <mawilcox@microsoft.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm:workingset use real time to judge activity of the file page
Date: Thu, 4 Apr 2019 12:39:14 -0400 [thread overview]
Message-ID: <20190404163914.GA4229@cmpxchg.org> (raw)
In-Reply-To: <1554348617-12897-1-git-send-email-huangzhaoyang@gmail.com>
On Thu, Apr 04, 2019 at 11:30:17AM +0800, Zhaoyang Huang wrote:
> From: Zhaoyang Huang <zhaoyang.huang@unisoc.com>
>
> In previous implementation, the number of refault pages is used
> for judging the refault period of each page, which is not precised as
> eviction of other files will be affect a lot on current cache.
> We introduce the timestamp into the workingset's entry and refault ratio
> to measure the file page's activity. It helps to decrease the affection
> of other files(average refault ratio can reflect the view of whole system
> 's memory).
I don't understand what exactly you're saying here, can you please
elaborate?
The reason it's using distances instead of absolute time is because
the ordering of the LRU is relative and not based on absolute time.
E.g. if a page is accessed every 500ms, it depends on all other pages
to determine whether this page is at the head or the tail of the LRU.
So when you refault, in order to determine the relative position of
the refaulted page in the LRU, you have to compare it to how fast that
LRU is moving. The absolute refault time, or the average time between
refaults, is not comparable to what's already in memory.
next prev parent reply other threads:[~2019-04-04 16:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-04 3:30 [PATCH] mm:workingset use real time to judge activity of the file page Zhaoyang Huang
2019-04-04 7:15 ` Michal Hocko
2019-04-05 3:13 ` Zhaoyang Huang
2019-04-04 16:39 ` Johannes Weiner [this message]
2019-04-04 23:23 ` Zhaoyang Huang
2019-04-05 19:34 ` Johannes Weiner
2019-04-05 3:24 ` Matthew Wilcox
-- strict thread matches above, loose matches on Subject: below --
2019-04-04 2:01 Zhaoyang Huang
2019-04-07 0:43 ` Suren Baghdasaryan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190404163914.GA4229@cmpxchg.org \
--to=hannes@cmpxchg.org \
--cc=akpm@linux-foundation.org \
--cc=guro@fb.com \
--cc=huangzhaoyang@gmail.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=jlayton@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mawilcox@microsoft.com \
--cc=pasha.tatashin@oracle.com \
--cc=rientjes@google.com \
--cc=vbabka@suse.cz \
--cc=zhaoyang.huang@unisoc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).