From: Borislav Petkov <bp@alien8.de>
To: Jann Horn <jannh@google.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
the arch/x86 maintainers <x86@kernel.org>,
kernel list <linux-kernel@vger.kernel.org>,
David Laight <David.Laight@aculab.com>
Subject: Re: [PATCH] x86/microcode: Refactor Intel microcode loading
Date: Thu, 4 Apr 2019 18:47:41 +0200 [thread overview]
Message-ID: <20190404164741.GH22539@zn.tnic> (raw)
In-Reply-To: <CAG48ez1wPdCZE07SeK_=yL3gWRnekLm3+YP3rvyw2YL_3+uNJw@mail.gmail.com>
On Thu, Apr 04, 2019 at 06:31:37PM +0200, Jann Horn wrote:
> Uuuh. I *definitely* tested this. I ran this yesterday evening on my
> home machine, on top of commit
> 14c741de93861749dfb60b4964028541f5c506ca from Linus' tree, plus two
> cherry-picked fixes for drm/ttm. I specifically made sure that I had
> the old microcode version before reloading these ways and I had the
> new version after reloading. And the verbose dmesg logs also looked
> okay.
How did you check the microcode revision before and after? /proc/cpuinfo?
Because that old method doesn't say anything in dmesg if there's no
debugging output, only the iucode_tool says something like the below if
you enable verbose output:
# iucode-tool -v --kernel=/dev/cpu/microcode /lib/firmware/intel-ucode/06-3a-09
iucode-tool: processed 1 valid microcode(s), 1 signature(s), 1 unique signature(s)
iucode-tool: selected 1 microcode(s), 1 signature(s)
iucode-tool: Uploading selected microcodes to: /dev/cpu/microcode
iucode-tool: /dev/cpu/microcode: 1 microcode entries uploaded, 13312 bytes
--
Regards/Gruss,
Boris.
Good mailing practices for 400: avoid top-posting and trim the reply.
next prev parent reply other threads:[~2019-04-04 16:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-04 11:11 [PATCH] x86/microcode: Refactor Intel microcode loading Jann Horn
2019-04-04 16:27 ` Borislav Petkov
2019-04-04 16:31 ` Jann Horn
2019-04-04 16:47 ` Borislav Petkov [this message]
2019-04-04 22:54 ` Jann Horn
2019-04-05 4:10 ` Borislav Petkov
2019-04-10 20:49 ` [tip:x86/microcode] x86/microcode/intel: Refactor Intel microcode blob loading tip-bot for Jann Horn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190404164741.GH22539@zn.tnic \
--to=bp@alien8.de \
--cc=David.Laight@aculab.com \
--cc=hpa@zytor.com \
--cc=jannh@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).