From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0F1EC4360F for ; Thu, 4 Apr 2019 17:00:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B11E2206DD for ; Thu, 4 Apr 2019 17:00:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729357AbfDDRAt (ORCPT ); Thu, 4 Apr 2019 13:00:49 -0400 Received: from asavdk4.altibox.net ([109.247.116.15]:55135 "EHLO asavdk4.altibox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727212AbfDDRAt (ORCPT ); Thu, 4 Apr 2019 13:00:49 -0400 Received: from ravnborg.org (unknown [158.248.194.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by asavdk4.altibox.net (Postfix) with ESMTPS id 0375D803E1; Thu, 4 Apr 2019 19:00:41 +0200 (CEST) Date: Thu, 4 Apr 2019 19:00:40 +0200 From: Sam Ravnborg To: Joe Perches Cc: Guido =?iso-8859-1?Q?G=FCnther?= , Thierry Reding , David Airlie , Daniel Vetter , Rob Herring , Mark Rutland , Kevin Hilman , Manivannan Sadhasivam , Shawn Guo , Jagan Teki , Martin Blumenstingl , Johan Hovold , "David S. Miller" , Mauro Carvalho Chehab , Greg Kroah-Hartman , Nicolas Ferre , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drm/panel: Rocktech jh057n00900: Add terminating newlines to logging Message-ID: <20190404170040.GA23897@ravnborg.org> References: <20190403161735.GN5238@ulmo> <1ed5eb3af4df6b2dd1544c7b696e034ed5c94f06.camel@perches.com> <20190404105359.GA8255@bogon.m.sigxcpu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=UpRNyd4B c=1 sm=1 tr=0 a=UWs3HLbX/2nnQ3s7vZ42gw==:117 a=UWs3HLbX/2nnQ3s7vZ42gw==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=kj9zAlcOel0A:10 a=IJv9LcIfAAAA:8 a=HLeGJmrDzAP9cNaqTE4A:9 a=CjuIK1q_8ugA:10 a=cmr4hm9N53k6aw-X_--Q:22 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Joe. On Thu, Apr 04, 2019 at 08:06:09AM -0700, Joe Perches wrote: > These were missing '\n' terminations, add them. > > Signed-off-by: Joe Perches > --- > drivers/gpu/drm/panel/panel-rocktech-jh057n00900.c | 19 ++++++++++--------- > 1 file changed, 10 insertions(+), 9 deletions(-) > > diff --git a/drivers/gpu/drm/panel/panel-rocktech-jh057n00900.c b/drivers/gpu/drm/panel/panel-rocktech-jh057n00900.c > index 158a6d548068..d88ea8da2ec2 100644 > --- a/drivers/gpu/drm/panel/panel-rocktech-jh057n00900.c > +++ b/drivers/gpu/drm/panel/panel-rocktech-jh057n00900.c > @@ -123,7 +123,7 @@ static int jh057n_init_sequence(struct jh057n *ctx) > > ret = mipi_dsi_dcs_exit_sleep_mode(dsi); > if (ret < 0) { > - DRM_DEV_ERROR(dev, "Failed to exit sleep mode"); > + DRM_DEV_ERROR(dev, "Failed to exit sleep mode\n"); I was under the impression that newlines was optional these days. Should we always use them with logging? I did not find any obvious clues in linux/printk.h Sam