From: Pavel Machek <pavel@ucw.cz>
To: Dmitry Torokhov <dtor@google.com>
Cc: Nick Crews <ncrews@chromium.org>,
Enric Balletbo i Serra <enric.balletbo@collabora.com>,
Benson Leung <bleung@chromium.org>,
linux-leds@vger.kernel.org, jacek.anaszewski@gmail.com,
linux-kernel <linux-kernel@vger.kernel.org>,
Duncan Laurie <dlaurie@chromium.org>,
Daniel Erat <derat@google.com>, Guenter Roeck <groeck@google.com>
Subject: Re: [PATCH] platform/chrome: Add Wilco EC keyboard backlight LEDs support
Date: Thu, 4 Apr 2019 21:23:31 +0200 [thread overview]
Message-ID: <20190404192331.GB29984@amd> (raw)
In-Reply-To: <CAE_wzQ8mr1OMKB+ASfsCdGcs70YrzEMN4Htfg1+O51=ByhXchw@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1341 bytes --]
Hi!
> > > > Yeah, well, we not let the cros_kbd_led_backlight.c use chromeos:: in
> > > > the first place. But it happened. We want all backlights for the
> > > > system keyboard to use common name, and "chromeos" is not really
> > > > suitable for that. "platform" is.
> > >
> > > Pavel, who exactly wants this and why? Looking at today's -next I see:
> > >
> > > dtor@dtor-ws:~/kernel/linux-next ((next-20190404))$ git grep
> > > "::kbd_backlight" | wc -l
> > > 18
> > > dtor@dtor-ws:~/kernel/linux-next ((next-20190404))$ git grep
> > > "platform::kbd_backlight" | wc -l
> > > 0
> > >
> > > so there isn't a single instance of "platform::kbd_backlight" and we
> > > definitely not changing existing names.
> >
> > Yeah, we made mistakes in the past. We _don't_ want userspace to have
> > ever growing list of names for userspace to follow.
> >
> > Backlight of internal keyboard is pretty common concept and there
> > should be one name for it.
>
> It is the *function* that is interesting to userspace, not full name,
> and we have proper standardization there.
Well, if full name is not interesting, as you argue, why do we have
this discussion?
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
next prev parent reply other threads:[~2019-04-04 19:23 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-08 20:38 [PATCH] platform/chrome: Add Wilco EC keyboard backlight LEDs support Nick Crews
2019-03-08 21:08 ` Pavel Machek
2019-03-11 15:29 ` Nick Crews
2019-04-04 11:24 ` Pavel Machek
2019-04-04 14:11 ` Nick Crews
2019-04-04 16:13 ` Dmitry Torokhov
2019-04-04 19:03 ` Pavel Machek
2019-04-04 19:09 ` Dmitry Torokhov
2019-04-04 19:23 ` Pavel Machek [this message]
2019-04-04 20:07 ` Dmitry Torokhov
2019-04-04 20:11 ` Pavel Machek
2019-04-04 20:22 ` Dmitry Torokhov
2019-04-04 20:34 ` Pavel Machek
2019-03-08 22:01 ` Dmitry Torokhov
2019-03-08 22:13 ` Pavel Machek
[not found] ` <CAHX4x84pgHeseVphBUq0HLJ70KU-Fz1TQtaq1=iz=mFCDZuJkw@mail.gmail.com>
2019-03-11 21:52 ` Pavel Machek
2019-03-12 16:05 ` Nick Crews
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190404192331.GB29984@amd \
--to=pavel@ucw.cz \
--cc=bleung@chromium.org \
--cc=derat@google.com \
--cc=dlaurie@chromium.org \
--cc=dtor@google.com \
--cc=enric.balletbo@collabora.com \
--cc=groeck@google.com \
--cc=jacek.anaszewski@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=ncrews@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).