From: David Miller <davem@davemloft.net>
To: colin.king@canonical.com
Cc: edumazet@google.com, kuznet@ms2.inr.ac.ru,
yoshfuji@linux-ipv6.org, netdev@vger.kernel.org,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tcp: remove redundant check on tskb
Date: Sat, 06 Apr 2019 18:18:34 -0700 (PDT) [thread overview]
Message-ID: <20190406.181834.995998216821289412.davem@davemloft.net> (raw)
In-Reply-To: <20190404144603.27682-1-colin.king@canonical.com>
From: Colin King <colin.king@canonical.com>
Date: Thu, 4 Apr 2019 15:46:03 +0100
> From: Colin Ian King <colin.king@canonical.com>
>
> The non-null check on tskb is always false because it is in an else
> path of a check on tskb and hence tskb is null in this code block.
> This is check is therefore redundant and can be removed as well
> as the label coalesc.
>
> if (tsbk) {
> ...
> } else {
> ...
> if (unlikely(!skb)) {
> if (tskb) /* can never be true, redundant code */
> goto coalesc;
> return;
> }
> }
>
> Addresses-Coverity: ("Logically dead code")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Applied to net-next.
prev parent reply other threads:[~2019-04-07 1:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-04 14:46 [PATCH] tcp: remove redundant check on tskb Colin King
2019-04-04 15:05 ` Dan Carpenter
2019-04-05 6:47 ` Mukesh Ojha
2019-04-05 7:46 ` Eric Dumazet
2019-04-07 1:18 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190406.181834.995998216821289412.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=colin.king@canonical.com \
--cc=edumazet@google.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).