From: Rob Herring <robh@kernel.org>
To: Bartosz Golaszewski <brgl@bgdev.pl>
Cc: Mark Rutland <mark.rutland@arm.com>,
Linus Walleij <linus.walleij@linaro.org>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Jacek Anaszewski <jacek.anaszewski@gmail.com>,
Pavel Machek <pavel@ucw.cz>, Lee Jones <lee.jones@linaro.org>,
Sebastian Reichel <sre@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
devicetree@vger.kernel.org, linux-input@vger.kernel.org,
linux-leds@vger.kernel.org, linux-pm@vger.kernel.org,
Bartosz Golaszewski <bgolaszewski@baylibre.com>
Subject: Re: [PATCH v8 02/11] dt-bindings: power: supply: add DT bindings for max77650
Date: Sat, 6 Apr 2019 02:07:46 -0500 [thread overview]
Message-ID: <20190406070746.GA29624@bogus> (raw)
In-Reply-To: <20190403090108.24788-3-brgl@bgdev.pl>
On Wed, Apr 03, 2019 at 11:00:59AM +0200, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
>
> Add the DT binding document for the battery charger module of max77650.
>
> Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> ---
> .../power/supply/max77650-charger.txt | 27 +++++++++++++++++++
> 1 file changed, 27 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/power/supply/max77650-charger.txt
>
> diff --git a/Documentation/devicetree/bindings/power/supply/max77650-charger.txt b/Documentation/devicetree/bindings/power/supply/max77650-charger.txt
> new file mode 100644
> index 000000000000..fef188144386
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/power/supply/max77650-charger.txt
> @@ -0,0 +1,27 @@
> +Battery charger driver for MAX77650 PMIC from Maxim Integrated.
> +
> +This module is part of the MAX77650 MFD device. For more details
> +see Documentation/devicetree/bindings/mfd/max77650.txt.
> +
> +The charger is represented as a sub-node of the PMIC node on the device tree.
> +
> +Required properties:
> +--------------------
> +- compatible: Must be "maxim,max77650-charger"
> +
> +Optional properties:
> +--------------------
> +- min-microvolt: Minimum CHGIN regulation voltage (in microvolts). Must be
> + one of: 4000000, 4100000, 4200000, 4300000, 4400000,
> + 4500000, 4600000, 4700000.
> +- current-limit-microamp: CHGIN input current limit (in microamps). Must
> + be one of: 95000, 190000, 285000, 380000, 475000.
To repeat what I said on v6, these should be common properties IMO (and
therefore documented as such).
> +
> +Example:
> +--------
> +
> + charger {
> + compatible = "maxim,max77650-charger";
> + min-microvolt = <4200000>;
> + curr-lim-microamp = <285000>;
> + };
> --
> 2.21.0
>
next prev parent reply other threads:[~2019-04-06 7:07 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-03 9:00 [PATCH v8 00/11] mfd: add support for max77650 PMIC Bartosz Golaszewski
2019-04-03 9:00 ` [PATCH v8 01/11] dt-bindings: mfd: add DT bindings for max77650 Bartosz Golaszewski
2019-04-03 9:00 ` [PATCH v8 02/11] dt-bindings: power: supply: " Bartosz Golaszewski
2019-04-06 7:07 ` Rob Herring [this message]
2019-04-08 12:25 ` Bartosz Golaszewski
2019-04-09 1:10 ` Rob Herring
2019-04-09 11:04 ` Bartosz Golaszewski
2019-04-09 15:38 ` Bartosz Golaszewski
2019-04-11 16:50 ` Rob Herring
2019-04-03 9:01 ` [PATCH v8 03/11] dt-bindings: leds: " Bartosz Golaszewski
2019-04-04 13:22 ` Pavel Machek
2019-04-03 9:01 ` [PATCH v8 04/11] dt-bindings: input: " Bartosz Golaszewski
2019-04-03 9:01 ` [PATCH v8 05/11] mfd: core: document mfd_add_devices() Bartosz Golaszewski
2019-04-04 7:04 ` Lee Jones
2019-04-03 9:01 ` [PATCH v8 06/11] mfd: max77650: new core mfd driver Bartosz Golaszewski
2019-04-04 7:15 ` Lee Jones
2019-04-04 7:30 ` Bartosz Golaszewski
2019-04-03 9:01 ` [PATCH v8 07/11] power: supply: max77650: add support for battery charger Bartosz Golaszewski
2019-04-03 9:01 ` [PATCH v8 08/11] gpio: max77650: add GPIO support Bartosz Golaszewski
2019-04-03 9:01 ` [PATCH v8 09/11] leds: max77650: add LEDs support Bartosz Golaszewski
2019-04-04 13:22 ` Pavel Machek
2019-04-03 9:01 ` [PATCH v8 10/11] input: max77650: add onkey support Bartosz Golaszewski
2019-04-03 9:01 ` [PATCH v8 11/11] MAINTAINERS: add an entry for max77650 mfd driver Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190406070746.GA29624@bogus \
--to=robh@kernel.org \
--cc=bgolaszewski@baylibre.com \
--cc=brgl@bgdev.pl \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jacek.anaszewski@gmail.com \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pavel@ucw.cz \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).