From: David Miller <davem@davemloft.net>
To: dsa@cumulusnetworks.com
Cc: linmiaohe@huawei.com, shrijeet@gmail.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, mingfangsen@huawei.com
Subject: Re: [PATCH net v3] net: vrf: Fix ping failed when vrf mtu is set to 0
Date: Sun, 07 Apr 2019 22:49:47 -0700 (PDT) [thread overview]
Message-ID: <20190407.224947.1057169172447711389.davem@davemloft.net> (raw)
In-Reply-To: <22ff0d05-c1af-ad08-4cae-39dec91eff47@cumulusnetworks.com>
From: David Ahern <dsa@cumulusnetworks.com>
Date: Sun, 7 Apr 2019 20:51:05 -0700
> On 4/7/19 7:04 PM, linmiaohe wrote:
>> From: Miaohe Lin <linmiaohe@huawei.com>
>>
>> When the mtu of a vrf device is set to 0, it would cause ping
>> failed. So I think we should limit vrf mtu in a reasonable range
>> to solve this problem. I set dev->min_mtu to IPV6_MIN_MTU, so it
>> will works for both ipv4 and ipv6. And if dev->max_mtu still be 0
>> can be confusing, so I set dev->max_mtu to ETH_MAX_MTU.
>>
>> Here is the reproduce step:
...
>> Fixes: ad49bc6361ca2 ("net: vrf: remove MTU limits for vrf device")
>> Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
>> ---
>
> Reviewed-by: David Ahern <dsahern@gmail.com>
Applied and queued up for -stable, thanks.
prev parent reply other threads:[~2019-04-08 5:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-08 2:04 [PATCH net v3] net: vrf: Fix ping failed when vrf mtu is set to 0 linmiaohe
2019-04-08 3:51 ` David Ahern
2019-04-08 5:49 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190407.224947.1057169172447711389.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dsa@cumulusnetworks.com \
--cc=linmiaohe@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingfangsen@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=shrijeet@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).