From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3902EC10F0E for ; Sun, 7 Apr 2019 14:32:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id ED46B20B1F for ; Sun, 7 Apr 2019 14:32:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=megous.com header.i=@megous.com header.b="MRgrQogD" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726495AbfDGOcm (ORCPT ); Sun, 7 Apr 2019 10:32:42 -0400 Received: from vps.xff.cz ([195.181.215.36]:45084 "EHLO vps.xff.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726049AbfDGOcm (ORCPT ); Sun, 7 Apr 2019 10:32:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megous.com; s=mail; t=1554647557; bh=CqAcBHJsBRr4BHEO8o/YFawdCkRmicl/XAT3sMJnxuE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=MRgrQogDmAfjKULbIs/m8+7mcK3QZIBRVrzmmgx1qM++N+DaX222W328w65fMZfSb P47jtXYrG/kWNHTNAccijnjEPGTrbNtJ8KX5NYEPn0eOyt6NYScgfYphRXOqI5l5uE GVw8ZCbSQXfd72KX0PqmI01uhDdZsE+5w9dS21Z8= Date: Sun, 7 Apr 2019 16:32:37 +0200 From: =?utf-8?Q?Ond=C5=99ej?= Jirman To: =?utf-8?B?Q2zDqW1lbnQgUMOpcm9u?= Cc: linux-sunxi@googlegroups.com, Maxime Ripard , Chen-Yu Tsai , Rob Herring , Linus Walleij , David Airlie , Daniel Vetter , Mark Rutland , Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , "David S. Miller" , Maxime Coquelin , Arend van Spriel , Franky Lin , Hante Meuleman , Chi-Hsien Lin , Wright Feng , Kalle Valo , Naveen Gupta , dri-devel@lists.freedesktop.org, devicetree , linux-arm-kernel , linux-kernel , netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-wireless@vger.kernel.org, brcm80211-dev-list.pdl@broadcom.com, brcm80211-dev-list@cypress.com, linux-gpio@vger.kernel.org Subject: Re: [linux-sunxi] [PATCH 00/12] Add support for Orange Pi 3 Message-ID: <20190407143237.2qyoef4r5e3qvbmh@core.my.home> Mail-Followup-To: =?utf-8?B?Q2zDqW1lbnQgUMOpcm9u?= , linux-sunxi@googlegroups.com, Maxime Ripard , Chen-Yu Tsai , Rob Herring , Linus Walleij , David Airlie , Daniel Vetter , Mark Rutland , Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , "David S. Miller" , Maxime Coquelin , Arend van Spriel , Franky Lin , Hante Meuleman , Chi-Hsien Lin , Wright Feng , Kalle Valo , Naveen Gupta , dri-devel@lists.freedesktop.org, devicetree , linux-arm-kernel , linux-kernel , netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-wireless@vger.kernel.org, brcm80211-dev-list.pdl@broadcom.com, brcm80211-dev-list@cypress.com, linux-gpio@vger.kernel.org References: <20190405234514.6183-1-megous@megous.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Apr 07, 2019 at 03:36:21PM +0200, Clément Péron wrote: > Hi, > > On Sat, 6 Apr 2019 at 01:45, megous via linux-sunxi > wrote: > > > > From: Ondrej Jirman > > > > This series implements support for Xunlong Orange Pi 3 board. > > OrangePi 3 Lite2 and One Plus boards support has already been merged. > The support is not complete but you should rebase your patches on top > of sunxi/for-next Hi, OrangePi 3 is somewhat different from these two boards (mostly it has a differnt power tree). It doesn't use the AXP regulators that are defined in the sun50i-h6-orangepi.dtsi in the same way. For example: - bldo3 (is turned always on in sun50i-h6-orangepi.dtsi but unused for opi3) - cldo2 and cldo3 are unused on opi3 and have nothing to do with WiFi - aldo3 is not for dram - bldo1 on the other hand is for dram on opi3 - some other regulators are used for different/more functions and thus named differntly - USB id-det pin is differnt - ... OrangePi 3 is not a superset of what is defined in sun50i-h6-orangepi.dtsi. So to base Orange Pi 3 dts on top of existing sun50i-h6-orangepi.dtsi I'd have to first move some things out of the base dtsi to the OrangePi Lite2 and One Plus board dts files, in order to have sun50i-h6-orangepi.dtsi only describe HW that is *really* shared by these 2 boards and Orange Pi 3. If I do that, I'd undefine all the axp805 regulator nodes and move the configurations to each of the 3 board files. That will probably end up being the least confusing and most maintainable. See axp81x.dtsi lines 86-144 for what I mean. What do you think? Is this acceptable to everyone? regards, o. > https://git.kernel.org/pub/scm/linux/kernel/git/sunxi/linux.git/tree/arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi.dtsi?h=sunxi/for-next > > Regards, > Clement > > > > > Unfortunately, this board needs some small driver patches, so I have > > split the boards DT patch into chunks that require patches for drivers > > in various subsystems: > > > > - Basic DT for the board (patch 1) > > - HDMI support (patches 2, 3, 4) > > - Ethernet support (patches 5, 6, 7) > > - WiFi support (patches 8, 9, 10, 11, 12) > > > > This patch is also needed to not get segfault on boot: > > https://lkml.org/lkml/2019/4/5/856 > > > > Please take a look. > > > > regards, > > Ondrej Jirman > > > > Icenowy Zheng (2): > > net: stmmac: sun8i: add support for Allwinner H6 EMAC > > net: stmmac: sun8i: force select external PHY when no internal one > > > > Ondrej Jirman (10): > > arm64: dts: allwinner: h6: Add Orange Pi 3 DTS > > drm: sun4i: Add support for enabling DDC I2C bus to dw_hdmi glue > > dt-bindings: display: sun4i-drm: Add DDC power supply > > arm64: dts: allwinner: orange-pi-3: Enable HDMI output > > arm64: dts: allwinner: orange-pi-3: Enable ethernet > > arm64: dts: allwinner: h6: Add MMC1 pins > > pinctrl: sunxi: Prepare for alternative bias voltage setting methods > > pinctrl: sunxi: Support I/O bias voltage setting on H6 > > brcmfmac: Loading the correct firmware for brcm43456 > > arm64: dts: allwinner: orange-pi-3: Enable WiFi > > > > .../bindings/display/sunxi/sun4i-drm.txt | 1 + > > arch/arm64/boot/dts/allwinner/Makefile | 1 + > > .../dts/allwinner/sun50i-h6-orangepi-3.dts | 339 ++++++++++++++++++ > > arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi | 9 + > > drivers/gpu/drm/sun4i/sun8i_dw_hdmi.c | 17 +- > > drivers/gpu/drm/sun4i/sun8i_dw_hdmi.h | 1 + > > .../net/ethernet/stmicro/stmmac/dwmac-sun8i.c | 22 ++ > > .../broadcom/brcm80211/brcmfmac/sdio.c | 4 +- > > drivers/pinctrl/sunxi/pinctrl-sun50i-h6.c | 1 + > > drivers/pinctrl/sunxi/pinctrl-sun9i-a80.c | 2 +- > > drivers/pinctrl/sunxi/pinctrl-sunxi.c | 50 ++- > > drivers/pinctrl/sunxi/pinctrl-sunxi.h | 7 +- > > 12 files changed, 433 insertions(+), 21 deletions(-) > > create mode 100644 arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi-3.dts > > > > -- > > 2.21.0 > > > > -- > > You received this message because you are subscribed to the Google Groups "linux-sunxi" group. > > To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscribe@googlegroups.com. > > For more options, visit https://groups.google.com/d/optout.