From: "Theodore Ts'o" <tytso@mit.edu>
To: Liu Xiang <liu.xiang6@zte.com.cn>
Cc: linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org,
adilger.kernel@dilger.ca, liuxiang_1999@126.com
Subject: Re: [PATCH v2] ext4: fix prefetchw of NULL page
Date: Sun, 7 Apr 2019 11:55:21 -0400 [thread overview]
Message-ID: <20190407155521.GL18897@mit.edu> (raw)
In-Reply-To: <1554019894-11041-1-git-send-email-liu.xiang6@zte.com.cn>
On Sun, Mar 31, 2019 at 04:11:34PM +0800, Liu Xiang wrote:
> In ext4_mpage_readpages(), if the parameter pages is not NULL, another
> parameter page is NULL. At the first time prefetchw(&page->flags)
> works on NULL. From second time, prefetchw(&page->flags) always works on
> the last consumed page. This might do little improvment for handling
> current page. So prefetchw() should be called while the page pointer
> has just been updated.
Thanks, applied.
- Ted
prev parent reply other threads:[~2019-04-07 16:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-31 8:11 [PATCH v2] ext4: fix prefetchw of NULL page Liu Xiang
2019-04-07 15:55 ` Theodore Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190407155521.GL18897@mit.edu \
--to=tytso@mit.edu \
--cc=adilger.kernel@dilger.ca \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liu.xiang6@zte.com.cn \
--cc=liuxiang_1999@126.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).