From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E29D3C282CE for ; Mon, 8 Apr 2019 09:10:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B71CC213F2 for ; Mon, 8 Apr 2019 09:10:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726486AbfDHJKM convert rfc822-to-8bit (ORCPT ); Mon, 8 Apr 2019 05:10:12 -0400 Received: from bhuna.collabora.co.uk ([46.235.227.227]:44610 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725983AbfDHJKM (ORCPT ); Mon, 8 Apr 2019 05:10:12 -0400 Received: from localhost (unknown [IPv6:2a01:e0a:2c:6930:5cf4:84a1:2763:fe0d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: bbrezillon) by bhuna.collabora.co.uk (Postfix) with ESMTPSA id 55FC026068F; Mon, 8 Apr 2019 10:10:09 +0100 (BST) Date: Mon, 8 Apr 2019 11:10:06 +0200 From: Boris Brezillon To: Douglas Anderson Cc: Thierry Reding , Heiko Stuebner , Sean Paul , linux-rockchip@lists.infradead.org, Laurent Pinchart , dri-devel@lists.freedesktop.org, Ezequiel Garcia , Enric =?UTF-8?B?QmFsbGV0YsOy?= , Rob Herring , mka@chromium.org, Eric Anholt , Jeffy Chen , =?UTF-8?B?U3TDqXBoYW5l?= Marchesin , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, David Airlie , Mark Rutland , Daniel Vetter Subject: Re: [PATCH v5 1/7] dt-bindings: Add panel-timing subnode to simple-panel Message-ID: <20190408111006.6b8fe312@collabora.com> In-Reply-To: <20190401171724.215780-2-dianders@chromium.org> References: <20190401171724.215780-1-dianders@chromium.org> <20190401171724.215780-2-dianders@chromium.org> Organization: Collabora X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 1 Apr 2019 10:17:18 -0700 Douglas Anderson wrote: > From: Sean Paul > > This patch adds a new subnode to simple-panel allowing us to override > the typical timing expressed in the panel's display_timing. > > Changes in v2: > - Split out the binding into a new patch (Rob) > - display-timings is a new section (Rob) > - Use the full display-timings subnode instead of picking the timing > out (Rob/Thierry) > Changes in v3: > - Go back to using the timing subnode directly, but rename to > panel-timing (Rob) > Changes in v4: > - Simplify desc. for when override should be used (Thierry/Laurent) > - Removed Rob H review since it's been a year and wording changed > Changes in v5: > - Removed bit about OS may ignore (Rob/Ezequiel) > > Cc: Doug Anderson > Cc: Eric Anholt > Cc: Heiko Stuebner > Cc: Jeffy Chen > Cc: Rob Herring > Cc: Stéphane Marchesin > Cc: Thierry Reding > Cc: devicetree@vger.kernel.org > Cc: dri-devel@lists.freedesktop.org > Cc: linux-rockchip@lists.infradead.org > Signed-off-by: Sean Paul > Signed-off-by: Douglas Anderson Reviewed-by: Boris Brezillon > --- > > .../bindings/display/panel/simple-panel.txt | 22 +++++++++++++++++++ > 1 file changed, 22 insertions(+) > > diff --git a/Documentation/devicetree/bindings/display/panel/simple-panel.txt b/Documentation/devicetree/bindings/display/panel/simple-panel.txt > index b2b872c710f2..93882268c0b9 100644 > --- a/Documentation/devicetree/bindings/display/panel/simple-panel.txt > +++ b/Documentation/devicetree/bindings/display/panel/simple-panel.txt > @@ -15,6 +15,16 @@ Optional properties: > (hot plug detect) signal, but the signal isn't hooked up so we should > hardcode the max delay from the panel spec when powering up the panel. > > +panel-timing subnode > +-------------------- > + > +This optional subnode is for devices which require a mode differing > +from the panel's "typical" display timing. > + > +Format information on the panel-timing subnode can be found in > +display-timing.txt. > + > + > Example: > > panel: panel { > @@ -25,4 +35,16 @@ Example: > enable-gpios = <&gpio 90 0>; > > backlight = <&backlight>; > + > + panel-timing { > + clock-frequency = <266604720>; > + hactive = <2400>; > + hfront-porch = <48>; > + hback-porch = <84>; > + hsync-len = <32>; > + vactive = <1600>; > + vfront-porch = <3>; > + vback-porch = <120>; > + vsync-len = <10>; > + }; > };