LKML Archive on lore.kernel.org
 help / color / Atom feed
From: Junichi Nomura <j-nomura@ce.jp.nec.com>
To: Borislav Petkov <bp@alien8.de>, Dave Young <dyoung@redhat.com>,
	Chao Fan <fanc.fnst@cn.fujitsu.com>, Baoquan He <bhe@redhat.com>
Cc: Kairui Song <kasong@redhat.com>,
	"x86@kernel.org" <x86@kernel.org>,
	"kexec@lists.infradead.org" <kexec@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: [PATCH v4] x86/boot: Use efi_setup_data for searching RSDP on kexec-ed kernel
Date: Mon, 8 Apr 2019 23:10:17 +0000
Message-ID: <20190408231011.GA5402@jeru.linux.bs1.fc.nec.co.jp> (raw)

Commit 3a63f70bf4c3a ("x86/boot: Early parse RSDP and save it in
boot_params") broke kexec boot on EFI systems.  efi_get_rsdp_addr()
in the early parsing code tries to search RSDP from EFI table but
that will crash because the table address is virtual when the kernel
was booted by kexec.

In the case of kexec, physical address of EFI tables is provided
via efi_setup_data in boot_params, which is set up by kexec(1).

Factor out the table parsing code and use different pointers depending
on whether the kernel is booted by kexec or not.

Fixes: 3a63f70bf4c3a ("x86/boot: Early parse RSDP and save it in boot_params")
Signed-off-by: Jun'ichi Nomura <j-nomura@ce.jp.nec.com>
Acked-by: Baoquan He <bhe@redhat.com>
Tested-by: Chao Fan <fanc.fnst@cn.fujitsu.com>
Cc: Borislav Petkov <bp@suse.de>
Cc: Dave Young <dyoung@redhat.com>

--
Original post:
  https://lore.kernel.org/lkml/20190322110342.GA16202@jeru.linux.bs1.fc.nec.co.jp/

v2: Added comments above __efi_get_rsdp_addr() and kexec_get_rsdp_addr() 

v3: Properly ifdef out 64bit-only kexec code to avoid 32bit build warnings

v4:
 - Make sure to avoid efi_get_rsdp_addr() when kexec setup_data exists
   even if the data is invalid.
 - Return instead of hang if systab is 0 in kexec_get_rsdp_addr().
 - Check 32bit EFI loader signature in the case of kexec as well.
 - Factor out EFI-related boot_params handling into efi_read_boot_params() to
   avoid duplication between efi_get_rsdp_addr() and kexec_get_rsdp_addr().

The patch was tested on 3 different models of EFI-booted physical machines
for both normal kexec and panic kexec.

There is a report, that similar problem still happens even with this patch:
  https://lore.kernel.org/lkml/20190404140809.GA7789@dhcp-128-65.nay.redhat.com/

diff --git a/arch/x86/boot/compressed/acpi.c b/arch/x86/boot/compressed/acpi.c
index 0ef4ad5..2bc8dca 100644
--- a/arch/x86/boot/compressed/acpi.c
+++ b/arch/x86/boot/compressed/acpi.c
@@ -44,71 +44,80 @@ static acpi_physical_address get_acpi_rsdp(void)
 	return addr;
 }
 
-/* Search EFI system tables for RSDP. */
-static acpi_physical_address efi_get_rsdp_addr(void)
+#ifdef CONFIG_EFI
+static unsigned long kexec_efi_setup_data;
+static unsigned long efi_systab;
+static bool efi_booted;
+static bool efi_64;
+
+static unsigned long efi_get_kexec_setup_data_addr(void)
 {
-	acpi_physical_address rsdp_addr = 0;
+#if defined(CONFIG_X86_64)
+	struct setup_data *data;
+	u64 pa_data;
+
+	pa_data = boot_params->hdr.setup_data;
+	while (pa_data) {
+		data = (struct setup_data *) pa_data;
+		if (data->type == SETUP_EFI)
+			return pa_data + sizeof(struct setup_data);
+		pa_data = data->next;
+	}
+#endif
+	return 0;
+}
 
-#ifdef CONFIG_EFI
-	unsigned long systab, systab_tables, config_tables;
-	unsigned int nr_tables;
+static void efi_read_boot_params(void)
+{
+	struct efi_setup_data *esd;
 	struct efi_info *ei;
-	bool efi_64;
-	int size, i;
 	char *sig;
 
+	kexec_efi_setup_data = efi_get_kexec_setup_data_addr();
+
 	ei = &boot_params->efi_info;
 	sig = (char *)&ei->efi_loader_signature;
 
 	if (!strncmp(sig, EFI64_LOADER_SIGNATURE, 4)) {
 		efi_64 = true;
+		efi_booted = true;
 	} else if (!strncmp(sig, EFI32_LOADER_SIGNATURE, 4)) {
 		efi_64 = false;
+		efi_booted = true;
 	} else {
 		debug_putstr("Wrong EFI loader signature.\n");
-		return 0;
+		return;
 	}
 
 	/* Get systab from boot params. */
 #ifdef CONFIG_X86_64
-	systab = ei->efi_systab | ((__u64)ei->efi_systab_hi << 32);
+	efi_systab = ei->efi_systab | ((__u64)ei->efi_systab_hi << 32);
 #else
 	if (ei->efi_systab_hi || ei->efi_memmap_hi) {
 		debug_putstr("Error getting RSDP address: EFI system table located above 4GB.\n");
-		return 0;
+		return;
 	}
-	systab = ei->efi_systab;
+	efi_systab = ei->efi_systab;
 #endif
-	if (!systab)
-		error("EFI system table not found.");
-
-	/* Handle EFI bitness properly */
-	if (efi_64) {
-		efi_system_table_64_t *stbl = (efi_system_table_64_t *)systab;
-
-		config_tables	= stbl->tables;
-		nr_tables	= stbl->nr_tables;
-		size		= sizeof(efi_config_table_64_t);
-	} else {
-		efi_system_table_32_t *stbl = (efi_system_table_32_t *)systab;
-
-		config_tables	= stbl->tables;
-		nr_tables	= stbl->nr_tables;
-		size		= sizeof(efi_config_table_32_t);
-	}
+}
 
-	if (!config_tables)
-		error("EFI config tables not found.");
+/*
+ * Search EFI system tables for RSDP.  If both ACPI_20_TABLE_GUID and
+ * ACPI_TABLE_GUID are found, take the former, which has more features.
+ */
+static acpi_physical_address
+__efi_get_rsdp_addr(unsigned long config_tables, unsigned int nr_tables)
+{
+	acpi_physical_address rsdp_addr = 0;
+	int i;
 
 	/* Get EFI tables from systab. */
 	for (i = 0; i < nr_tables; i++) {
 		acpi_physical_address table;
 		efi_guid_t guid;
 
-		config_tables += size;
-
 		if (efi_64) {
-			efi_config_table_64_t *tbl = (efi_config_table_64_t *)config_tables;
+			efi_config_table_64_t *tbl = (efi_config_table_64_t *) config_tables + i;
 
 			guid  = tbl->guid;
 			table = tbl->table;
@@ -118,7 +127,7 @@ static acpi_physical_address efi_get_rsdp_addr(void)
 				return 0;
 			}
 		} else {
-			efi_config_table_32_t *tbl = (efi_config_table_32_t *)config_tables;
+			efi_config_table_32_t *tbl = (efi_config_table_32_t *) config_tables + i;
 
 			guid  = tbl->guid;
 			table = tbl->table;
@@ -129,9 +138,88 @@ static acpi_physical_address efi_get_rsdp_addr(void)
 		else if (!(efi_guidcmp(guid, ACPI_20_TABLE_GUID)))
 			return table;
 	}
-#endif
+
 	return rsdp_addr;
 }
+#endif
+
+/*
+ * EFI/kexec support is only added for 64bit. So we don't have to
+ * care 32bit case.
+ */
+static acpi_physical_address kexec_get_rsdp_addr(void)
+{
+#if defined(CONFIG_EFI) && defined(CONFIG_X86_64)
+	struct efi_setup_data *esd;
+	unsigned int nr_tables;
+
+	if (!efi_booted || !kexec_efi_setup_data)
+		return 0;
+
+	esd = (struct efi_setup_data *) kexec_efi_setup_data;
+
+	if (!esd->tables) {
+		debug_putstr("Wrong kexec SETUP_EFI data.\n");
+		return 0;
+	}
+
+	if (!efi_systab) {
+		debug_putstr("EFI system table not found in kexec boot_params.");
+		return 0;
+	}
+
+	/* Handle EFI bitness properly */
+	if (efi_64) {
+		efi_system_table_64_t *stbl = (efi_system_table_64_t *)efi_systab;
+
+		nr_tables	= stbl->nr_tables;
+	} else {
+		efi_system_table_32_t *stbl = (efi_system_table_32_t *)efi_systab;
+
+		nr_tables	= stbl->nr_tables;
+	}
+
+	return __efi_get_rsdp_addr((unsigned long) esd->tables, nr_tables);
+#else
+	return 0;
+#endif
+}
+
+static acpi_physical_address efi_get_rsdp_addr(void)
+{
+#ifdef CONFIG_EFI
+	unsigned long config_tables;
+	unsigned int nr_tables;
+
+	efi_read_boot_params();
+
+	if (!efi_booted || kexec_efi_setup_data)
+		return 0;
+
+	if (!efi_systab)
+		error("EFI system table not found.");
+
+	/* Handle EFI bitness properly */
+	if (efi_64) {
+		efi_system_table_64_t *stbl = (efi_system_table_64_t *)efi_systab;
+
+		config_tables	= stbl->tables;
+		nr_tables	= stbl->nr_tables;
+	} else {
+		efi_system_table_32_t *stbl = (efi_system_table_32_t *)efi_systab;
+
+		config_tables	= stbl->tables;
+		nr_tables	= stbl->nr_tables;
+	}
+
+	if (!config_tables)
+		error("EFI config tables not found.");
+
+	return __efi_get_rsdp_addr(config_tables, nr_tables);
+#else
+	return 0;
+#endif
+}
 
 static u8 compute_checksum(u8 *buffer, u32 length)
 {
@@ -224,6 +312,9 @@ acpi_physical_address get_rsdp_addr(void)
 		pa = efi_get_rsdp_addr();
 
 	if (!pa)
+		pa = kexec_get_rsdp_addr();
+
+	if (!pa)
 		pa = bios_get_rsdp_addr();
 
 	return pa;

             reply index

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-08 23:10 Junichi Nomura [this message]
2019-04-10 17:14 ` Borislav Petkov
2019-04-10 23:34   ` Junichi Nomura
2019-04-11  8:09     ` Borislav Petkov
2019-04-11  8:16       ` Junichi Nomura
2019-04-11  8:37         ` Borislav Petkov
2019-04-11  9:13           ` Junichi Nomura
2019-04-11  9:21             ` Boris Petkov
2019-04-11  9:32               ` Junichi Nomura
2019-04-11  9:40                 ` Boris Petkov
2019-04-11 12:58                   ` Borislav Petkov
2019-04-12  2:54                     ` Junichi Nomura
2019-04-12  8:49                       ` Borislav Petkov
2019-04-12 13:35                         ` Borislav Petkov
2019-04-15  7:01                           ` Junichi Nomura
2019-04-15  9:07                             ` Borislav Petkov
2019-04-15 10:25                               ` Borislav Petkov
2019-04-15 23:00                                 ` Junichi Nomura
2019-04-15 23:14                                   ` Junichi Nomura
2019-04-16  9:45                                     ` Borislav Petkov
2019-04-16 23:09                                       ` kexec crash on OVMF i386 + x86_64 kernel (Re: [PATCH v4] x86/boot: Use efi_setup_data for searching RSDP on kexec-ed kernel) Junichi Nomura
2019-04-17  5:14                                         ` Dave Young
2019-04-17 17:57                                           ` Prakhya, Sai Praneeth
2019-04-16  9:40                                   ` [PATCH v4] x86/boot: Use efi_setup_data for searching RSDP on kexec-ed kernel Borislav Petkov
2019-04-16  9:52                                     ` [PATCH] x86/boot: Use efi_setup_data for searching RSDP on kexec-ed kernels Borislav Petkov
2019-04-16 10:02                                       ` Ingo Molnar
2019-04-16 10:31                                         ` Borislav Petkov
2019-04-16 11:41                                       ` Dave Young
2019-04-16 13:22                                         ` Borislav Petkov
2019-04-17  1:38                                           ` Dave Young
2019-04-17  4:57                                             ` Dave Young
2019-04-17  6:00                                               ` Kairui Song
2019-04-17  7:08                                                 ` Dave Young
2019-04-17  8:22                                             ` Borislav Petkov
2019-04-18  1:24                                               ` Dave Young
2019-04-19  8:34                                       ` [RFC PATCH] kexec, x86/boot: map systab region in identity mapping before accessing it Kairui Song
2019-04-19  8:58                                         ` Baoquan He
2019-04-19  9:39                                           ` Kairui Song
2019-04-16 22:44                                     ` [PATCH v4] x86/boot: Use efi_setup_data for searching RSDP on kexec-ed kernel Junichi Nomura
2019-04-17  7:02                                       ` Dave Young
2019-04-17  8:54                                         ` Borislav Petkov
2019-04-17  9:02                                           ` Borislav Petkov
2019-04-17 10:31                                           ` Chao Fan
2019-04-11  8:42         ` Baoquan He
2019-04-11  9:14           ` Junichi Nomura
2019-04-12  0:23             ` Baoquan He
2019-04-15  7:46               ` Dave Young
2019-06-06 19:22 ` [tip:x86/boot] x86/boot: Use efi_setup_data for searching RSDP on kexec-ed kernels tip-bot for Junichi Nomura

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190408231011.GA5402@jeru.linux.bs1.fc.nec.co.jp \
    --to=j-nomura@ce.jp.nec.com \
    --cc=bhe@redhat.com \
    --cc=bp@alien8.de \
    --cc=dyoung@redhat.com \
    --cc=fanc.fnst@cn.fujitsu.com \
    --cc=kasong@redhat.com \
    --cc=kexec@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

LKML Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/lkml/0 lkml/git/0.git
	git clone --mirror https://lore.kernel.org/lkml/1 lkml/git/1.git
	git clone --mirror https://lore.kernel.org/lkml/2 lkml/git/2.git
	git clone --mirror https://lore.kernel.org/lkml/3 lkml/git/3.git
	git clone --mirror https://lore.kernel.org/lkml/4 lkml/git/4.git
	git clone --mirror https://lore.kernel.org/lkml/5 lkml/git/5.git
	git clone --mirror https://lore.kernel.org/lkml/6 lkml/git/6.git
	git clone --mirror https://lore.kernel.org/lkml/7 lkml/git/7.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 lkml lkml/ https://lore.kernel.org/lkml \
		linux-kernel@vger.kernel.org
	public-inbox-index lkml

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-kernel


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git