From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Georgi Djakov <georgi.djakov@linaro.org>
Cc: robh+dt@kernel.org, vkoul@kernel.org, evgreen@chromium.org,
daidavid1@codeaurora.org, linux-pm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH 2/3] interconnect: qcom: Add QCS404 interconnect provider driver
Date: Mon, 8 Apr 2019 20:27:14 -0700 [thread overview]
Message-ID: <20190409032714.GT1843@tuxbook-pro> (raw)
In-Reply-To: <0ca7862f-31ba-748a-945d-a925a40a16de@linaro.org>
On Mon 08 Apr 07:33 PDT 2019, Georgi Djakov wrote:
> On 4/5/19 17:57, Bjorn Andersson wrote:
> > On Fri 05 Apr 10:54 +07 2019, Georgi Djakov wrote:
> > [..]
[..]
> >> diff --git a/drivers/interconnect/qcom/qcs404_ids.h b/drivers/interconnect/qcom/qcs404_ids.h
> >
> > You use these defines in the driver, so I think this file should be the
> > one in include/dt-bindings...
>
> The ids in this header are in a single global namespace in order to
> build the internal topology and could be used for drivers that support
> only platform data (although not sure if there would be any).
>
As you say these numbers could be used by drivers on non-DT enabled
platforms, but for that this include file should be in
include/linux/interconnect. That said, there are no such Qualcomm
platforms, so these numbers will only ever be used internally in the
qcs404.c provider, so it would be better to just define them in that
file - to remove the risk of confusion.
> >
> > [..]
> >> diff --git a/include/dt-bindings/interconnect/qcom,qcs404.h b/include/dt-bindings/interconnect/qcom,qcs404.h
> >
>
> These header is using per NoC local ids and should be used on DT enabled
> platforms.
>
I had missed that you implemented support for xlating NoC-specific ids,
so this makes sense now, nice. I presume we won't ever include files in
a way where these defines collide - so this looks good.
Regards,
Bjorn
next prev parent reply other threads:[~2019-04-09 3:27 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-05 3:54 [PATCH 0/3] Add QCS404 interconnect provider driver Georgi Djakov
2019-04-05 3:54 ` [PATCH 1/3] dt-bindings: interconnect: Add Qualcomm QCS404 DT bindings Georgi Djakov
2019-04-05 14:32 ` Bjorn Andersson
2019-04-05 15:46 ` Georgi Djakov
2019-04-08 22:38 ` Bjorn Andersson
2019-04-05 3:54 ` [PATCH 2/3] interconnect: qcom: Add QCS404 interconnect provider driver Georgi Djakov
2019-04-05 14:57 ` Bjorn Andersson
2019-04-08 14:33 ` Georgi Djakov
2019-04-09 3:27 ` Bjorn Andersson [this message]
2019-04-09 10:27 ` Georgi Djakov
2019-04-05 3:54 ` [PATCH 3/3] arm64: dts: qcs404: Add interconnect provider DT nodes Georgi Djakov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190409032714.GT1843@tuxbook-pro \
--to=bjorn.andersson@linaro.org \
--cc=daidavid1@codeaurora.org \
--cc=devicetree@vger.kernel.org \
--cc=evgreen@chromium.org \
--cc=georgi.djakov@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).