From: Maxime Ripard <maxime.ripard@bootlin.com>
To: linux-sunxi@googlegroups.com, Chen-Yu Tsai <wens@csie.org>,
Rob Herring <robh+dt@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
Mark Rutland <mark.rutland@arm.com>,
Giuseppe Cavallaro <peppe.cavallaro@st.com>,
Alexandre Torgue <alexandre.torgue@st.com>,
Jose Abreu <joabreu@synopsys.com>,
"David S. Miller" <davem@davemloft.net>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Arend van Spriel <arend.vanspriel@broadcom.com>,
Franky Lin <franky.lin@broadcom.com>,
Hante Meuleman <hante.meuleman@broadcom.com>,
Chi-Hsien Lin <chi-hsien.lin@cypress.com>,
Wright Feng <wright.feng@cypress.com>,
Kalle Valo <kvalo@codeaurora.org>,
Naveen Gupta <naveen.gupta@cypress.com>,
dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-wireless@vger.kernel.org,
brcm80211-dev-list.pdl@broadcom.com,
brcm80211-dev-list@cypress.com, linux-gpio@vger.kernel.org
Subject: Re: [PATCH 08/12] arm64: dts: allwinner: h6: Add MMC1 pins
Date: Tue, 9 Apr 2019 09:20:45 +0200 [thread overview]
Message-ID: <20190409072045.hb6us26bgfk36am5@flea> (raw)
In-Reply-To: <20190408224104.qwhk33qgem7bq5y7@core.my.home>
[-- Attachment #1: Type: text/plain, Size: 2282 bytes --]
Hi,
On Tue, Apr 09, 2019 at 12:41:05AM +0200, Ondřej Jirman wrote:
> On Mon, Apr 08, 2019 at 09:43:27AM +0200, Maxime Ripard wrote:
> > On Sat, Apr 06, 2019 at 01:45:10AM +0200, megous@megous.com wrote:
> > > From: Ondrej Jirman <megous@megous.com>
> > >
> > > ---
> > > arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi | 9 +++++++++
> > > 1 file changed, 9 insertions(+)
> > >
> > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi
> > > index 91fecab58836..dccad79da90c 100644
> > > --- a/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi
> > > +++ b/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi
> > > @@ -238,6 +238,15 @@
> > > bias-pull-up;
> > > };
> > >
> > > +
> >
> > Extra line
> >
> > > + mmc1_pins: mmc1-pins {
> > > + pins = "PG0", "PG1", "PG2", "PG3",
> > > + "PG4", "PG5";
> > > + function = "mmc1";
> > > + drive-strength = <30>;
> > > + bias-pull-up;
> > > + };
> > > +
> >
> > Is that the only muxing option?
>
> I don't think so. I believe someone can use a 1-bit interface (bus-width = <1>),
> and then some data pins will be free. This pinconfig is for 4-bit bus width
> setup.
>
> Though other SoCs (ex. H3, A83T) don't consider this possibility and make the
> 4-bit config the default pinctrl for mmc1. To add to the confusion, on these
> SoCs 4-bit pinconf is the default, but 1bit bus-width is the (implicit) default.
> This led to some confusion in the past.
>
> So we can either:
> - keep consistency with what is done elsewhere, and make this default, despite
> not being the only option,
What is done elsewhere is that if it's the only option, just call it
$controller_pins and make that the default. If it isn't, then call it
$(controller)_$(bank)_pins, and put it at the board level.
If it's not the only muxing option, then your name should be called
mmc1-pg-pins
> - or perhaps I can rename this to mmc1_bus_width4_pins, or somesuch, to make it
> more explicit, and keep it non-default.
We haven't encountered a case where the 1-bit bus was actually used,
so there's no need to take care of that.
Maxime
--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2019-04-09 7:20 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-05 23:45 [PATCH 00/12] Add support for Orange Pi 3 megous
2019-04-05 23:45 ` [PATCH 01/12] arm64: dts: allwinner: h6: Add Orange Pi 3 DTS megous
2019-04-08 7:46 ` Maxime Ripard
2019-04-08 22:58 ` Ondřej Jirman
2019-04-09 7:22 ` Maxime Ripard
2019-04-05 23:45 ` [PATCH 02/12] drm: sun4i: Add support for enabling DDC I2C bus to dw_hdmi glue megous
2019-04-08 7:23 ` Maxime Ripard
2019-04-08 7:28 ` [linux-sunxi] " Chen-Yu Tsai
2019-04-08 8:47 ` Maxime Ripard
2019-04-08 12:17 ` Ondřej Jirman
2019-04-09 7:45 ` Maxime Ripard
2019-04-05 23:45 ` [PATCH 03/12] dt-bindings: display: sun4i-drm: Add DDC power supply megous
2019-04-05 23:45 ` [PATCH 04/12] arm64: dts: allwinner: orange-pi-3: Enable HDMI output megous
2019-04-08 7:24 ` Maxime Ripard
2019-04-05 23:45 ` [PATCH 05/12] net: stmmac: sun8i: add support for Allwinner H6 EMAC megous
2019-04-08 7:25 ` Maxime Ripard
2019-04-05 23:45 ` [PATCH 06/12] net: stmmac: sun8i: force select external PHY when no internal one megous
2019-04-06 10:24 ` Sergei Shtylyov
2019-04-05 23:45 ` [PATCH 07/12] arm64: dts: allwinner: orange-pi-3: Enable ethernet megous
2019-04-08 6:11 ` Jagan Teki
2019-04-08 22:26 ` Ondřej Jirman
2019-04-08 7:40 ` Maxime Ripard
2019-04-08 23:22 ` Ondřej Jirman
2019-04-09 7:23 ` Maxime Ripard
2019-04-09 7:35 ` Linus Walleij
2019-04-05 23:45 ` [PATCH 08/12] arm64: dts: allwinner: h6: Add MMC1 pins megous
2019-04-08 7:43 ` Maxime Ripard
2019-04-08 22:41 ` Ondřej Jirman
2019-04-09 7:20 ` Maxime Ripard [this message]
2019-04-05 23:45 ` [PATCH 09/12] pinctrl: sunxi: Prepare for alternative bias voltage setting methods megous
2019-04-08 12:53 ` Linus Walleij
2019-04-08 13:08 ` Ondřej Jirman
2019-04-05 23:45 ` [PATCH 10/12] pinctrl: sunxi: Support I/O bias voltage setting on H6 megous
2019-04-08 1:31 ` Ondřej Jirman
2019-04-08 7:42 ` Maxime Ripard
2019-04-05 23:45 ` [PATCH 11/12] brcmfmac: Loading the correct firmware for brcm43456 megous
2019-04-13 11:06 ` Kalle Valo
2019-04-05 23:45 ` [PATCH 12/12] arm64: dts: allwinner: orange-pi-3: Enable WiFi megous
2019-04-07 15:31 ` [linux-sunxi] " Clément Péron
2019-04-07 16:15 ` Ondřej Jirman
2019-04-07 13:36 ` [linux-sunxi] [PATCH 00/12] Add support for Orange Pi 3 Clément Péron
2019-04-07 14:32 ` Ondřej Jirman
2019-04-07 15:08 ` Clément Péron
2019-04-08 6:01 ` Jagan Teki
2019-04-08 12:46 ` Ondřej Jirman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190409072045.hb6us26bgfk36am5@flea \
--to=maxime.ripard@bootlin.com \
--cc=airlied@linux.ie \
--cc=alexandre.torgue@st.com \
--cc=arend.vanspriel@broadcom.com \
--cc=brcm80211-dev-list.pdl@broadcom.com \
--cc=brcm80211-dev-list@cypress.com \
--cc=chi-hsien.lin@cypress.com \
--cc=daniel@ffwll.ch \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=franky.lin@broadcom.com \
--cc=hante.meuleman@broadcom.com \
--cc=joabreu@synopsys.com \
--cc=kvalo@codeaurora.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=linux-sunxi@googlegroups.com \
--cc=linux-wireless@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=naveen.gupta@cypress.com \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
--cc=robh+dt@kernel.org \
--cc=wens@csie.org \
--cc=wright.feng@cypress.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).