From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C13A1C282CE for ; Tue, 9 Apr 2019 12:41:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9190C2084C for ; Tue, 9 Apr 2019 12:41:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727239AbfDIMlT (ORCPT ); Tue, 9 Apr 2019 08:41:19 -0400 Received: from mga18.intel.com ([134.134.136.126]:46068 "EHLO mga18.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726535AbfDIMlT (ORCPT ); Tue, 9 Apr 2019 08:41:19 -0400 X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Apr 2019 05:41:17 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,329,1549958400"; d="scan'208";a="162716684" Received: from kuha.fi.intel.com ([10.237.72.189]) by fmsmga001.fm.intel.com with SMTP; 09 Apr 2019 05:41:14 -0700 Received: by kuha.fi.intel.com (sSMTP sendmail emulation); Tue, 09 Apr 2019 15:41:13 +0300 Date: Tue, 9 Apr 2019 15:41:13 +0300 From: Heikki Krogerus To: Andy Shevchenko Cc: "Rafael J. Wysocki" , Greg Kroah-Hartman , Hans de Goede , Darren Hart , Andy Shevchenko , ACPI Devel Maling List , Linux Kernel Mailing List , Platform Driver Subject: Re: [PATCH 08/11] platform/x86: intel_cht_int33fe: Provide software nodes for the devices Message-ID: <20190409124113.GB20058@kuha.fi.intel.com> References: <20190403164537.24643-1-heikki.krogerus@linux.intel.com> <20190403164537.24643-9-heikki.krogerus@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.11.3 (2019-02-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 08, 2019 at 07:09:15PM +0300, Andy Shevchenko wrote: > On Wed, Apr 3, 2019 at 7:46 PM Heikki Krogerus > wrote: > > > > Software nodes provide two features that we will need later. > > 1) Software nodes can have references to other software nodes. > > 2) Software nodes can exist before a device entry is created. > > > #include > > #include > > #include > > +#include > > I understand your attitude to ordering here, but we already have it > ordered, why not to keep it that way? Sure. I'll keep the order. > > -static struct i2c_client *cht_int33fe_find_max17047(void) > > -{ > > - struct i2c_client *max17047 = NULL; > > - > > - i2c_for_each_dev(&max17047, cht_int33fe_check_for_max17047); > > - return max17047; > > -} > > This sounds like a cleanup patch before actual change. > And I'm not sure, do we need to remove this function? > > > +static int > > +cht_int33fe_max17047(struct device *dev, struct cht_int33fe_data *data) > > +{ > > + struct fwnode_handle *fwnode = data->node[INT33FE_NODE_MAX17047]; > > + struct i2c_client *max17047 = NULL; > > + struct i2c_board_info board_info; > > + int ret; > > + > > + i2c_for_each_dev(&max17047, cht_int33fe_check_for_max17047); > > + if (max17047) { > > + /* Pre-existing i2c-client for the max17047, add device-props */ > > + max17047->dev.fwnode->secondary = fwnode; > > + /* And re-probe to get the new device-props applied. */ > > + ret = device_reprobe(&max17047->dev); > > + if (ret) > > + dev_warn(dev, "Reprobing max17047 error: %d\n", ret); > > + return 0; > > + } > > + > > + memset(&board_info, 0, sizeof(board_info)); > > + strlcpy(board_info.type, "max17047", I2C_NAME_SIZE); > > + board_info.dev_name = "max17047"; > > + board_info.fwnode = fwnode; > > + data->max17047 = i2c_acpi_new_device(dev, 1, &board_info); > > + if (IS_ERR(data->max17047)) > > + return PTR_ERR(data->max17047); > > + > > + return 0; > > +} > > This looks like a split from the original code with some changes. > Perhaps, split patch first. > > > /* Work around BIOS bug, see comment on cht_int33fe_find_max17047 */ > > After this patch, the comment here become outdated, care to fix? > > > + ret = cht_int33fe_max17047(dev, data); > > Seems like the verb is missed in the name of the function. Yeah, I never meant to rename the function. I'll just keep the function name as cht_int33fe_find_max17047. thanks, -- heikki