From: Sudeep Holla <sudeep.holla@arm.com>
To: Kangjie Lu <kjlu@umn.edu>
Cc: pakki001@umn.edu, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Sudeep Holla <sudeep.holla@arm.com>,
Steven Price <steven.price@arm.com>
Subject: Re: [PATCH] firmware: arm_scmi: check return value of idr_find
Date: Wed, 10 Apr 2019 17:31:27 +0100 [thread overview]
Message-ID: <20190410163127.GG3952@e107155-lin> (raw)
In-Reply-To: <20190325204823.5428-1-kjlu@umn.edu>
On Mon, Mar 25, 2019 at 03:48:22PM -0500, Kangjie Lu wrote:
You should mark this v2 id you changed any code or commit message or
added any tags. Just FYI for future.
> Thanks for Steven Price's review of this patch. In the current code,
> idr_find won't return NULL because the SCMI_PROTOCOL_BASE id must
> exist. However, it might return NULL in the future code if the check
> is on another node while processing the children in subsequent calls
> to scmi_mbox_chan_setup().
I don't understand the reference here to future code here. If you have
out of tree code that results in such a scenario, please share or
provide the details on that.
As I mentioned in previous mail, I would bail out much earlier if
SCMI_PROTOCOL_BASE is not allocated IDR and not reach to this point.
We continue even if scmi_create_protocol_device fails for few child
devices.
--
Regards,
Sudeep
next prev parent reply other threads:[~2019-04-10 16:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-09 4:02 [PATCH] firmware: arm_scmi: check return value of idr_find Kangjie Lu
2019-03-23 2:18 ` Kangjie Lu
2019-03-25 11:54 ` Steven Price
2019-03-25 20:48 ` Kangjie Lu
2019-03-26 11:34 ` Steven Price
2019-04-10 16:31 ` Sudeep Holla [this message]
2019-04-10 16:25 ` Sudeep Holla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190410163127.GG3952@e107155-lin \
--to=sudeep.holla@arm.com \
--cc=kjlu@umn.edu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pakki001@umn.edu \
--cc=steven.price@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).