From: Louis Taylor <louis@kragniz.eu>
To: dhowells@redhat.com
Cc: linux-afs@lists.infradead.org, linux-kernel@vger.kernel.org,
clang-built-linux@googlegroups.com,
Louis Taylor <louis@kragniz.eu>
Subject: [PATCH] afs: use correct format characters
Date: Wed, 10 Apr 2019 23:03:01 +0100 [thread overview]
Message-ID: <20190410220301.2332-1-louis@kragniz.eu> (raw)
When compiling with -Wformat, clang warns:
fs/afs/flock.c:632:29: warning: format specifies type 'short' but the argument has type
'unsigned char' [-Wformat]
_leave(" = %d [%hd]", ret, fl->fl_type);
~~~ ^~~~~~~~~~~
fl_type is declared as an unsigned char unconditionally in
include/linux/fs.h, so use the correct format characters.
Link: https://github.com/ClangBuiltLinux/linux/issues/378
Signed-off-by: Louis Taylor <louis@kragniz.eu>
---
fs/afs/flock.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/afs/flock.c b/fs/afs/flock.c
index 6a0174258382..be4c3f6a3178 100644
--- a/fs/afs/flock.c
+++ b/fs/afs/flock.c
@@ -629,7 +629,7 @@ static int afs_do_getlk(struct file *file, struct file_lock *fl)
ret = 0;
error:
- _leave(" = %d [%hd]", ret, fl->fl_type);
+ _leave(" = %d [%hhu]", ret, fl->fl_type);
return ret;
}
--
2.21.0
next reply other threads:[~2019-04-10 22:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-10 22:03 Louis Taylor [this message]
2019-04-10 22:27 ` Nick Desaulniers
2019-04-10 22:41 ` [PATCH v2] " Louis Taylor
2019-04-10 22:52 ` Nick Desaulniers
2019-04-12 15:48 ` David Laight
2019-04-10 23:00 ` [PATCH] " Joe Perches
2019-04-11 16:31 ` Linus Torvalds
2019-04-11 17:41 ` Nick Desaulniers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190410220301.2332-1-louis@kragniz.eu \
--to=louis@kragniz.eu \
--cc=clang-built-linux@googlegroups.com \
--cc=dhowells@redhat.com \
--cc=linux-afs@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--subject='Re: [PATCH] afs: use correct format characters' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).