From: Sinan Kaya <okaya@kernel.org>
To: linux-kernel@vger.kernel.org
Cc: josh@joshtriplett.org, Sinan Kaya <okaya@kernel.org>,
Kees Cook <keescook@chromium.org>,
Masahiro Yamada <yamada.masahiro@socionext.com>,
Andrew Morton <akpm@linux-foundation.org>,
"Peter Zijlstra (Intel)" <peterz@infradead.org>,
Johannes Weiner <hannes@cmpxchg.org>,
Nicholas Piggin <npiggin@gmail.com>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Vasily Gorbik <gor@linux.ibm.com>, Adrian Reber <adrian@lisas.de>,
Richard Guy Briggs <rgb@redhat.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Petr Mladek <pmladek@suse.com>,
Joe Lawrence <joe.lawrence@redhat.com>,
Matthew Wilcox <willy@infradead.org>,
Randy Dunlap <rdunlap@infradead.org>,
Mikulas Patocka <mpatocka@redhat.com>,
Robin Murphy <robin.murphy@arm.com>,
Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>,
Changbin Du <changbin.du@intel.com>
Subject: [PATCH v3] init: Do not select DEBUG_KERNEL by default
Date: Thu, 11 Apr 2019 00:56:31 +0000 [thread overview]
Message-ID: <20190411005634.8495-1-okaya@kernel.org> (raw)
We can't seem to have a kernel with CONFIG_EXPERT set but
CONFIG_DEBUG_KERNEL unset these days.
While some of the features under the CONFIG_EXPERT require
CONFIG_DEBUG_KERNEL, it doesn't apply for all features.
It looks like CONFIG_KALLSYMS_ALL is the only feature that
requires CONFIG_DEBUG_KERNEL.
Select CONFIG_EXPERT when CONFIG_DEBUG_KERNEL is chosen but
you can still choose CONFIG_EXPERT without CONFIG_DEBUG_KERNEL.
Signed-off-by: Sinan Kaya <okaya@kernel.org>
Reviewed-by: Kees Cook <keescook@chromium.org>
---
init/Kconfig | 2 --
lib/Kconfig.debug | 1 +
2 files changed, 1 insertion(+), 2 deletions(-)
diff --git a/init/Kconfig b/init/Kconfig
index 4592bf7997c0..37e10a8391a3 100644
--- a/init/Kconfig
+++ b/init/Kconfig
@@ -1206,8 +1206,6 @@ config BPF
menuconfig EXPERT
bool "Configure standard kernel features (expert users)"
- # Unhide debug options, to make the on-by-default options visible
- select DEBUG_KERNEL
help
This option allows certain base kernel options and settings
to be disabled or tweaked. This is for specialized
diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
index 0d9e81779e37..9fbf3499ec8d 100644
--- a/lib/Kconfig.debug
+++ b/lib/Kconfig.debug
@@ -434,6 +434,7 @@ config MAGIC_SYSRQ_SERIAL
config DEBUG_KERNEL
bool "Kernel debugging"
+ default EXPERT
help
Say Y here if you are developing drivers or trying to debug and
identify kernel problems.
--
2.21.0
next reply other threads:[~2019-04-11 0:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-11 0:56 Sinan Kaya [this message]
2019-04-11 2:39 ` [PATCH v3] init: Do not select DEBUG_KERNEL by default Kees Cook
2019-04-11 5:33 ` Masahiro Yamada
2019-04-11 17:00 ` Kees Cook
2019-04-11 22:18 ` Josh Triplett
2019-04-11 5:31 ` Masahiro Yamada
2019-04-11 5:42 ` Sinan Kaya
2019-04-11 5:48 ` Masahiro Yamada
2019-04-11 18:15 ` Sinan Kaya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190411005634.8495-1-okaya@kernel.org \
--to=okaya@kernel.org \
--cc=adrian@lisas.de \
--cc=akpm@linux-foundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=changbin.du@intel.com \
--cc=gor@linux.ibm.com \
--cc=hannes@cmpxchg.org \
--cc=joe.lawrence@redhat.com \
--cc=josh@joshtriplett.org \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mpatocka@redhat.com \
--cc=npiggin@gmail.com \
--cc=penguin-kernel@i-love.sakura.ne.jp \
--cc=peterz@infradead.org \
--cc=pmladek@suse.com \
--cc=rdunlap@infradead.org \
--cc=rgb@redhat.com \
--cc=robin.murphy@arm.com \
--cc=willy@infradead.org \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).